| Message ID | 1433751990-21544-1-git-send-email-ander.conselvan.de.oliveira@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Thanks for testing. -------- Forwarded Message -------- From: Stefan Lippers-Hollmann <s.l-h@gmx.de> To: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Subject: Re: [PATCH] drm/i915: Properly initialize SDVO analog connectors Date: Mon, 8 Jun 2015 12:16:04 +0200 Hi On 2015-06-08, Ander Conselvan de Oliveira wrote: > In the commit below, I missed the connector allocation in the function > intel_sdvo_analog_init(), leading to those connectors to have a NULL > state pointer. Thanks a lot, this patch is working (on top of 4.1-rc7). > commit 08d9bc920d465bbbbd762cac9383249c19bf69a2 > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> > Date: Fri Apr 10 10:59:10 2015 +0300 > > drm/i915: Allocate connector state together with the connectors > > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Feel free to add: Tested-by: Stefan Lippers-Hollmann <s.l-h@gmx.de> Regards Stefan Lippers-Hollmann
On Mon, 08 Jun 2015, Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> wrote: > In the commit below, I missed the connector allocation in the function > intel_sdvo_analog_init(), leading to those connectors to have a NULL > state pointer. > > commit 08d9bc920d465bbbbd762cac9383249c19bf69a2 > Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> > Date: Fri Apr 10 10:59:10 2015 +0300 > > drm/i915: Allocate connector state together with the connectors > > Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Pushed to drm-intel-fixes, thanks for the patch and testing. BR, Jani. > --- > drivers/gpu/drm/i915/intel_sdvo.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c > index d24ef75..aa2fd75 100644 > --- a/drivers/gpu/drm/i915/intel_sdvo.c > +++ b/drivers/gpu/drm/i915/intel_sdvo.c > @@ -2554,7 +2554,7 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device) > > DRM_DEBUG_KMS("initialising analog device %d\n", device); > > - intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); > + intel_sdvo_connector = intel_sdvo_connector_alloc(); > if (!intel_sdvo_connector) > return false; > > -- > 2.1.0 >
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c b/drivers/gpu/drm/i915/intel_sdvo.c index d24ef75..aa2fd75 100644 --- a/drivers/gpu/drm/i915/intel_sdvo.c +++ b/drivers/gpu/drm/i915/intel_sdvo.c @@ -2554,7 +2554,7 @@ intel_sdvo_analog_init(struct intel_sdvo *intel_sdvo, int device) DRM_DEBUG_KMS("initialising analog device %d\n", device); - intel_sdvo_connector = kzalloc(sizeof(*intel_sdvo_connector), GFP_KERNEL); + intel_sdvo_connector = intel_sdvo_connector_alloc(); if (!intel_sdvo_connector) return false;
In the commit below, I missed the connector allocation in the function intel_sdvo_analog_init(), leading to those connectors to have a NULL state pointer. commit 08d9bc920d465bbbbd762cac9383249c19bf69a2 Author: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> Date: Fri Apr 10 10:59:10 2015 +0300 drm/i915: Allocate connector state together with the connectors Signed-off-by: Ander Conselvan de Oliveira <ander.conselvan.de.oliveira@intel.com> --- drivers/gpu/drm/i915/intel_sdvo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)