From patchwork Tue Jun 23 21:35:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 6663721 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 11C599F40A for ; Tue, 23 Jun 2015 21:36:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3A2982063A for ; Tue, 23 Jun 2015 21:36:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id E29B720663 for ; Tue, 23 Jun 2015 21:36:45 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E4BE26EA98; Tue, 23 Jun 2015 14:36:44 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qg0-f46.google.com (mail-qg0-f46.google.com [209.85.192.46]) by gabe.freedesktop.org (Postfix) with ESMTP id AF91C6EA98 for ; Tue, 23 Jun 2015 14:36:43 -0700 (PDT) Received: by qged89 with SMTP id d89so8097479qge.0 for ; Tue, 23 Jun 2015 14:36:43 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=jTDxpv0c3tZ/jdb2rZwC132WOTytTBVLr7nY8cSMlfM=; b=YxHHwpRuHMPTD/z/VwXfAlZ9f4yc8S8YPVmAbMDBvyLNbvgAjnYuX8qPoMJLw22FxH 1+6uMz5hPT7S8sqEjWenxXUKhOvo/C4CpGuBTWl8tuMaM1m1/9R/2zaqS3KM8eQAWJtH 7pRznwyuZblRF3RWZbWySU01wb54UDZTnIWtnVF0OlMUOWz33s1TxAOGPvJagHbVLmQN Nxd2pFnhowI7hsLPh5bCOcFjWJordiup9qMsttCDSpBRKXn9aaQ4hqT58Srm5JctYvy+ pp8mWPacvemc97h4P2/zPAxXPVnhYNB4ZNNyAM7ctMsT90R9n+2kynYJ9P5zwynAnyxP jDzg== X-Received: by 10.55.48.209 with SMTP id w200mr78616156qkw.13.1435095403292; Tue, 23 Jun 2015 14:36:43 -0700 (PDT) Received: from jade.localdomain ([177.103.14.143]) by mx.google.com with ESMTPSA id q4sm2132242qkq.33.2015.06.23.14.36.40 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 23 Jun 2015 14:36:42 -0700 (PDT) From: Gustavo Padovan To: linux-samsung-soc@vger.kernel.org Subject: [PATCH 20/23] drm/exynos: remove exynos_encoder's .commit() op Date: Tue, 23 Jun 2015 18:35:33 -0300 Message-Id: <1435095336-6196-21-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.1.0 In-Reply-To: <1435095336-6196-1-git-send-email-gustavo@padovan.org> References: <1435095336-6196-1-git-send-email-gustavo@padovan.org> Cc: tjakobi@math.uni-bielefeld.de, Gustavo Padovan , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan .commit() is not used anymore, Exynos encoders now follow the .enable()/.disable() semantics from drm atomic core, so remove this callback. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_drv.h | 2 -- drivers/gpu/drm/exynos/exynos_drm_encoder.c | 3 --- 2 files changed, 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_drv.h b/drivers/gpu/drm/exynos/exynos_drm_drv.h index 4bd770a..762b625 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_drv.h +++ b/drivers/gpu/drm/exynos/exynos_drm_drv.h @@ -87,7 +87,6 @@ struct exynos_drm_plane { * would be called by encoder->mode_set(). * @enable: display device on. * @disable: display device off. - * @commit: apply changes to hw */ struct exynos_drm_encoder; struct exynos_drm_encoder_ops { @@ -100,7 +99,6 @@ struct exynos_drm_encoder_ops { struct drm_display_mode *mode); void (*enable)(struct exynos_drm_encoder *encoder); void (*disable)(struct exynos_drm_encoder *encoder); - void (*commit)(struct exynos_drm_encoder *encoder); }; /* diff --git a/drivers/gpu/drm/exynos/exynos_drm_encoder.c b/drivers/gpu/drm/exynos/exynos_drm_encoder.c index b9a1c93..ce7b97e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_encoder.c +++ b/drivers/gpu/drm/exynos/exynos_drm_encoder.c @@ -56,9 +56,6 @@ static void exynos_drm_encoder_enable(struct drm_encoder *encoder) if (exynos_encoder->ops->enable) exynos_encoder->ops->enable(exynos_encoder); - - if (exynos_encoder->ops->commit) - exynos_encoder->ops->commit(exynos_encoder); } static void exynos_drm_encoder_disable(struct drm_encoder *encoder)