From patchwork Mon Jun 29 04:33:27 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Maninder Singh X-Patchwork-Id: 6687231 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 90840C05AC for ; Mon, 29 Jun 2015 04:34:01 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id BC1622051C for ; Mon, 29 Jun 2015 04:34:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3C4C820515 for ; Mon, 29 Jun 2015 04:33:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 018E56E28A; Sun, 28 Jun 2015 21:33:58 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C40C6E28A for ; Sun, 28 Jun 2015 21:33:56 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NQO00ZJCVCHPW40@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 29 Jun 2015 13:33:53 +0900 (KST) Received: from epcpsbgm2.samsung.com ( [172.20.52.125]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 88.C2.29324.1BAC0955; Mon, 29 Jun 2015 13:33:53 +0900 (KST) X-AuditID: cbfee68d-f79106d00000728c-8d-5590cab10d06 Received: from epmmp1.local.host ( [203.254.227.16]) by epcpsbgm2.samsung.com (EPCPMTA) with SMTP id 6E.0A.05312.1BAC0955; Mon, 29 Jun 2015 13:33:53 +0900 (KST) Received: from localhost.localdomain ([107.108.92.210]) by mmp1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NQO00DBFVBXBCU0@mmp1.samsung.com>; Mon, 29 Jun 2015 13:33:53 +0900 (KST) From: Maninder Singh To: oded.gabbay@gmail.com, airlied@linux.ie, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [RFC][PATCH 1/1] drm/amdkfd: Remove redundant pdd validation Date: Mon, 29 Jun 2015 10:03:27 +0530 Message-id: <1435552407-39924-1-git-send-email-maninder1.s@samsung.com> X-Mailer: git-send-email 1.7.9.5 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrLLMWRmVeSWpSXmKPExsWyRsSkVnfjqQmhBm8+Wlr0njvJZHHl63s2 i8u75rBZHJ7fxmJx4cVtVot7b7YyObB57Jx1l91j+7cHrB73u48zefRtWcXo8XmTXABrFJdN SmpOZllqkb5dAlfGjXfTWQomslX0z//M3sDYz9rFyMkhIWAi8XJhMyOELSZx4d56ti5GLg4h gaWMEhMWzGGCKVr97w87RGIRo8Sy75ugqn4ySmx7/Q5sFJuAnsSqXXtYQGwRgRyJdY+fANkc HMwCThLTv+qBhIUFXCWeTZsPVsIioCrx+nYXO4jNK+AusXP3ClaQcgkBBYk5k2xAxksIfGeT 2Dd/EjNEvYDEt8mHWCBqZCU2HWCGuE1S4uCKGywTGAUXMDKsYhRNLUguKE5KLzLUK07MLS7N S9dLzs/dxAgM1dP/nvXuYLx9wPoQowAHoxIPb+SmCaFCrIllxZW5hxhNgTZMZJYSTc4HRkRe SbyhsZmRhamJqbGRuaWZkjivotTPYCGB9MSS1OzU1ILUovii0pzU4kOMTBycUg2MFQenKq+f ESrK3Tf3yYWkq0smine7FE5tfmJ2yZN95yWTfxJqp8V+Ob702XD53O/SBz4PKyusn0ooXpnz 3/iz/11VUa3lFY9eak2c7qLnFn//1hzXI85JW1j2R934+XZpyR+BVSdVZky4cPiKgV6uk3nd w4qXfK+nX7llom7H6XI1ddGftP3nDiqxFGckGmoxFxUnAgDDUbd3UAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFmpnkeLIzCtJLcpLzFFi42I5/e+xgO7GUxNCDfZsMbboPXeSyeLK1/ds Fpd3zWGzODy/jcXiwovbrBb33mxlcmDz2DnrLrvH9m8PWD3udx9n8ujbsorR4/MmuQDWqAZG m4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygE5QUyhJz SoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGTfeTWcpmMhW0T//M3sDYz9rFyMn h4SAicTqf3/YIWwxiQv31rN1MXJxCAksYpRY9n0TlPOTUWLb63dgHWwCehKrdu1hAbFFBHIk 1j1+AmRzcDALOElM/6oHEhYWcJV4Nm0+WAmLgKrE69tdYAt4Bdwldu5ewQpSLiGgIDFnks0E Ru4FjAyrGEVTC5ILipPSc430ihNzi0vz0vWS83M3MYIj4Zn0DsZVDRaHGAU4GJV4eE+enBAq xJpYVlyZe4hRgoNZSYT38magEG9KYmVValF+fFFpTmrxIUZToOUTmaVEk/OBUZpXEm9obGJu amxqaWJhYmapJM57Mt8nVEggPbEkNTs1tSC1CKaPiYNTqoGRRfxMX/POL8/lZJ6o5ek59wgc KAkJmbLwDNuN1fM3n/shkqp5Q+KY6PSbEo4HXswMF8jkWCb5cu5VExYnp5TSNVzP7spl/6te MUvsrP6KbYrcD+SFdLOPrl4Ud/qhuIJ80HYb07OfF+u7Pb3sus134pWOxyeeLlyzWnDjvuOS 5rtFFJxW2AvzKLEUZyQaajEXFScCAGo/T0maAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: Maninder Singh , pankaj.m@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.9 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP pdd is already dereferenced before this check. So it is redundtant to validate pdd here. Signed-off-by: Maninder Singh --- drivers/gpu/drm/amd/amdkfd/kfd_process.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/amdkfd/kfd_process.c b/drivers/gpu/drm/amd/amdkfd/kfd_process.c index 8a1f999..4dbc4e5 100644 --- a/drivers/gpu/drm/amd/amdkfd/kfd_process.c +++ b/drivers/gpu/drm/amd/amdkfd/kfd_process.c @@ -431,8 +431,7 @@ void kfd_unbind_process_from_device(struct kfd_dev *dev, unsigned int pasid) * We don't call amd_iommu_unbind_pasid() here * because the IOMMU called us. */ - if (pdd) - pdd->bound = false; + pdd->bound = false; mutex_unlock(&p->mutex); }