diff mbox

[1/2] drm/doc: Add hflip/vflip property descriptions in msm

Message ID 1438037853-14912-1-git-send-email-jilaiw@codeaurora.org
State New, archived
Headers show

Commit Message

jilai wang July 27, 2015, 10:57 p.m. UTC
Add plane properties hflip/vflip which are used in MDP driver to flip
the input horizontally/vertically.

Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>
---
 Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
 1 file changed, 16 insertions(+), 2 deletions(-)

Comments

Daniel Vetter July 28, 2015, 8:29 a.m. UTC | #1
On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
> Add plane properties hflip/vflip which are used in MDP driver to flip
> the input horizontally/vertically.
> 
> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>

Is the existing rotation prop with flip masks not enough?
-Daniel

> ---
>  Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>  1 file changed, 16 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
> index d9f5613..bef6d34 100644
> --- a/Documentation/DocBook/drm.tmpl
> +++ b/Documentation/DocBook/drm.tmpl
> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>  	<td valign="top" >TBD</td>
>  	</tr>
>  	<tr>
> -	<td rowspan="3" valign="top" >msm</td>
> -	<td rowspan="3" valign="top" >Generic</td>
> +	<td rowspan="5" valign="top" >msm</td>
> +	<td rowspan="5" valign="top" >Generic</td>
>  	<td valign="top" >"premultiplied"</td>
>  	<td valign="top" >ENUM</td>
>  	<td valign="top" >{ "false", "true" }</td>
> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>  	<td valign="top" >Plane</td>
>  	<td valign="top" >property to set plane's z position during blending</td>
>  	</tr>
> +	<tr>
> +	<td valign="top" >"hflip"</td>
> +	<td valign="top" >ENUM</td>
> +	<td valign="top" >{ "off", "on" }</td>
> +	<td valign="top" >Plane</td>
> +	<td valign="top" >property to flip the input horizontally</td>
> +	</tr>
> +	<tr>
> +	<td valign="top" >"vflip"</td>
> +	<td valign="top" >ENUM</td>
> +	<td valign="top" >{ "off", "on" }</td>
> +	<td valign="top" >Plane</td>
> +	<td valign="top" >property to flip the input vertically</td>
> +	</tr>
>  	</tbody>
>  	</table>
>      </sect2>
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
jilai wang July 29, 2015, 8:50 p.m. UTC | #2
Thanks for this information, Daniel.
I will change it to use rotation prop in next patch.
> On Mon, Jul 27, 2015 at 06:57:33PM -0400, Jilai Wang wrote:
>> Add plane properties hflip/vflip which are used in MDP driver to flip
>> the input horizontally/vertically.
>>
>> Signed-off-by: Jilai Wang <jilaiw@codeaurora.org>
>
> Is the existing rotation prop with flip masks not enough?
> -Daniel
>
>> ---
>>  Documentation/DocBook/drm.tmpl | 18 ++++++++++++++++--
>>  1 file changed, 16 insertions(+), 2 deletions(-)
>>
>> diff --git a/Documentation/DocBook/drm.tmpl
>> b/Documentation/DocBook/drm.tmpl
>> index d9f5613..bef6d34 100644
>> --- a/Documentation/DocBook/drm.tmpl
>> +++ b/Documentation/DocBook/drm.tmpl
>> @@ -3501,8 +3501,8 @@ void intel_crt_init(struct drm_device *dev)
>>  	<td valign="top" >TBD</td>
>>  	</tr>
>>  	<tr>
>> -	<td rowspan="3" valign="top" >msm</td>
>> -	<td rowspan="3" valign="top" >Generic</td>
>> +	<td rowspan="5" valign="top" >msm</td>
>> +	<td rowspan="5" valign="top" >Generic</td>
>>  	<td valign="top" >"premultiplied"</td>
>>  	<td valign="top" >ENUM</td>
>>  	<td valign="top" >{ "false", "true" }</td>
>> @@ -3523,6 +3523,20 @@ void intel_crt_init(struct drm_device *dev)
>>  	<td valign="top" >Plane</td>
>>  	<td valign="top" >property to set plane's z position during
>> blending</td>
>>  	</tr>
>> +	<tr>
>> +	<td valign="top" >"hflip"</td>
>> +	<td valign="top" >ENUM</td>
>> +	<td valign="top" >{ "off", "on" }</td>
>> +	<td valign="top" >Plane</td>
>> +	<td valign="top" >property to flip the input horizontally</td>
>> +	</tr>
>> +	<tr>
>> +	<td valign="top" >"vflip"</td>
>> +	<td valign="top" >ENUM</td>
>> +	<td valign="top" >{ "off", "on" }</td>
>> +	<td valign="top" >Plane</td>
>> +	<td valign="top" >property to flip the input vertically</td>
>> +	</tr>
>>  	</tbody>
>>  	</table>
>>      </sect2>
>> --
>> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora
>> Forum,
>> a Linux Foundation Collaborative Project
>>
>> _______________________________________________
>> dri-devel mailing list
>> dri-devel@lists.freedesktop.org
>> http://lists.freedesktop.org/mailman/listinfo/dri-devel
>
> --
> Daniel Vetter
> Software Engineer, Intel Corporation
> http://blog.ffwll.ch
>
diff mbox

Patch

diff --git a/Documentation/DocBook/drm.tmpl b/Documentation/DocBook/drm.tmpl
index d9f5613..bef6d34 100644
--- a/Documentation/DocBook/drm.tmpl
+++ b/Documentation/DocBook/drm.tmpl
@@ -3501,8 +3501,8 @@  void intel_crt_init(struct drm_device *dev)
 	<td valign="top" >TBD</td>
 	</tr>
 	<tr>
-	<td rowspan="3" valign="top" >msm</td>
-	<td rowspan="3" valign="top" >Generic</td>
+	<td rowspan="5" valign="top" >msm</td>
+	<td rowspan="5" valign="top" >Generic</td>
 	<td valign="top" >"premultiplied"</td>
 	<td valign="top" >ENUM</td>
 	<td valign="top" >{ "false", "true" }</td>
@@ -3523,6 +3523,20 @@  void intel_crt_init(struct drm_device *dev)
 	<td valign="top" >Plane</td>
 	<td valign="top" >property to set plane's z position during blending</td>
 	</tr>
+	<tr>
+	<td valign="top" >"hflip"</td>
+	<td valign="top" >ENUM</td>
+	<td valign="top" >{ "off", "on" }</td>
+	<td valign="top" >Plane</td>
+	<td valign="top" >property to flip the input horizontally</td>
+	</tr>
+	<tr>
+	<td valign="top" >"vflip"</td>
+	<td valign="top" >ENUM</td>
+	<td valign="top" >{ "off", "on" }</td>
+	<td valign="top" >Plane</td>
+	<td valign="top" >property to flip the input vertically</td>
+	</tr>
 	</tbody>
 	</table>
     </sect2>