From patchwork Tue Jul 28 08:53:18 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 6880931 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 4D89BC05AC for ; Tue, 28 Jul 2015 08:53:51 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 89C25206D2 for ; Tue, 28 Jul 2015 08:53:50 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C07D22061F for ; Tue, 28 Jul 2015 08:53:49 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id BEC176E880; Tue, 28 Jul 2015 01:53:48 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id 3D1A66E865 for ; Tue, 28 Jul 2015 01:53:38 -0700 (PDT) Received: from epcpsbgr2.samsung.com (u142.gpu120.samsung.co.kr [203.254.230.142]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NS6022KEWP5ZY80@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 28 Jul 2015 17:53:29 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.112]) by epcpsbgr2.samsung.com (EPCPMTA) with SMTP id 93.30.28411.90347B55; Tue, 28 Jul 2015 17:53:29 +0900 (KST) X-AuditID: cbfee68e-f79c56d000006efb-19-55b74309641e Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 55.0F.23663.90347B55; Tue, 28 Jul 2015 17:53:29 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NS60042VWP4KW00@mmp2.samsung.com>; Tue, 28 Jul 2015 17:53:29 +0900 (KST) From: Joonyoung Shim To: dri-devel@lists.freedesktop.org Subject: [PATCH 03/14] drm/exynos: remove mutex locking in pagefault handler Date: Tue, 28 Jul 2015 17:53:18 +0900 Message-id: <1438073609-32664-3-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1438073609-32664-1-git-send-email-jy0922.shim@samsung.com> References: <1438073609-32664-1-git-send-email-jy0922.shim@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrHLMWRmVeSWpSXmKPExsWyRsSkQJfTeXuoQesxcYsrX9+zWUy6P4HF 4sW9iywWMya/ZHNg8bjffZzJo2/LKsYApigum5TUnMyy1CJ9uwSujDdffrIX9HFWnLtf0MB4 lr2LkZNDQsBEovPnJFYIW0ziwr31bF2MXBxCAisYJR4eOcAMU7R++xUmiMQsRol7z5tYIZwf jBJnXiwHq2IT0JO4s+04E4gtIqAs8XfiKkYQm1nAU2LFqnlgcWEBH4neSTPA4iwCqhJrbj4H i/MKuEvsvnEa6iQ5iZPHJoOdxCngIXH00D4wWwioZvWPFkaQxRIC79kkdnf3MkEMEpD4NvkQ SxcjB1BCVmITzNWSEgdX3GCZwCi8gJFhFaNoakFyQXFSepGRXnFibnFpXrpecn7uJkZgsJ7+ 96xvB+PNA9aHGAU4GJV4eCes2xYqxJpYVlyZe4jRFGjDRGYp0eR8YEzklcQbGpsZWZiamBob mVuaKYnzJkj9DBYSSE8sSc1OTS1ILYovKs1JLT7EyMTBKdXAGPRXsMJ5teBbL+lZD2eumbax jO1FCkffpoV/f/A6cT84JzRNbuuBZ0ktd37o5nud4XWu0T747fWBST/8H01bsK7gSaZ2/v3H 8vt1XWMs9zCer92U/XdWziVXQR8DtXaFvE83+9K0wsSO/DZceVn0/rHSxMzHb/hv3z3turp7 MWOq1cy3Lbu1jZRYijMSDbWYi4oTAYcqbJFRAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupmkeLIzCtJLcpLzFFi42I5/e+xoC6n8/ZQg7WHhS2ufH3PZjHp/gQW ixf3LrJYzJj8ks2BxeN+93Emj74tqxgDmKIaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0M DHUNLS3MlRTyEnNTbZVcfAJ03TJzgFYpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLr MTJAAwlrGDPefPnJXtDHWXHufkED41n2LkZODgkBE4n1268wQdhiEhfurWfrYuTiEBKYxShx 73kTK4Tzg1HizIvlzCBVbAJ6Ene2HQfrEBFQlvg7cRUjiM0s4CmxYtU8sLiwgI9E76QZYHEW AVWJNTefg8V5Bdwldt84DbVZTuLkscmsIDangIfE0UP7wGwhoJrVP1oYJzDyLmBkWMUokVqQ XFCclJ5rmJdarlecmFtcmpeul5yfu4kRHBHPpHYwHtzlfohRgINRiYd3wrptoUKsiWXFlbmH GCU4mJVEeP8Ybg8V4k1JrKxKLcqPLyrNSS0+xGgKdNhEZinR5HxgtOaVxBsam5gZWRqZG1oY GZsrifPKbtgcKiSQnliSmp2aWpBaBNPHxMEp1cAY+DNdy/Fvmf5x+QSfb+2c1/kjn33pS7rZ /qvx146GnJt2dmlh8zsFTNSnvittsNNf+vzfcQUfy0PPzjjvdUyapqsh2H4xWG9NhkCoy4MC D2dTdc3Viv1Cnz4tZc26rcA0/Vi9JredMNNDH7abjq7TfL8EXlmSkZqgtM3r6UrHxfdy12Ut uaPEUpyRaKjFXFScCABf9dcJngIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.6 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There is no reason to use mutex locking in pagefault handler. Signed-off-by: Joonyoung Shim --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index 752cb7c..4741226 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -560,7 +560,6 @@ unlock: int exynos_drm_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf) { struct drm_gem_object *obj = vma->vm_private_data; - struct drm_device *dev = obj->dev; unsigned long f_vaddr; pgoff_t page_offset; int ret; @@ -569,14 +568,10 @@ int exynos_drm_gem_fault(struct vm_area_struct *vma, struct vm_fault *vmf) vma->vm_start) >> PAGE_SHIFT; f_vaddr = (unsigned long)vmf->virtual_address; - mutex_lock(&dev->struct_mutex); - ret = exynos_drm_gem_map_buf(obj, vma, f_vaddr, page_offset); if (ret < 0) DRM_ERROR("failed to map a buffer with user.\n"); - mutex_unlock(&dev->struct_mutex); - switch (ret) { case 0: case -ERESTARTSYS: