diff mbox

drm/tilcdc: panel: Add tilcdc- prefix to driver name

Message ID 1438164750-893-1-git-send-email-thierry.reding@gmail.com
State New, archived
Headers show

Commit Message

Thierry Reding July 29, 2015, 10:12 a.m. UTC
From: Thierry Reding <treding@nvidia.com>

The current driver name, "panel", is very generic. This causes problems
when the driver is enabled on non-TI device tree platforms if the panel
node is called "panel". This causes the driver name match fall-back in
platform_match() to succeed, even if some other driver would precisely
match using the OF device ID table, for example.

Currently there don't seem to be any in-tree users that rely on the
driver name match, so adding the prefix should be safe.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Tomi Valkeinen Aug. 20, 2015, 9:20 a.m. UTC | #1
On 29/07/15 13:12, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> The current driver name, "panel", is very generic. This causes problems
> when the driver is enabled on non-TI device tree platforms if the panel
> node is called "panel". This causes the driver name match fall-back in
> platform_match() to succeed, even if some other driver would precisely
> match using the OF device ID table, for example.
> 
> Currently there don't seem to be any in-tree users that rely on the
> driver name match, so adding the prefix should be safe.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  drivers/gpu/drm/tilcdc/tilcdc_panel.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 7a0315855e90..375505caf9c7 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -460,7 +460,7 @@ struct platform_driver panel_driver = {
>  	.remove = panel_remove,
>  	.driver = {
>  		.owner = THIS_MODULE,
> -		.name = "panel",
> +		.name = "tilcdc-panel",
>  		.of_match_table = panel_of_match,
>  	},
>  };

I didn't know we do matching based on the node name also...

This looks fine, I believe the tilcdc is only used with DT based
systems. I'll pick this up.

 Tomi
diff mbox

Patch

diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
index 7a0315855e90..375505caf9c7 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
@@ -460,7 +460,7 @@  struct platform_driver panel_driver = {
 	.remove = panel_remove,
 	.driver = {
 		.owner = THIS_MODULE,
-		.name = "panel",
+		.name = "tilcdc-panel",
 		.of_match_table = panel_of_match,
 	},
 };