| Message ID | 1441087272-25353-1-git-send-email-ykk@rock-chips.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 01.09.2015 15:01, Yakir Yang wrote: > After exynos_dp have been splited the common IP code into analogix_dp driver, s/splited/split/ > the analogix_dp driver have deprecated some samsung platform properties which s/samsung/Samsung/ > could be dynamic parsed from EDID/MODE/DPCD message, so this is an update for s/dynamic/dynamically/ > exynos DTS file for dp-controller. /exynos/Exynos/ > > Beside analogix_dp have provide the backward compatibility, so there are no > bisectability break that make this change in a separate patch. It took me some time to figure out the meaning of this sentence... Did you want to say that backward compatibility is fully preserved? You are removing samsung,dynamic-range and samsung,ycbcr-coeff. I would assume that now: 1. on all these board these values would be parsed from EDID/MODE/DPCD message? 2. everything would work as previously? Am I understanding it correctly? The patch itself looks good. Best regards, Krzysztof > > Signed-off-by: Yakir Yang <ykk@rock-chips.com> > --- > Changes in v4: > - Take Krzysztof suggest, separate all DTS changes to a separate patch. > > Changes in v3: None > Changes in v2: None > > arch/arm/boot/dts/exynos5250-arndale.dts | 2 -- > arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 -- > arch/arm/boot/dts/exynos5250-snow.dts | 4 +--- > arch/arm/boot/dts/exynos5250-spring.dts | 4 +--- > arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +--- > arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 -- > arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 +--- > 7 files changed, 4 insertions(+), 18 deletions(-) > > diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts > index db3f65f..4636862 100644 > --- a/arch/arm/boot/dts/exynos5250-arndale.dts > +++ b/arch/arm/boot/dts/exynos5250-arndale.dts > @@ -124,8 +124,6 @@ > &dp { > status = "okay"; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts > index c625e71..cd424d6 100644 > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts > @@ -80,8 +80,6 @@ > > &dp { > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index 0720caa..242b621 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -244,12 +244,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx0 7 GPIO_ACTIVE_HIGH>; > + hpd-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>; > > ports { > port@0 { > diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts > index c1edd6d..91881d7 100644 > --- a/arch/arm/boot/dts/exynos5250-spring.dts > +++ b/arch/arm/boot/dts/exynos5250-spring.dts > @@ -74,12 +74,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <1>; > - samsung,hpd-gpio = <&gpc3 0 GPIO_ACTIVE_HIGH>; > + hpd-gpios = <&gpc3 0 GPIO_ACTIVE_HIGH>; > }; > > &ehci { > diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts > index 8f4d76c..7433683 100644 > --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts > +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts > @@ -148,12 +148,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x06>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx2 6 0>; > + hpd-gpio = <&gpx2 6 0>; > > ports { > port@0 { > diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts > index 98871f9..b3df3c1 100644 > --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts > +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts > @@ -92,8 +92,6 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <4>; > diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts > index 7d5b386..b89bff5 100644 > --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts > +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts > @@ -142,12 +142,10 @@ > pinctrl-names = "default"; > pinctrl-0 = <&dp_hpd_gpio>; > samsung,color-space = <0>; > - samsung,dynamic-range = <0>; > - samsung,ycbcr-coeff = <0>; > samsung,color-depth = <1>; > samsung,link-rate = <0x0a>; > samsung,lane-count = <2>; > - samsung,hpd-gpio = <&gpx2 6 0>; > + hpd-gpios = <&gpx2 6 0>; > panel = <&panel>; > }; > >
Hi Krzysztof, ? 09/03/2015 08:01 AM, Krzysztof Kozlowski ??: > On 01.09.2015 15:01, Yakir Yang wrote: >> After exynos_dp have been splited the common IP code into analogix_dp driver, > s/splited/split/ Done :) >> the analogix_dp driver have deprecated some samsung platform properties which > s/samsung/Samsung/ Done, >> could be dynamic parsed from EDID/MODE/DPCD message, so this is an update for > s/dynamic/dynamically/ > thanks, >> exynos DTS file for dp-controller. > /exynos/Exynos/ Okay >> Beside analogix_dp have provide the backward compatibility, so there are no >> bisectability break that make this change in a separate patch. > It took me some time to figure out the meaning of this sentence... Did > you want to say that backward compatibility is fully preserved? Aha, Yeah, I means I already have provided the backward compatibility in previous patches, so no kernel broken when I make this DTS change in separate patch. > You are removing samsung,dynamic-range and samsung,ycbcr-coeff. I would > assume that now: > 1. on all these board these values would be parsed from EDID/MODE/DPCD > message? > 2. everything would work as previously? > Am I understanding it correctly? Yeah, you are right. I think dynamic-range and ycbcr-coeff can parse from the vic value of mode, and this works rightly on my side whether the TV and simple panel (if we ignored the mistake I make in v4 :( ). But I do have a concern about the ycbcr-coeff. I just copy the judge rule from dw_hdmi code, and don't understand very well about it, wish some guys could share some ideas. if ((vic == 2) || (vic == 3) || (vic == 6) || (vic == 7) || (vic == 17) || (vic == 18) || (vic == 21) || (vic == 22)) hdmi->mode_data.colorimetry = eITU601; else hdmi->mode_data.colorimetry = eITU709; Beside, most panel timing would not match the cea mode, that's to say panel timing would get vic to zero in most time. So after the previous rule, ycbcr would set to ITU709 which is "1" in eDP controller. But I see Exynos always set 0 to this bit, so this is the place I am worry about. - Yakir > The patch itself looks good. Thanks. > Best regards, > Krzysztof > > >> Signed-off-by: Yakir Yang <ykk@rock-chips.com> >> --- >> Changes in v4: >> - Take Krzysztof suggest, separate all DTS changes to a separate patch. >> >> Changes in v3: None >> Changes in v2: None >> >> arch/arm/boot/dts/exynos5250-arndale.dts | 2 -- >> arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 -- >> arch/arm/boot/dts/exynos5250-snow.dts | 4 +--- >> arch/arm/boot/dts/exynos5250-spring.dts | 4 +--- >> arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +--- >> arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 -- >> arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 +--- >> 7 files changed, 4 insertions(+), 18 deletions(-) >> >> diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts >> index db3f65f..4636862 100644 >> --- a/arch/arm/boot/dts/exynos5250-arndale.dts >> +++ b/arch/arm/boot/dts/exynos5250-arndale.dts >> @@ -124,8 +124,6 @@ >> &dp { >> status = "okay"; >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x0a>; >> samsung,lane-count = <4>; >> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> index c625e71..cd424d6 100644 >> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts >> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts >> @@ -80,8 +80,6 @@ >> >> &dp { >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x0a>; >> samsung,lane-count = <4>; >> diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts >> index 0720caa..242b621 100644 >> --- a/arch/arm/boot/dts/exynos5250-snow.dts >> +++ b/arch/arm/boot/dts/exynos5250-snow.dts >> @@ -244,12 +244,10 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&dp_hpd>; >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x0a>; >> samsung,lane-count = <2>; >> - samsung,hpd-gpio = <&gpx0 7 GPIO_ACTIVE_HIGH>; >> + hpd-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>; >> >> ports { >> port@0 { >> diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts >> index c1edd6d..91881d7 100644 >> --- a/arch/arm/boot/dts/exynos5250-spring.dts >> +++ b/arch/arm/boot/dts/exynos5250-spring.dts >> @@ -74,12 +74,10 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&dp_hpd_gpio>; >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x0a>; >> samsung,lane-count = <1>; >> - samsung,hpd-gpio = <&gpc3 0 GPIO_ACTIVE_HIGH>; >> + hpd-gpios = <&gpc3 0 GPIO_ACTIVE_HIGH>; >> }; >> >> &ehci { >> diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> index 8f4d76c..7433683 100644 >> --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts >> +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts >> @@ -148,12 +148,10 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&dp_hpd_gpio>; >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x06>; >> samsung,lane-count = <2>; >> - samsung,hpd-gpio = <&gpx2 6 0>; >> + hpd-gpio = <&gpx2 6 0>; >> >> ports { >> port@0 { >> diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> index 98871f9..b3df3c1 100644 >> --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts >> +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts >> @@ -92,8 +92,6 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&dp_hpd>; >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x0a>; >> samsung,lane-count = <4>; >> diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> index 7d5b386..b89bff5 100644 >> --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts >> +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts >> @@ -142,12 +142,10 @@ >> pinctrl-names = "default"; >> pinctrl-0 = <&dp_hpd_gpio>; >> samsung,color-space = <0>; >> - samsung,dynamic-range = <0>; >> - samsung,ycbcr-coeff = <0>; >> samsung,color-depth = <1>; >> samsung,link-rate = <0x0a>; >> samsung,lane-count = <2>; >> - samsung,hpd-gpio = <&gpx2 6 0>; >> + hpd-gpios = <&gpx2 6 0>; >> panel = <&panel>; >> }; >> >> > > >
diff --git a/arch/arm/boot/dts/exynos5250-arndale.dts b/arch/arm/boot/dts/exynos5250-arndale.dts index db3f65f..4636862 100644 --- a/arch/arm/boot/dts/exynos5250-arndale.dts +++ b/arch/arm/boot/dts/exynos5250-arndale.dts @@ -124,8 +124,6 @@ &dp { status = "okay"; samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x0a>; samsung,lane-count = <4>; diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts index c625e71..cd424d6 100644 --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts @@ -80,8 +80,6 @@ &dp { samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x0a>; samsung,lane-count = <4>; diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts index 0720caa..242b621 100644 --- a/arch/arm/boot/dts/exynos5250-snow.dts +++ b/arch/arm/boot/dts/exynos5250-snow.dts @@ -244,12 +244,10 @@ pinctrl-names = "default"; pinctrl-0 = <&dp_hpd>; samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x0a>; samsung,lane-count = <2>; - samsung,hpd-gpio = <&gpx0 7 GPIO_ACTIVE_HIGH>; + hpd-gpios = <&gpx0 7 GPIO_ACTIVE_HIGH>; ports { port@0 { diff --git a/arch/arm/boot/dts/exynos5250-spring.dts b/arch/arm/boot/dts/exynos5250-spring.dts index c1edd6d..91881d7 100644 --- a/arch/arm/boot/dts/exynos5250-spring.dts +++ b/arch/arm/boot/dts/exynos5250-spring.dts @@ -74,12 +74,10 @@ pinctrl-names = "default"; pinctrl-0 = <&dp_hpd_gpio>; samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x0a>; samsung,lane-count = <1>; - samsung,hpd-gpio = <&gpc3 0 GPIO_ACTIVE_HIGH>; + hpd-gpios = <&gpc3 0 GPIO_ACTIVE_HIGH>; }; &ehci { diff --git a/arch/arm/boot/dts/exynos5420-peach-pit.dts b/arch/arm/boot/dts/exynos5420-peach-pit.dts index 8f4d76c..7433683 100644 --- a/arch/arm/boot/dts/exynos5420-peach-pit.dts +++ b/arch/arm/boot/dts/exynos5420-peach-pit.dts @@ -148,12 +148,10 @@ pinctrl-names = "default"; pinctrl-0 = <&dp_hpd_gpio>; samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x06>; samsung,lane-count = <2>; - samsung,hpd-gpio = <&gpx2 6 0>; + hpd-gpio = <&gpx2 6 0>; ports { port@0 { diff --git a/arch/arm/boot/dts/exynos5420-smdk5420.dts b/arch/arm/boot/dts/exynos5420-smdk5420.dts index 98871f9..b3df3c1 100644 --- a/arch/arm/boot/dts/exynos5420-smdk5420.dts +++ b/arch/arm/boot/dts/exynos5420-smdk5420.dts @@ -92,8 +92,6 @@ pinctrl-names = "default"; pinctrl-0 = <&dp_hpd>; samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x0a>; samsung,lane-count = <4>; diff --git a/arch/arm/boot/dts/exynos5800-peach-pi.dts b/arch/arm/boot/dts/exynos5800-peach-pi.dts index 7d5b386..b89bff5 100644 --- a/arch/arm/boot/dts/exynos5800-peach-pi.dts +++ b/arch/arm/boot/dts/exynos5800-peach-pi.dts @@ -142,12 +142,10 @@ pinctrl-names = "default"; pinctrl-0 = <&dp_hpd_gpio>; samsung,color-space = <0>; - samsung,dynamic-range = <0>; - samsung,ycbcr-coeff = <0>; samsung,color-depth = <1>; samsung,link-rate = <0x0a>; samsung,lane-count = <2>; - samsung,hpd-gpio = <&gpx2 6 0>; + hpd-gpios = <&gpx2 6 0>; panel = <&panel>; };
After exynos_dp have been splited the common IP code into analogix_dp driver, the analogix_dp driver have deprecated some samsung platform properties which could be dynamic parsed from EDID/MODE/DPCD message, so this is an update for exynos DTS file for dp-controller. Beside analogix_dp have provide the backward compatibility, so there are no bisectability break that make this change in a separate patch. Signed-off-by: Yakir Yang <ykk@rock-chips.com> --- Changes in v4: - Take Krzysztof suggest, separate all DTS changes to a separate patch. Changes in v3: None Changes in v2: None arch/arm/boot/dts/exynos5250-arndale.dts | 2 -- arch/arm/boot/dts/exynos5250-smdk5250.dts | 2 -- arch/arm/boot/dts/exynos5250-snow.dts | 4 +--- arch/arm/boot/dts/exynos5250-spring.dts | 4 +--- arch/arm/boot/dts/exynos5420-peach-pit.dts | 4 +--- arch/arm/boot/dts/exynos5420-smdk5420.dts | 2 -- arch/arm/boot/dts/exynos5800-peach-pi.dts | 4 +--- 7 files changed, 4 insertions(+), 18 deletions(-)