From patchwork Tue Sep 1 07:22:55 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 7103611 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 4F6EC9F32B for ; Tue, 1 Sep 2015 07:23:07 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B70F20414 for ; Tue, 1 Sep 2015 07:23:06 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id AA4E720532 for ; Tue, 1 Sep 2015 07:23:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 857236E325; Tue, 1 Sep 2015 00:22:55 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id F15FA6E237 for ; Tue, 1 Sep 2015 00:22:53 -0700 (PDT) Received: from epcpsbgr5.samsung.com (u145.gpu120.samsung.co.kr [203.254.230.145]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NTZ01J0VLU3IW90@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Tue, 01 Sep 2015 16:22:51 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.115]) by epcpsbgr5.samsung.com (EPCPMTA) with SMTP id DC.CB.17770.B4255E55; Tue, 1 Sep 2015 16:22:51 +0900 (KST) X-AuditID: cbfee691-f79ca6d00000456a-dd-55e5524bce30 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 30.AF.18629.B4255E55; Tue, 1 Sep 2015 16:22:51 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NTZ00AOGLU2EMF0@mmp2.samsung.com>; Tue, 01 Sep 2015 16:22:50 +0900 (KST) From: Joonyoung Shim To: dri-devel@lists.freedesktop.org Subject: [PATCH 9/9] drm/exynos: remove buf_cnt from struct exynos_drm_fb Date: Tue, 01 Sep 2015 16:22:55 +0900 Message-id: <1441092175-18187-9-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1441092175-18187-1-git-send-email-jy0922.shim@samsung.com> References: <1441092175-18187-1-git-send-email-jy0922.shim@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFtrPLMWRmVeSWpSXmKPExsWyRsSkWNc76Gmowd4nUhZXvr5ns5h0fwKL xYt7F1ksZkx+yebA4nG/+ziTR9+WVYwBTFFcNimpOZllqUX6dglcGdc2fWEvuM1b0bewk6mB cSl3FyMnh4SAicTty8dYIWwxiQv31rN1MXJxCAmsYJQ4/WIbG0xR9/39rBCJWYwSU86thHJ+ MEr8u/GdHaSKTUBP4s6240wgtoiAssTfiasYQWxmAU+JFavmgcWFgewHVx6CTWURUJXYeeow C4jNK+Au8ev1PUaIbXISJ49NBjuJU8BD4t6mLWC9QkA1J0+8ZgFZLCHwnk1iypSdzBCDBCS+ TT4ElOAASshKbDrADDFHUuLgihssExiFFzAyrGIUTS1ILihOSi8y1StOzC0uzUvXS87P3cQI DNfT/55N3MF4/4D1IUYBDkYlHt6Oj09ChVgTy4orcw8xmgJtmMgsJZqcD4yKvJJ4Q2MzIwtT E1NjI3NLMyVxXh3pn8FCAumJJanZqakFqUXxRaU5qcWHGJk4OKUaGLf3mIY+ifSZ/fLjF4GJ ofOPrzMvStnwwmXC+9zr3ZKmHzrn3jt8cf4Sb8M7VTWlJlYik84t2KJ06mLp8rojCQyulm/Z ig9O2Htpwl0L0YvrXG5pRjpa//mb8ra4UWtq2f/6ZtXtEsYcS1q1o/Zdb1nlvFym1PbkzZzQ 68sW7dJR/umqso9nYrUSS3FGoqEWc1FxIgAzUmKNUgIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuphkeLIzCtJLcpLzFFi42I5/e+xoK530NNQg683xSyufH3PZjHp/gQW ixf3LrJYzJj8ks2BxeN+93Emj74tqxgDmKIaGG0yUhNTUosUUvOS81My89JtlbyD453jTc0M DHUNLS3MlRTyEnNTbZVcfAJ03TJzgFYpKZQl5pQChQISi4uV9O0wTQgNcdO1gGmM0PUNCYLr MTJAAwlrGDOubfrCXnCbt6JvYSdTA+NS7i5GTg4JAROJ7vv7WSFsMYkL99azdTFycQgJzGKU mHJuJSuE84NR4t+N7+wgVWwCehJ3th1nArFFBJQl/k5cxQhiMwt4SqxYNQ8sLgxkP7jykA3E ZhFQldh56jALiM0r4C7x6/U9RohtchInj00G28wp4CFxb9MWsF4hoJqTJ16zTGDkXcDIsIpR IrUguaA4KT3XKC+1XK84Mbe4NC9dLzk/dxMjOCaeSe9gPLzL/RCjAAejEg9vx8cnoUKsiWXF lbmHGCU4mJVEeI95PA0V4k1JrKxKLcqPLyrNSS0+xGgKdNhEZinR5HxgvOaVxBsam5gZWRqZ G1oYGZsrifPmsAPNEUhPLEnNTk0tSC2C6WPi4JRqYNS27woXudboK1x9MW9FwK5fXl8nPgr/ mHgkVFMpkG9FduwDAU7ZHVOEdN/YfggqVpgg2susm3G7xMfEWWy3T+7eD16bmZV0byjJXPr5 fiqf4DOVgoRNW9+7V7D/tojvu+p3oi44z23WNdeuPc+VtcVSp0pc3+FWMefwZRW+DW6bPwlJ zT+brsRSnJFoqMVcVJwIAE7QGCWfAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Looking other drm drivers, there is no the restriction that framebuffer has only one buffer in .create_handle() callback. They use just first buffer. If this limitation is removed, there is no reason keeping buffer count for framebuffer, so we can remove buf_cnt from struct exynos_drm_fb. Signed-off-by: Joonyoung Shim Reviewed-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index d2e746e..6d1b70e 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -32,12 +32,10 @@ * exynos specific framebuffer structure. * * @fb: drm framebuffer obejct. - * @buf_cnt: a buffer count to drm framebuffer. * @exynos_gem_obj: array of exynos specific gem object containing a gem object. */ struct exynos_drm_fb { struct drm_framebuffer fb; - unsigned int buf_cnt; struct exynos_drm_gem_obj *exynos_gem_obj[MAX_FB_BUFFER]; }; @@ -97,10 +95,6 @@ static int exynos_drm_fb_create_handle(struct drm_framebuffer *fb, { struct exynos_drm_fb *exynos_fb = to_exynos_fb(fb); - /* This fb should have only one gem object. */ - if (WARN_ON(exynos_fb->buf_cnt != 1)) - return -EINVAL; - return drm_gem_handle_create(file_priv, &exynos_fb->exynos_gem_obj[0]->base, handle); } @@ -135,9 +129,6 @@ exynos_drm_framebuffer_init(struct drm_device *dev, if (!exynos_fb) return ERR_PTR(-ENOMEM); - exynos_fb->buf_cnt = count; - DRM_DEBUG_KMS("buf_cnt = %d\n", exynos_fb->buf_cnt); - for (i = 0; i < count; i++) { ret = check_fb_gem_memory_type(dev, gem_obj[i]); if (ret < 0)