From patchwork Wed Sep 16 05:29:32 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 7190881 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0BA51BEEC1 for ; Wed, 16 Sep 2015 05:29:55 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4181F205F2 for ; Wed, 16 Sep 2015 05:29:54 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 673782081C for ; Wed, 16 Sep 2015 05:29:53 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A27056E538; Tue, 15 Sep 2015 22:29:52 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout4.samsung.com (mailout4.samsung.com [203.254.224.34]) by gabe.freedesktop.org (Postfix) with ESMTPS id C85176E538 for ; Tue, 15 Sep 2015 22:29:51 -0700 (PDT) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout4.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NUR031AM8LBQPC0@mailout4.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 16 Sep 2015 14:29:35 +0900 (KST) Received: from epcpsbgm2new.samsung.com ( [172.20.52.115]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id AC.0A.29324.E3EF8F55; Wed, 16 Sep 2015 14:29:35 +0900 (KST) X-AuditID: cbfee68d-f79106d00000728c-ed-55f8fe3e236d Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm2new.samsung.com (EPCPMTA) with SMTP id 7F.C4.18629.E3EF8F55; Wed, 16 Sep 2015 14:29:34 +0900 (KST) Received: from localhost.localdomain ([10.252.81.123]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NUR009QX8LAZM41@mmp2.samsung.com>; Wed, 16 Sep 2015 14:29:34 +0900 (KST) From: Joonyoung Shim To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/4] drm/exynos: remove unnecessary NULL assignment Date: Wed, 16 Sep 2015 14:29:32 +0900 Message-id: <1442381375-540-1-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.9.1 X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFlrMLMWRmVeSWpSXmKPExsWyRsSkWNf+349Qg2slFle+vmezmHR/AovF i3sXWSxmTH7J5sDicb/7OJNH35ZVjAFMUVw2Kak5mWWpRfp2CVwZ/2YfZy84zl7x6MoztgbG LWxdjBwcEgImEv0fa7oYOYFMMYkL99YDhbk4hARWMEqs6bzADpEwkWj4uZoFIjGLUaKjdRob SEJI4AejxInVyiA2m4CexJ1tx5lAbBEBZYm/E1cxgtjMAp4SK1bNA4sLCzhL7Pj6lxXEZhFQ lZjwrwsszivgKrH36VuoZXISJ49NZoWwr7NJfNqiCVEvIPFt8iEWiKNlJTYdYIYokZQ4uOIG ywRGwQWMDKsYRVMLkguKk9KLDPWKE3OLS/PS9ZLzczcxAsPu9L9nvTsYbx+wPsQowMGoxMP7 4tmPUCHWxLLiytxDjKZAGyYyS4km5wODO68k3tDYzMjC1MTU2Mjc0kxJnFdR6mewkEB6Yklq dmpqQWpRfFFpTmrxIUYmDk6pBsZd2VZs0q+DEhjFp7xMvrp5h8qN8JuOh/xZleJOqRq96zu2 +aKWyB67mNr3jvorG6bvauxnXf+iLafuRj//jUU2zflJvztZmO95Tz1weNJh8w9q4by5+Ywy Km0bL7j0WTQynF4spnpx1wLmgici8nvUTfk803ouLHw+q23jMad+ywL1O5kW/5RYijMSDbWY i4oTATp7HiE2AgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFvrMLMWRmVeSWpSXmKPExsVy+t9jQV27fz9CDT5esbS48vU9m8Wk+xNY LF7cu8hiMWPySzYHFo/73ceZPPq2rGIMYIpqYLTJSE1MSS1SSM1Lzk/JzEu3VfIOjneONzUz MNQ1tLQwV1LIS8xNtVVy8QnQdcvMAVqlpFCWmFMKFApILC5W0rfDNCE0xE3XAqYxQtc3JAiu x8gADSSsYcz4N/s4e8Fx9opHV56xNTBuYeti5OSQEDCRaPi5mgXCFpO4cG89UJyLQ0hgFqNE R+s0sCIhgR+MEidWK4PYbAJ6Ene2HWcCsUUElCX+TlzFCGIzC3hKrFg1DywuLOAssePrX1YQ m0VAVWLCvy6wOK+Aq8Tep2/ZIZbJSZw8Npl1AiP3AkaGVYwSqQXJBcVJ6blGeanlesWJucWl eel6yfm5mxjBAf5Megfj4V3uhxgFOBiVeHgdXv4IFWJNLCuuzD3EKMHBrCTC27sfKMSbklhZ lVqUH19UmpNafIjRFOiAicxSosn5wOjLK4k3NDYxM7I0Mje0MDI2VxLnlV35LFRIID2xJDU7 NbUgtQimj4mDU6qBkeFFpafV4tovHadUe0y02Hz33MjKcq56dDlRM3hj8A0zR/2HbxJmbv/w 3uTalgOXdfguOq0VM1Ha5rApxnimoOUpvWOJleLFD+/MKn+8+O3iw9U9YXZFp1Qm7hU9qFOn /ezKGUN2X6YsbleusOVpk+WvMkjJMP9JfX/K4NVKM9OPL09c8kiMUGIpzkg01GIuKk4EAErw uTmGAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: sw0312.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP They will be freed right or was freed already, so NULL assignment is unnecessary. Signed-off-by: Joonyoung Shim Reviewed-by: Gustavo Padovan --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index f12fbc3..8dce40d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -117,8 +117,6 @@ static void exynos_drm_free_buf(struct exynos_drm_gem_obj *obj) } else dma_free_attrs(dev->dev, obj->size, obj->pages, (dma_addr_t)obj->dma_addr, &obj->dma_attrs); - - obj->dma_addr = (dma_addr_t)NULL; } static int exynos_drm_gem_handle_create(struct drm_gem_object *obj, @@ -167,7 +165,6 @@ out: drm_gem_object_release(obj); kfree(exynos_gem_obj); - exynos_gem_obj = NULL; } unsigned long exynos_drm_gem_get_size(struct drm_device *dev,