From patchwork Thu Oct 15 07:36:33 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7403591 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CB94ABFD59 for ; Thu, 15 Oct 2015 07:34:18 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id EBB732085C for ; Thu, 15 Oct 2015 07:34:17 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 2DF4220793 for ; Thu, 15 Oct 2015 07:34:16 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 513AD7A0EB; Thu, 15 Oct 2015 00:34:13 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f176.google.com (mail-wi0-f176.google.com [209.85.212.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id 49B817A0E8 for ; Thu, 15 Oct 2015 00:34:08 -0700 (PDT) Received: by wicll6 with SMTP id ll6so27563893wic.0 for ; Thu, 15 Oct 2015 00:34:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=XQ5Yc/wMQZO7KJQCIW2zaPzWx7sXHrHkEe+q5LJq5LE=; b=a644KcxFtwdy7wO+43BvqxGDGZY2Xf23nUizjueBvdNlFRi2ABs+qFzowsSNxks0oN RSGlXQzfodr5ybddqqgaCpz9AfVTNDjPUY3EIzPUGk8+wN66LU5PYD28Yv2eiP1GFtGX /ehOBeNQZt99tgjBEiKCzccF8Pe5S1kF0yiC0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=XQ5Yc/wMQZO7KJQCIW2zaPzWx7sXHrHkEe+q5LJq5LE=; b=YEO3sVMA4bCquzJTBx0X/Jq6o0OYugcdgD1LvvjDYXtMUPovTbDCjjxGv7u8wS3fR9 Xc0O3BWAiSmNSW8adXOgVrOtm86ZSs0d38apt4DX+GzjWm+Y/Zt/bZaWfAnKlc35MFXf h742Qvr/wc3qqQIMZE+3LWHatDGdNv3enjySgb6gxMvuNCp3GWp5p/NiNIRWHAruN430 OgMwK46gXb/LuqAqUsZZsKTADH81KckYugXKDlBIA4MTorNGXuNh78g3nf2m2y4fDlrK Pmo6FEJZ4X/ZeXes5vLuq1KOokAcoCsPgD45eE/DHyS/nTrmN9Lv0sIxuDUcY427Vrrd oCIA== X-Gm-Message-State: ALoCoQnjmDxFAG2uemQT3yirLy/Ru+AruX8Pv4ziCo89BqxPw862A2ppI1Hr5GJtEIE975RqtsCl X-Received: by 10.194.58.177 with SMTP id s17mr10189319wjq.102.1444894447070; Thu, 15 Oct 2015 00:34:07 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id z4sm10201014wjz.29.2015.10.15.00.34.05 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 15 Oct 2015 00:34:05 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 17/25] drm/nouveau: Drop dev->struct_mutex from fbdev init Date: Thu, 15 Oct 2015 09:36:33 +0200 Message-Id: <1444894601-5200-18-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1444894601-5200-1-git-send-email-daniel.vetter@ffwll.ch> References: <1444894601-5200-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Doesn't protect anything at all. With this patch nouveau is completely dev->struct_mutex free! Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 59f27e774acb..3bae706126bd 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -386,8 +386,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, } } - mutex_lock(&dev->struct_mutex); - info = drm_fb_helper_alloc_fbi(helper); if (IS_ERR(info)) { ret = PTR_ERR(info); @@ -426,8 +424,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ - mutex_unlock(&dev->struct_mutex); - if (chan) nouveau_fbcon_accel_init(dev); nouveau_fbcon_zfill(dev, fbcon); @@ -441,7 +437,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, return 0; out_unlock: - mutex_unlock(&dev->struct_mutex); if (chan) nouveau_bo_vma_del(nvbo, &fbcon->nouveau_fb.vma); nouveau_bo_unmap(nvbo);