From patchwork Fri Oct 16 16:23:13 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7419011 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C9237BEEA4 for ; Fri, 16 Oct 2015 16:23:30 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0462B20A6D for ; Fri, 16 Oct 2015 16:23:30 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 6D2D820A6B for ; Fri, 16 Oct 2015 16:23:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5808D6E16B; Fri, 16 Oct 2015 09:23:26 -0700 (PDT) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wi0-f178.google.com (mail-wi0-f178.google.com [209.85.212.178]) by gabe.freedesktop.org (Postfix) with ESMTPS id EC3126E16B for ; Fri, 16 Oct 2015 09:23:24 -0700 (PDT) Received: by wicll6 with SMTP id ll6so18870507wic.1 for ; Fri, 16 Oct 2015 09:23:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=ARuzEjeWh2PS2wcjvS8I1tX6OEM9lt6oMNy8X98y0pY=; b=eik8mYOTPjRmMAt47BQJvD3SoLAvjxtZ1wCwmbfgIXQPlYqJThnMoPa0qI9aTsY3YB bQqz3KoPMTU+GxkF3l/Fp0r2IFiJiDbeMJ2J1SlJP1JKL4h4D0BAo0/6gJVOwoyWgtDi zL8Dc7MKJp3Vz4vtB5yYy7hTvhj8lpMefrpck= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=ARuzEjeWh2PS2wcjvS8I1tX6OEM9lt6oMNy8X98y0pY=; b=XY2KYWNk/9FK5876tnB5BQf3mqycZa2Q3Rv8MTS1kqMGfLuKz7ssw9k4lehN0taeWw qvOoNz7yL2RhoOfTEl5qAnHgazVxlv2TiWYQs+VpS0iOsOFKs/FlQbiF6bdPZP8cCN7p AmL+qE/evzXr/kHZmnE78VLkzgDMlo3Wj2WMmzI++DRRdWEQqZbr9XOsc+0IMPVYtWOe knWJ6k1Cg3j0+JDesam39VVTgEgwHGPOKIY2WYo+JLkoXC8v+Ij6K87O6j08LDIzAdjH ZLAZBykHv0COnagL6sbQ8bHtRZVjUcqyFBV0xWyc9i2xlxyB/kaXuMlb4YFh8HMJ3b/D DYXw== X-Gm-Message-State: ALoCoQn64mx7H5JmnmrDeJobU04H9huDkBb0p2RhZYjvI6HNfQtfAyxpj/rccD+Ufo5t469TC77s X-Received: by 10.180.186.10 with SMTP id fg10mr5900447wic.30.1445012603211; Fri, 16 Oct 2015 09:23:23 -0700 (PDT) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id gl9sm3830667wjb.10.2015.10.16.09.23.21 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 16 Oct 2015 09:23:22 -0700 (PDT) From: Daniel Vetter To: Intel Graphics Development , DRI Development Subject: [PATCH 1/2] drm/fb-helper: Set plane rotation directly Date: Fri, 16 Oct 2015 18:23:13 +0200 Message-Id: <1445012594-25988-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 Cc: Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The point behind standardizing properties into core drm state structures is also that internal code looks prettiers. Take advantage of that and set rotation directly in the fbdev atomic code. Cc: Rob Clark Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_fb_helper.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/drm_fb_helper.c b/drivers/gpu/drm/drm_fb_helper.c index bd6d4ab27512..0ac0fcc9b0d2 100644 --- a/drivers/gpu/drm/drm_fb_helper.c +++ b/drivers/gpu/drm/drm_fb_helper.c @@ -360,11 +360,7 @@ retry: goto fail; } - ret = drm_atomic_plane_set_property(plane, plane_state, - dev->mode_config.rotation_property, - BIT(DRM_ROTATE_0)); - if (ret != 0) - goto fail; + plane_state->rotation = BIT(DRM_ROTATE_0); /* disable non-primary: */ if (plane->type == DRM_PLANE_TYPE_PRIMARY)