| Message ID | 1446214865-3972-8-git-send-email-maxime.ripard@free-electrons.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
On Fri, Oct 30, 2015 at 03:20:53PM +0100, Maxime Ripard wrote: > Add support for the Olimex LCD-OLinuXino-4.3TS panel to the DRM simple > panel driver. > > It is a 480x272 panel connected through a 24-bits RGB interface. > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > --- > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) I don't see a patch adding the DT binding documentation for this panel. Also, the olimex vendor prefix isn't defined. > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > index f97b73ec4713..3a9ecb64d1e6 100644 > --- a/drivers/gpu/drm/panel/panel-simple.c > +++ b/drivers/gpu/drm/panel/panel-simple.c > @@ -1096,6 +1096,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > }; > > +static const struct drm_display_mode olimex_lcd_olinuxino_43ts_mode = { > + .clock = 9000, > + .hdisplay = 480, > + .hsync_start = 480 + 5, > + .hsync_end = 480 + 5 + 30, > + .htotal = 480 + 5 + 30 + 10, > + .vdisplay = 272, > + .vsync_start = 272 + 8, > + .vsync_end = 272 + 8 + 5, > + .vtotal = 272 + 8 + 5 + 3, > + .vrefresh = 60, > +}; > + > +static const struct panel_desc olimex_lcd_olinuxino_43ts = { > + .modes = &olimex_lcd_olinuxino_43ts_mode, > + .num_modes = 1, > + .size = { > + .width = 105, > + .height = 67, > + }, > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > +}; > + These mode and panel descriptors are all sorted alphabetically (by vendor, by model), please keep it so. > static const struct of_device_id platform_of_match[] = { > { > .compatible = "ampire,am800480r3tmqwa1h", > @@ -1191,6 +1214,9 @@ static const struct of_device_id platform_of_match[] = { > .compatible = "shelly,sca07010-bfn-lnn", > .data = &shelly_sca07010_bfn_lnn, > }, { > + .compatible = "olimex,lcd-olinuxino-43-ts", > + .data = &olimex_lcd_olinuxino_43ts, > + }, { > /* sentinel */ > } Here as well. Thierry
Hi Thierry, On Fri, Oct 30, 2015 at 06:32:30PM +0100, Thierry Reding wrote: > On Fri, Oct 30, 2015 at 03:20:53PM +0100, Maxime Ripard wrote: > > Add support for the Olimex LCD-OLinuXino-4.3TS panel to the DRM simple > > panel driver. > > > > It is a 480x272 panel connected through a 24-bits RGB interface. > > > > Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> > > --- > > drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ > > 1 file changed, 26 insertions(+) > > I don't see a patch adding the DT binding documentation for this panel. > > Also, the olimex vendor prefix isn't defined. > > > diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c > > index f97b73ec4713..3a9ecb64d1e6 100644 > > --- a/drivers/gpu/drm/panel/panel-simple.c > > +++ b/drivers/gpu/drm/panel/panel-simple.c > > @@ -1096,6 +1096,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { > > .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > }; > > > > +static const struct drm_display_mode olimex_lcd_olinuxino_43ts_mode = { > > + .clock = 9000, > > + .hdisplay = 480, > > + .hsync_start = 480 + 5, > > + .hsync_end = 480 + 5 + 30, > > + .htotal = 480 + 5 + 30 + 10, > > + .vdisplay = 272, > > + .vsync_start = 272 + 8, > > + .vsync_end = 272 + 8 + 5, > > + .vtotal = 272 + 8 + 5 + 3, > > + .vrefresh = 60, > > +}; > > + > > +static const struct panel_desc olimex_lcd_olinuxino_43ts = { > > + .modes = &olimex_lcd_olinuxino_43ts_mode, > > + .num_modes = 1, > > + .size = { > > + .width = 105, > > + .height = 67, > > + }, > > + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, > > +}; > > + > > These mode and panel descriptors are all sorted alphabetically (by > vendor, by model), please keep it so. > > > static const struct of_device_id platform_of_match[] = { > > { > > .compatible = "ampire,am800480r3tmqwa1h", > > @@ -1191,6 +1214,9 @@ static const struct of_device_id platform_of_match[] = { > > .compatible = "shelly,sca07010-bfn-lnn", > > .data = &shelly_sca07010_bfn_lnn, > > }, { > > + .compatible = "olimex,lcd-olinuxino-43-ts", > > + .data = &olimex_lcd_olinuxino_43ts, > > + }, { > > /* sentinel */ > > } > > Here as well. Thanks for your feedback, consider it fixed. Maxime
diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c index f97b73ec4713..3a9ecb64d1e6 100644 --- a/drivers/gpu/drm/panel/panel-simple.c +++ b/drivers/gpu/drm/panel/panel-simple.c @@ -1096,6 +1096,29 @@ static const struct panel_desc shelly_sca07010_bfn_lnn = { .bus_format = MEDIA_BUS_FMT_RGB666_1X18, }; +static const struct drm_display_mode olimex_lcd_olinuxino_43ts_mode = { + .clock = 9000, + .hdisplay = 480, + .hsync_start = 480 + 5, + .hsync_end = 480 + 5 + 30, + .htotal = 480 + 5 + 30 + 10, + .vdisplay = 272, + .vsync_start = 272 + 8, + .vsync_end = 272 + 8 + 5, + .vtotal = 272 + 8 + 5 + 3, + .vrefresh = 60, +}; + +static const struct panel_desc olimex_lcd_olinuxino_43ts = { + .modes = &olimex_lcd_olinuxino_43ts_mode, + .num_modes = 1, + .size = { + .width = 105, + .height = 67, + }, + .bus_format = MEDIA_BUS_FMT_RGB666_1X18, +}; + static const struct of_device_id platform_of_match[] = { { .compatible = "ampire,am800480r3tmqwa1h", @@ -1191,6 +1214,9 @@ static const struct of_device_id platform_of_match[] = { .compatible = "shelly,sca07010-bfn-lnn", .data = &shelly_sca07010_bfn_lnn, }, { + .compatible = "olimex,lcd-olinuxino-43-ts", + .data = &olimex_lcd_olinuxino_43ts, + }, { /* sentinel */ } };
Add support for the Olimex LCD-OLinuXino-4.3TS panel to the DRM simple panel driver. It is a 480x272 panel connected through a 24-bits RGB interface. Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com> --- drivers/gpu/drm/panel/panel-simple.c | 26 ++++++++++++++++++++++++++ 1 file changed, 26 insertions(+)