[6/7] dt-bindings: exynos_hdmi: add bindings for Exynos5433 variant

Commit Message

Andrzej Hajda Nov. 2, 2015, 1:16 p.m. UTC

Exynos5433 variant of HDMI requires different set of clocks and sysreg
phandle to system registers.

Signed-off-by: Andrzej Hajda <[e-mail]>
---
 .../devicetree/bindings/video/exynos_hdmi.txt      | 27 +++++++++++++++++++---
 1 file changed, 24 insertions(+), 3 deletions(-)

Comments

Krzysztof Kozlowski Nov. 3, 2015, 7 a.m. UTC | #1

On 02.11.2015 22:16, Andrzej Hajda wrote:
> Exynos5433 variant of HDMI requires different set of clocks and sysreg
> phandle to system registers.
> 
> Signed-off-by: Andrzej Hajda <[e-mail]>
> ---
>  .../devicetree/bindings/video/exynos_hdmi.txt      | 27 +++++++++++++++++++---
>  1 file changed, 24 insertions(+), 3 deletions(-)

First of all, I think that my nor Kukjin's acks are not required.
I saw [0] but still I think this is binding related to Exynos DRM so it
falls under Exynos DRM maintainers


Nevertheless from my perspective everything looks good here:

Reviewed-by: Krzysztof Kozlowski <[e-mail]>


[0] http://lists.freedesktop.org/archives/dri-devel/2015-October/092213.html


Best regards,
Krzysztof

Patch

diff --git a/Documentation/devicetree/bindings/video/exynos_hdmi.txt b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
index d474f59..4c3c582 100644
--- a/Documentation/devicetree/bindings/video/exynos_hdmi.txt
+++ b/Documentation/devicetree/bindings/video/exynos_hdmi.txt
@@ -5,6 +5,7 @@  Required properties:
 	1) "samsung,exynos4210-hdmi"
 	2) "samsung,exynos4212-hdmi"
 	3) "samsung,exynos5420-hdmi"
+	4) "samsung,exynos5433-hdmi"
 - reg: physical base address of the hdmi and length of memory mapped
 	region.
 - interrupts: interrupt number to the cpu.
@@ -12,6 +13,11 @@  Required properties:
 	a) phandle of the gpio controller node.
 	b) pin number within the gpio controller.
 	c) optional flags and pull up/down.
+- ddc: phandle to the hdmi ddc node
+- phy: phandle to the hdmi phy node
+- samsung,syscon-phandle: phandle for system controller node for PMU.
+
+Required properties for Exynos 4210, 4212 and 5420:
 - clocks: list of clock IDs from SoC clock driver.
 	a) hdmi: Gate of HDMI IP bus clock.
 	b) sclk_hdmi: Gate of HDMI special clock.
@@ -25,9 +31,24 @@  Required properties:
 		sclk_pixel.
 - clock-names: aliases as per driver requirements for above clock IDs:
 	"hdmi", "sclk_hdmi", "sclk_pixel", "sclk_hdmiphy" and "mout_hdmi".
-- ddc: phandle to the hdmi ddc node
-- phy: phandle to the hdmi phy node
-- samsung,syscon-phandle: phandle for system controller node for PMU.
+
+Required properties for Exynos 5433:
+- clocks: list of clock specifiers according to common clock bindings.
+	a) hdmi_pclk: Gate of HDMI IP APB bus.
+	b) hdmi_i_pclk: Gate of HDMI-PHY IP APB bus.
+	d) i_tmds_clk: Gate of HDMI TMDS clock.
+	e) i_pixel_clk: Gate of HDMI pixel clock.
+	f) i_spdif_clk: Gate of HDMI SPDIF clock.
+	g) oscclk: Oscillator clock, used as parent of following *_user clocks
+		in case HDMI-PHY is not operational.
+	h) tmds_clko: TMDS clock generated by HDMI-PHY.
+	i) tmds_clko_user: MUX used to switch between oscclk and tmds_clko,
+		respectively if HDMI-PHY is off and operational.
+	j) pixel_clko: Pixel clock generated by HDMI-PHY.
+	k) pixel_clko_user: MUX used to switch between oscclk and pixel_clko,
+		respectively if HDMI-PHY is off and operational.
+- clock-names: aliases for above clock specfiers.
+- samsung,sysreg: handle to syscon used to control the system registers.
 
 Example: