From patchwork Thu Nov 19 16:46:41 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7658981 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5C59FBF90C for ; Thu, 19 Nov 2015 16:47:25 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2B60E20656 for ; Thu, 19 Nov 2015 16:47:24 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DCB2A20693 for ; Thu, 19 Nov 2015 16:47:21 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 6EF2672054; Thu, 19 Nov 2015 08:47:13 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id CEA6F720D2 for ; Thu, 19 Nov 2015 08:47:11 -0800 (PST) Received: by wmww144 with SMTP id w144so246353180wmw.1 for ; Thu, 19 Nov 2015 08:47:10 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Xheq5Ld6beGvfYnV0C/aSHz8OrCoYZdKyj38xhf2Vw8=; b=bYXdmdhdGkiIgQIz/cANTtec5IZjmVNXmy6J7GKaSbho0MitoQPy9T5Ympy3pTLnve SAFcuEBIQCdbmVUJeI7QUqmfqo5RJBkvO/eaEnNE5uMpaKLOD0urW0IXjc+HJkp7RKMD 6x3ev7+rBktCMaQcMtWG98w4/YAUQ98Hq+FEA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xheq5Ld6beGvfYnV0C/aSHz8OrCoYZdKyj38xhf2Vw8=; b=P1BTyGeyxMQYI/FHYkJKGwmZgWO79uEjO/SDNFGfcGvG9G+NY8c48BNkIo993cqU+O ZWPBUGjsgza8WeO056IzMwuscOR3s6mijA4Hax1HzwFflgzeE6/lKzl8a8/lsCoK3WLH +kUfCdX7x7FHncMh0ZE0ScX/TbCpYJ6BBw911qkoZAWXixmY+TRSUBdA7sKosXmxnpPW 9Ou1FC8EQro1ClxGtSbTBlWbe9A3d+kvE9cz6g9sJmebsHObHmtM/1gf37MoudQO3EQq s0Grd+sFf2IT4UTpb2p5U5EAtMkQ0EN35NqV4zEGBevav2KXeuLThx9f/sbuVvbBR6ZG YfRg== X-Gm-Message-State: ALoCoQnIct01RyDaJXYVRZKc9bQa/mrvVK2umxoXqI8EHaN6c41OE//GP483+TEixJC55/HiXCqe X-Received: by 10.194.200.5 with SMTP id jo5mr9335923wjc.79.1447951630610; Thu, 19 Nov 2015 08:47:10 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id cv3sm8695001wjc.20.2015.11.19.08.47.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Nov 2015 08:47:09 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH RESEND 12/20] drm/nouveau: Drop dev->struct_mutex from fbdev init Date: Thu, 19 Nov 2015 17:46:41 +0100 Message-Id: <1447951610-12622-13-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1447951610-12622-1-git-send-email-daniel.vetter@ffwll.ch> References: <1447951610-12622-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Ben Skeggs , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Doesn't protect anything at all. With this patch nouveau is completely dev->struct_mutex free! Cc: Ben Skeggs Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 59f27e774acb..3bae706126bd 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -386,8 +386,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, } } - mutex_lock(&dev->struct_mutex); - info = drm_fb_helper_alloc_fbi(helper); if (IS_ERR(info)) { ret = PTR_ERR(info); @@ -426,8 +424,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ - mutex_unlock(&dev->struct_mutex); - if (chan) nouveau_fbcon_accel_init(dev); nouveau_fbcon_zfill(dev, fbcon); @@ -441,7 +437,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, return 0; out_unlock: - mutex_unlock(&dev->struct_mutex); if (chan) nouveau_bo_vma_del(nvbo, &fbcon->nouveau_fb.vma); nouveau_bo_unmap(nvbo);