From patchwork Thu Nov 19 16:46:43 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7659091 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E94E3C0646 for ; Thu, 19 Nov 2015 16:47:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1FFFD2065A for ; Thu, 19 Nov 2015 16:47:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 4D5052065E for ; Thu, 19 Nov 2015 16:47:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 659D27A171; Thu, 19 Nov 2015 08:47:20 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id A47B8720DE for ; Thu, 19 Nov 2015 08:47:13 -0800 (PST) Received: by wmec201 with SMTP id c201so34985110wme.0 for ; Thu, 19 Nov 2015 08:47:12 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=hoR34oOIW9mI9/irRGtusEwG7K9MO2wcGlCMmMPESks=; b=QcCv2BJ8pXvx2HdxynrZbvvawWCUQu5q2m+S5XJ9QY6mynktNUfzQdl9g9zkEe0+ZK 5heLs7jI0yVBvjp9UZuTGFAyIpYL6pAL0nlf6CvGyMlHtEpyu6wPuy53b0KY/JDWyqQb 7bjA4P0QoT8odEeIU6gtp/X7MmQipBB74Xnxk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=hoR34oOIW9mI9/irRGtusEwG7K9MO2wcGlCMmMPESks=; b=huMDK2vSmPcw11uzZJfJJtABzu+g7EBT4T28rJIrUcsvTc+un7wqO7y24G9X8tIh3p NwYaG3f6EpVFr+UxIMw8s81uGCka+oq1JbkKPcq0548NW7nbUq+0Eonve0ZP9VG9HrKn ++34w1rU9gV7t6kvvQR7ooGD7l8B9PXpTtC+TwyjJ5iPFrmZ1ykeXoAsqX4aiOZuTVut F1SX3ERxPaAz1czJpGHjQuE32yFIV47oPxNju+48R9/MFhpdYC7lOgKWl4E97slD5xj0 OvADDB4hSZdP/3DwVZDfhPAiCrGrYoFRO1bTKc6dizEG98ZBb5VwVNuqJKoojj6AjLlO W1AQ== X-Gm-Message-State: ALoCoQnwXKS39FgVrxCyQRCGvaebZTzJ/RNsCIwCDKJwXXLeSOLyLXiGQCV/CFT/fUbzBF0KQ1Xf X-Received: by 10.28.138.148 with SMTP id m142mr11211499wmd.79.1447951632459; Thu, 19 Nov 2015 08:47:12 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id cv3sm8695001wjc.20.2015.11.19.08.47.11 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Nov 2015 08:47:11 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH RESEND 14/20] drm/exynos: drop struct_mutex from exynos_gem_map_sgt_with_dma Date: Thu, 19 Nov 2015 17:46:43 +0100 Message-Id: <1447951610-12622-15-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1447951610-12622-1-git-send-email-daniel.vetter@ffwll.ch> References: <1447951610-12622-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The sg table isn't refcounted, there's no corresponding locking for unmapping and drm_map_sg is ok with being called concurrently. So drop the locking since it doesn't protect anything. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index 91d87e7c2a2f..a3286a1ec2b1 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -378,16 +378,12 @@ int exynos_gem_map_sgt_with_dma(struct drm_device *drm_dev, { int nents; - mutex_lock(&drm_dev->struct_mutex); - nents = dma_map_sg(drm_dev->dev, sgt->sgl, sgt->nents, dir); if (!nents) { DRM_ERROR("failed to map sgl with dma.\n"); - mutex_unlock(&drm_dev->struct_mutex); return nents; } - mutex_unlock(&drm_dev->struct_mutex); return 0; }