From patchwork Thu Nov 19 16:46:34 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7659081 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id B5F17C05CA for ; Thu, 19 Nov 2015 16:47:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id DB8D920675 for ; Thu, 19 Nov 2015 16:47:25 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 3369520697 for ; Thu, 19 Nov 2015 16:47:22 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 71BF17A16C; Thu, 19 Nov 2015 08:47:10 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f43.google.com (mail-wm0-f43.google.com [74.125.82.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 812A17A15B for ; Thu, 19 Nov 2015 08:47:04 -0800 (PST) Received: by wmvv187 with SMTP id v187so34937461wmv.1 for ; Thu, 19 Nov 2015 08:47:03 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=6XZQuZPo29yeaPLaNoxDA2xNZodu4jiAeMNMKdRmauQ=; b=FdI9aVBMk8Gxje/TYpXssnhsoRH9Tmr0Y58B0awbtINQwAUus1r/FaBwYrgxrFi1IO R6cNjQo0nSdxUXu9D+KFz3d6p/jhbR3pYaezrtx5lpb9geZe95J5iDp9WeOfXg4ZhDBh BL1qF19covDaddu+CZOK4gRYHnYfpsPqpcGwk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=6XZQuZPo29yeaPLaNoxDA2xNZodu4jiAeMNMKdRmauQ=; b=kYW5nXszX9TcB1Ss63bvf72GbPix8qmGhGOf9CcOvIr6yf79UjHg0+/uJPEvcMhYWt Y47QGTp7lCPPuS3N28a7/jqJ/qmPJD/5certnMjDhCIVyurP3TCaGyLjKLNPHEGdWwoT Ja1DnMiT6nEyADKCA/ON8Y0LbVSdNpNw1fmFATGc/nkNndIeHLFXupnRGBWjd2vFHf07 s0OX8OtRUE6SHZR7WALPxRHw/IUFjXUj/LavvX4l4VlWpXnmDYwC5WkmKUuY3DwPjZ2Y sTmvI/x2j5I81oqe3Os00OdbaSOBnCw75Oy6rnE82L/9ivlokIxdhgrBefhqWKwEr/oz yBTQ== X-Gm-Message-State: ALoCoQlV//RWlqj7chsj4iAfXmqnnuGhBYWGtNnuQ78c234nq4DrWpN3mYfQZ0qIZY7dIxfbyz3X X-Received: by 10.28.61.4 with SMTP id k4mr12268009wma.34.1447951623303; Thu, 19 Nov 2015 08:47:03 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id cv3sm8695001wjc.20.2015.11.19.08.47.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 19 Nov 2015 08:47:02 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH RESEND 05/20] drm/tegra: don't take dev->struct_mutex in mmap offset ioctl Date: Thu, 19 Nov 2015 17:46:34 +0100 Message-Id: <1447951610-12622-6-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1447951610-12622-1-git-send-email-daniel.vetter@ffwll.ch> References: <1447951610-12622-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.6 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Since David Herrmann's mmap vma manager rework we don't need to grab dev->struct_mutex any more to prevent races when looking up the mmap offset. Drop it and instead don't forget to use the unref_unlocked variant (since the drm core still cares). v2: Finally get rid of the copypasta from another commit in this commit message. And convert to _unlocked like we need to (Patrik). Cc: Patrik Jakobsson Cc: Thierry Reding Acked-by: Thierry Reding Reviewed-by: Patrik Jakobsson Signed-off-by: Daniel Vetter --- drivers/gpu/drm/tegra/gem.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/drivers/gpu/drm/tegra/gem.c b/drivers/gpu/drm/tegra/gem.c index 01e16e146bfe..fb712316c522 100644 --- a/drivers/gpu/drm/tegra/gem.c +++ b/drivers/gpu/drm/tegra/gem.c @@ -408,12 +408,9 @@ int tegra_bo_dumb_map_offset(struct drm_file *file, struct drm_device *drm, struct drm_gem_object *gem; struct tegra_bo *bo; - mutex_lock(&drm->struct_mutex); - gem = drm_gem_object_lookup(drm, file, handle); if (!gem) { dev_err(drm->dev, "failed to lookup GEM object\n"); - mutex_unlock(&drm->struct_mutex); return -EINVAL; } @@ -421,9 +418,7 @@ int tegra_bo_dumb_map_offset(struct drm_file *file, struct drm_device *drm, *offset = drm_vma_node_offset_addr(&bo->gem.vma_node); - drm_gem_object_unreference(gem); - - mutex_unlock(&drm->struct_mutex); + drm_gem_object_unreference_unlocked(gem); return 0; }