diff mbox

[5/5] drm/imx: ipuv3 plane: Replace dev_info with dev_dbg if a plane's CRTC changes

Message ID 1448007251-25591-5-git-send-email-Ying.Liu@freescale.com (mailing list archive)
State New, archived
Headers show

Commit Message

Liu Ying Nov. 20, 2015, 8:14 a.m. UTC
This patch changes the dev_info() call to dev_dbg() in ipu_plane_update()
to print out the information that a plane's CRTC is changed, because this
kind of information is only useful for debugging.

Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
---
This patch applies to the imx-drm/fixes branch of Philipp Zabel's open git.

 drivers/gpu/drm/imx/ipuv3-plane.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Zabel Nov. 23, 2015, 11:48 a.m. UTC | #1
Am Freitag, den 20.11.2015, 16:14 +0800 schrieb Liu Ying:
> This patch changes the dev_info() call to dev_dbg() in ipu_plane_update()
> to print out the information that a plane's CRTC is changed, because this
> kind of information is only useful for debugging.
> 
> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> ---
> This patch applies to the imx-drm/fixes branch of Philipp Zabel's open git.
> 
>  drivers/gpu/drm/imx/ipuv3-plane.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
> index b3ed207..b24bf94 100644
> --- a/drivers/gpu/drm/imx/ipuv3-plane.c
> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
> @@ -338,7 +338,7 @@ static int ipu_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
>  	}
>  
>  	if (crtc != plane->crtc)
> -		dev_info(plane->dev->dev, "crtc change: %p -> %p\n",
> +		dev_dbg(plane->dev->dev, "crtc change: %p -> %p\n",
>  				plane->crtc, crtc);
>  	plane->crtc = crtc;

This change is separate from the others, I have applied it.

thanks
Philipp
Liu Ying Jan. 22, 2016, 2:29 a.m. UTC | #2
Hi Philipp,

2015-11-23 19:48 GMT+08:00 Philipp Zabel <p.zabel@pengutronix.de>:
> Am Freitag, den 20.11.2015, 16:14 +0800 schrieb Liu Ying:
>> This patch changes the dev_info() call to dev_dbg() in ipu_plane_update()
>> to print out the information that a plane's CRTC is changed, because this
>> kind of information is only useful for debugging.
>>
>> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
>> ---
>> This patch applies to the imx-drm/fixes branch of Philipp Zabel's open git.
>>
>>  drivers/gpu/drm/imx/ipuv3-plane.c | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
>> index b3ed207..b24bf94 100644
>> --- a/drivers/gpu/drm/imx/ipuv3-plane.c
>> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
>> @@ -338,7 +338,7 @@ static int ipu_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
>>       }
>>
>>       if (crtc != plane->crtc)
>> -             dev_info(plane->dev->dev, "crtc change: %p -> %p\n",
>> +             dev_dbg(plane->dev->dev, "crtc change: %p -> %p\n",
>>                               plane->crtc, crtc);
>>       plane->crtc = crtc;
>
> This change is separate from the others, I have applied it.

I don't find this patch on any imx-drm branch in your open git repository.
Do I miss anything?

Regards,
Liu Ying

>
> thanks
> Philipp
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel
Philipp Zabel Jan. 25, 2016, 9:56 a.m. UTC | #3
Hi Liu,

Am Freitag, den 22.01.2016, 10:29 +0800 schrieb Liu Ying:
> Hi Philipp,
> 
> 2015-11-23 19:48 GMT+08:00 Philipp Zabel <p.zabel@pengutronix.de>:
> > Am Freitag, den 20.11.2015, 16:14 +0800 schrieb Liu Ying:
> >> This patch changes the dev_info() call to dev_dbg() in ipu_plane_update()
> >> to print out the information that a plane's CRTC is changed, because this
> >> kind of information is only useful for debugging.
> >>
> >> Signed-off-by: Liu Ying <Ying.Liu@freescale.com>
> >> ---
> >> This patch applies to the imx-drm/fixes branch of Philipp Zabel's open git.
> >>
> >>  drivers/gpu/drm/imx/ipuv3-plane.c | 2 +-
> >>  1 file changed, 1 insertion(+), 1 deletion(-)
> >>
> >> diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
> >> index b3ed207..b24bf94 100644
> >> --- a/drivers/gpu/drm/imx/ipuv3-plane.c
> >> +++ b/drivers/gpu/drm/imx/ipuv3-plane.c
> >> @@ -338,7 +338,7 @@ static int ipu_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
> >>       }
> >>
> >>       if (crtc != plane->crtc)
> >> -             dev_info(plane->dev->dev, "crtc change: %p -> %p\n",
> >> +             dev_dbg(plane->dev->dev, "crtc change: %p -> %p\n",
> >>                               plane->crtc, crtc);
> >>       plane->crtc = crtc;
> >
> > This change is separate from the others, I have applied it.
> 
> I don't find this patch on any imx-drm branch in your open git repository.
> Do I miss anything?

It's in the imx-drm/next branch, I have waited for v4.5-rc1 before
pushing it.

regards
Philipp
diff mbox

Patch

diff --git a/drivers/gpu/drm/imx/ipuv3-plane.c b/drivers/gpu/drm/imx/ipuv3-plane.c
index b3ed207..b24bf94 100644
--- a/drivers/gpu/drm/imx/ipuv3-plane.c
+++ b/drivers/gpu/drm/imx/ipuv3-plane.c
@@ -338,7 +338,7 @@  static int ipu_update_plane(struct drm_plane *plane, struct drm_crtc *crtc,
 	}
 
 	if (crtc != plane->crtc)
-		dev_info(plane->dev->dev, "crtc change: %p -> %p\n",
+		dev_dbg(plane->dev->dev, "crtc change: %p -> %p\n",
 				plane->crtc, crtc);
 	plane->crtc = crtc;