From patchwork Mon Nov 23 09:32:54 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7678881 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 5DC02BF90C for ; Mon, 23 Nov 2015 09:33:45 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 8D01B2061B for ; Mon, 23 Nov 2015 09:33:44 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id BC14220643 for ; Mon, 23 Nov 2015 09:33:43 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id EB2BA720F9; Mon, 23 Nov 2015 01:33:36 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49]) by gabe.freedesktop.org (Postfix) with ESMTPS id 02FC2720FC for ; Mon, 23 Nov 2015 01:33:35 -0800 (PST) Received: by wmec201 with SMTP id c201so151037753wme.0 for ; Mon, 23 Nov 2015 01:33:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Xheq5Ld6beGvfYnV0C/aSHz8OrCoYZdKyj38xhf2Vw8=; b=GG6UHp+Ea47b3+mBUsbnKm8yFaJ/KBv7qz5NLVGIpsV0jvqXDWhYi1vziqs52Zm5G8 xGCsW/TOu1gW/1r3b1u3VmhnsEPlaRkpUSYb9wyDKpyjxMgFQ8+x14sIVS+r6nRZnprs 8yckhE4p+lQHG2wu6Ch/7XtW3rMIFvynNHIBc= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Xheq5Ld6beGvfYnV0C/aSHz8OrCoYZdKyj38xhf2Vw8=; b=MT2lbyXMi8d45MdeGeNAWVW8G3gSU/m1iKBEpVjmOYoxgDCMQ2WX/+mbvGF708eIzH o2OdGeS6WLUVpaNaRk2Dtz79EwT7cMYVsBwK4WYpdIe1aefxg4vanwtyGJVptfdxziUm 249wyfwPJ39tIdkXtBF2r9pj95XmhL5ZM1NMo9gLQeuxftviSwXIcRdbemcVoXeKVgNm wi6zOKvTUW8kcd+qVKgGpoC9le3lynyjSo3EUavy6VqnvUW2AholHLCv2d7IUZzebLwV RlUEwYqf2hrrIqtd4tNVEGfAnT/dfvsWxweU16vT9hF7+PjJGGg/8fjujnPTnaNjBBW0 xIJg== X-Gm-Message-State: ALoCoQlANBOIfgThWB7sMYE91JtPjO8iG6bX/LbwV0JhRAttjbPC74WH+gvMrwx3DSz4JxzviEy8 X-Received: by 10.28.57.65 with SMTP id g62mr14292086wma.65.1448271213683; Mon, 23 Nov 2015 01:33:33 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id pn6sm12332758wjb.15.2015.11.23.01.33.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Nov 2015 01:33:33 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 21/29] drm/nouveau: Drop dev->struct_mutex from fbdev init Date: Mon, 23 Nov 2015 10:32:54 +0100 Message-Id: <1448271183-20523-22-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> References: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Ben Skeggs , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Doesn't protect anything at all. With this patch nouveau is completely dev->struct_mutex free! Cc: Ben Skeggs Signed-off-by: Daniel Vetter --- drivers/gpu/drm/nouveau/nouveau_fbcon.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fbcon.c b/drivers/gpu/drm/nouveau/nouveau_fbcon.c index 59f27e774acb..3bae706126bd 100644 --- a/drivers/gpu/drm/nouveau/nouveau_fbcon.c +++ b/drivers/gpu/drm/nouveau/nouveau_fbcon.c @@ -386,8 +386,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, } } - mutex_lock(&dev->struct_mutex); - info = drm_fb_helper_alloc_fbi(helper); if (IS_ERR(info)) { ret = PTR_ERR(info); @@ -426,8 +424,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, /* Use default scratch pixmap (info->pixmap.flags = FB_PIXMAP_SYSTEM) */ - mutex_unlock(&dev->struct_mutex); - if (chan) nouveau_fbcon_accel_init(dev); nouveau_fbcon_zfill(dev, fbcon); @@ -441,7 +437,6 @@ nouveau_fbcon_create(struct drm_fb_helper *helper, return 0; out_unlock: - mutex_unlock(&dev->struct_mutex); if (chan) nouveau_bo_vma_del(nvbo, &fbcon->nouveau_fb.vma); nouveau_bo_unmap(nvbo);