From patchwork Mon Nov 23 09:32:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7678911 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 3622E9F1D3 for ; Mon, 23 Nov 2015 09:33:48 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 568F720623 for ; Mon, 23 Nov 2015 09:33:47 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 8A20D20445 for ; Mon, 23 Nov 2015 09:33:46 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 58E84720F5; Mon, 23 Nov 2015 01:33:39 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f50.google.com (mail-wm0-f50.google.com [74.125.82.50]) by gabe.freedesktop.org (Postfix) with ESMTPS id 579B8720F5 for ; Mon, 23 Nov 2015 01:33:38 -0800 (PST) Received: by wmuu63 with SMTP id u63so45635924wmu.0 for ; Mon, 23 Nov 2015 01:33:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=pXfPdx/9yd8i5kCj/s3y1EVMBtpcEzdjcFDbRy7pO3g=; b=g7QhthZ8bsqc53OZnRGY7io06oRHd392bll+Q8oWfhwRFT4JC+smdcL/jrm+gwbcnw OiUPhySRH0rz1Vt5o4AkH2mZqGVshIYxoVyNAGFQpHDfGRTFbQHJdi8S1TlnIxxn3Bdj 4bPgAHPbfs6uZiuOFACzjHvk8ZqsINqUOe87k= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=pXfPdx/9yd8i5kCj/s3y1EVMBtpcEzdjcFDbRy7pO3g=; b=eP0ygss64n43LKflIymRe6/QSiFVZhd7bmBWOG7rPT2NXhVsvO2coI6iWCLz9AaYym TExKuAz9dVXoc1n2f/a9DzrKIdHxPCfr1kc9APU7uO+IOJosghjNWSR68HrldiRshtml et/BLpGBce4jh4MRf0TfQR9wuSClXjCrmI6MWOkslbkkRj0KW4vF1N6h2umsmZy79JAU HS2533M9/wFhSESYsbVQWIqmXiI9aMe/aFZn5Vj6owcqyJ4H+Exl2nj6rHM9ckHiDu/M Xe+05sbY/KjhBNkKJ9jwExnS8+4d4vMw1sF2nj2ka3tlarCdthgAuPg+dM/06A/H6Esw f1Dg== X-Gm-Message-State: ALoCoQkFfqYX9tnZs2ebIC686nqOsvCfavAQxoMxUcKbLGxk06PPJm9MtTHVyH2WW/E06nKMua7S X-Received: by 10.28.104.197 with SMTP id d188mr16079550wmc.55.1448271216669; Mon, 23 Nov 2015 01:33:36 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id pn6sm12332758wjb.15.2015.11.23.01.33.35 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Nov 2015 01:33:36 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 24/29] drm/exynos: drop struct_mutex from exynos_drm_gem_get_ioctl Date: Mon, 23 Nov 2015 10:32:57 +0100 Message-Id: <1448271183-20523-25-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> References: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The only things this protects is reading ->flags and ->size, both of which are invariant over the lifetime of an exynos gem bo. So no locking needed at all (besides that, nothing protects the writers anyway). Aside: exynos_gem_obj->size is redundant with exynos_gem_obj->base.size and probably should be removed. v2: Use _unlocked unreference (Daniel Stone). Cc: Daniel Stone Cc: Inki Dae Signed-off-by: Daniel Vetter Reviewed-by: Daniel Stone --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index b198fa560106..e735827e0c6d 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -352,12 +352,9 @@ int exynos_drm_gem_get_ioctl(struct drm_device *dev, void *data, struct drm_exynos_gem_info *args = data; struct drm_gem_object *obj; - mutex_lock(&dev->struct_mutex); - obj = drm_gem_object_lookup(dev, file_priv, args->handle); if (!obj) { DRM_ERROR("failed to lookup gem object.\n"); - mutex_unlock(&dev->struct_mutex); return -EINVAL; } @@ -366,8 +363,7 @@ int exynos_drm_gem_get_ioctl(struct drm_device *dev, void *data, args->flags = exynos_gem->flags; args->size = exynos_gem->size; - drm_gem_object_unreference(obj); - mutex_unlock(&dev->struct_mutex); + drm_gem_object_unreference_unlocked(obj); return 0; }