From patchwork Mon Nov 23 09:32:59 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7679111 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id CAEC99F1D3 for ; Mon, 23 Nov 2015 09:34:00 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 0F11020629 for ; Mon, 23 Nov 2015 09:34:00 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 333142065E for ; Mon, 23 Nov 2015 09:33:59 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 9B5E972115; Mon, 23 Nov 2015 01:33:49 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f44.google.com (mail-wm0-f44.google.com [74.125.82.44]) by gabe.freedesktop.org (Postfix) with ESMTPS id D31F1720FE for ; Mon, 23 Nov 2015 01:33:39 -0800 (PST) Received: by wmec201 with SMTP id c201so96435626wme.1 for ; Mon, 23 Nov 2015 01:33:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=kEGD+7iG6DuaOCD9+EQYg+qdVm9q7bbgOVL6S7p1V4k=; b=DXNAqwENc9aJVhEuGW+SFlacknxjuxXwoEvssWVRHS2uJyeLP/CYNVPJYUGqYnnUVO 8NXx21hCGkUTdvcGb/BDOKkxGNGh7ZeP1VQe1eUZrLBcvggEzjsRdEEWIEp2oSTJzntu xJMZ8mXjO0mLDumpVjVipNE7rjX99mN/BvHoY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=kEGD+7iG6DuaOCD9+EQYg+qdVm9q7bbgOVL6S7p1V4k=; b=ke2SdCpIpeED7EeIDZ/vl5jhsGsyVkaywysLacxXKdcNa00FjagnOgfLUjWFa2KeRL NEyOHR0vk5I8+FJqJ4YUh6L4rqVYPHWU0hPZXU43D1LKpWlemxweqiOvsGUfLNqaL1cG JOFap3B3Wubgsk0lNSNQUSTf8j9r7886gWPNSzJztA4QgoMKwqK0MPTD9BkdLHGWQ9bk P0AAPbqlRVNyPX16YAoovn9e5blc3GCBhTZ7MnnJAvZH6OhAt9v5LeA1eY9kimaeDe9X 4TxZ69aLSX50ezvPM2kwJyYY4Mj1H0RMEAY2M9hIN2e3CYrVS3ukmltaQmFFkHK+0j9B T7ow== X-Gm-Message-State: ALoCoQnkDvHSpqdbRHhb2i5WzDuFxAH8nyF7wcRNfV82HatponocVCHWAncZJP+6LdS0Sc/uEM3l X-Received: by 10.194.143.115 with SMTP id sd19mr33009383wjb.94.1448271218677; Mon, 23 Nov 2015 01:33:38 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id pn6sm12332758wjb.15.2015.11.23.01.33.37 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Nov 2015 01:33:38 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 26/29] drm/vgem: Simplify dum_map Date: Mon, 23 Nov 2015 10:32:59 +0100 Message-Id: <1448271183-20523-27-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> References: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The offset manager already checks for existing offsets internally, while holding suitable locks. We can drop this check. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/vgem/vgem_drv.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/vgem/vgem_drv.c b/drivers/gpu/drm/vgem/vgem_drv.c index 02ae60c395b7..63026d4324ad 100644 --- a/drivers/gpu/drm/vgem/vgem_drv.c +++ b/drivers/gpu/drm/vgem/vgem_drv.c @@ -208,11 +208,9 @@ int vgem_gem_dumb_map(struct drm_file *file, struct drm_device *dev, goto unlock; } - if (!drm_vma_node_has_offset(&obj->vma_node)) { - ret = drm_gem_create_mmap_offset(obj); - if (ret) - goto unref; - } + ret = drm_gem_create_mmap_offset(obj); + if (ret) + goto unref; BUG_ON(!obj->filp);