From patchwork Mon Nov 23 09:32:38 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 7678631 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id C8E48BF90C for ; Mon, 23 Nov 2015 09:33:26 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 004092062C for ; Mon, 23 Nov 2015 09:33:26 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 40B2620445 for ; Mon, 23 Nov 2015 09:33:25 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id E93AA720CC; Mon, 23 Nov 2015 01:33:21 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-f54.google.com (mail-wm0-f54.google.com [74.125.82.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6C182720CD for ; Mon, 23 Nov 2015 01:33:19 -0800 (PST) Received: by wmec201 with SMTP id c201so151027259wme.0 for ; Mon, 23 Nov 2015 01:33:18 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=Hi9pefg4I2suIUMyXxWpExl9MUWaEjG2TTHmTCWMJ/E=; b=aeejJ2uHiT5BwOX64UN3GPRnZRcnCnaCjWbzJMz+r2B/Zc9Kpi6Qc9RMgggO3A07B3 RaZSjwJ/2vhSuETZoiX6XOT94f7uDih4nuVD9psM79IcQ6RHqvixd/Mfcau6eE0IuYj4 pN/5WffgwZSEI5uJUedXqQNGT6d5iFnTxHr5U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=Hi9pefg4I2suIUMyXxWpExl9MUWaEjG2TTHmTCWMJ/E=; b=Im3jdi85sz37VsO+1A00Mqirl2UaE51GA867Q5zRkcM1Pg1xRkkMnx0BFZ4qQ3DpvA 2u8X1dVKWknAXKNFtt9ysARQZIvzUG5msNvy4w7cIRs5H0ezoGqd3JY6Vz+9aI05/Rl9 /7FWLKtgOsAPusJVUBP2GusNcaF8G3Jk/1E7GOoZdLfYTLy8ZFF6/3icK9xbkgSf65u9 Od0pYT0dID7yGVjyu+U/8OnooOJDhEOFlYkWsCXVzc2HeT48BUDBDScbCHwl1+zw2wHN Ducpt06JnTzaSAIXv67OmyuwzHye1sBZkd0B4w/k6O06+joKNzluIm8I6Ov4Yf3uf7pK T/zA== X-Gm-Message-State: ALoCoQn/xG9AfQ0LvywBUFRk73ESYgIq65tDOgsbTmPW5U6+2PUGH39DbuadiBRYc80zTjv3sYzD X-Received: by 10.28.234.200 with SMTP id g69mr17022367wmi.97.1448271198145; Mon, 23 Nov 2015 01:33:18 -0800 (PST) Received: from phenom.ffwll.local (212-51-149-109.fiber7.init7.net. [212.51.149.109]) by smtp.gmail.com with ESMTPSA id pn6sm12332758wjb.15.2015.11.23.01.33.17 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Mon, 23 Nov 2015 01:33:17 -0800 (PST) From: Daniel Vetter To: DRI Development Subject: [PATCH 05/29] drm/radeon: Use unlocked gem unreferencing Date: Mon, 23 Nov 2015 10:32:38 +0100 Message-Id: <1448271183-20523-6-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.1 In-Reply-To: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> References: <1448271183-20523-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Alex Deucher , Daniel Vetter , Intel Graphics Development , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.7 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For drm_gem_object_unreference callers are required to hold dev->struct_mutex, which these paths don't. Enforcing this requirement has become a bit more strict with commit ef4c6270bf2867e2f8032e9614d1a8cfc6c71663 Author: Daniel Vetter Date: Thu Oct 15 09:36:25 2015 +0200 drm/gem: Check locking in drm_gem_object_unreference Cc: Alex Deucher Signed-off-by: Daniel Vetter --- drivers/gpu/drm/radeon/radeon_fb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/radeon/radeon_fb.c b/drivers/gpu/drm/radeon/radeon_fb.c index adc44bbc81a9..d2e628eea53d 100644 --- a/drivers/gpu/drm/radeon/radeon_fb.c +++ b/drivers/gpu/drm/radeon/radeon_fb.c @@ -282,7 +282,7 @@ out_unref: } if (fb && ret) { - drm_gem_object_unreference(gobj); + drm_gem_object_unreference_unlocked(gobj); drm_framebuffer_unregister_private(fb); drm_framebuffer_cleanup(fb); kfree(fb);