From patchwork Wed Dec 2 11:57:52 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 7745351 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1A5BB9F39D for ; Wed, 2 Dec 2015 11:58:04 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 2426C20643 for ; Wed, 2 Dec 2015 11:58:02 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id B66B22063E for ; Wed, 2 Dec 2015 11:58:00 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D55D26E986; Wed, 2 Dec 2015 03:57:57 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout1.samsung.com (mailout1.samsung.com [203.254.224.24]) by gabe.freedesktop.org (Postfix) with ESMTPS id B21946E985 for ; Wed, 2 Dec 2015 03:57:56 -0800 (PST) Received: from epcpsbgr1.samsung.com (u141.gpu120.samsung.co.kr [203.254.230.141]) by mailout1.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NYQ02Y0QBWIUIE0@mailout1.samsung.com> for dri-devel@lists.freedesktop.org; Wed, 02 Dec 2015 20:57:54 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.113]) by epcpsbgr1.samsung.com (EPCPMTA) with SMTP id 08.FD.04949.2CCDE565; Wed, 2 Dec 2015 20:57:54 +0900 (KST) X-AuditID: cbfee68d-f79646d000001355-bc-565edcc21001 Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id 14.2F.13906.2CCDE565; Wed, 2 Dec 2015 20:57:54 +0900 (KST) Received: from localhost.localdomain ([10.113.62.206]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NYQ00JKCBWH9VA0@mmp2.samsung.com>; Wed, 02 Dec 2015 20:57:54 +0900 (KST) From: Inki Dae To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/2] drm/exynos: dp: fix wrong return type Date: Wed, 02 Dec 2015 20:57:52 +0900 Message-id: <1449057472-4389-2-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1449057472-4389-1-git-send-email-inki.dae@samsung.com> References: <1449057472-4389-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrHLMWRmVeSWpSXmKPExsWyRsSkUPfQnbgwg7VX9S16z51ksrjy9T2b xaT7E1gs3rxdw2Qx4/w+JgdWj+3fHrB63O8+zuSxpf8uu0ffllWMHp83yQWwRnHZpKTmZJal FunbJXBl3Pi9mr1gGUfF1SUbWBoYn7N1MXJySAiYSHTsecYKYYtJXLi3HiwuJLCCUWJHa0IX IwdYzfs9QV2MXEDhWYwSF0/cY4ZwfjBKfGzcygLSwCagKjFxxX2wZhEBZYm/E1cxgtjMAkUS S/afYAaxhQVsJWZ+PQQWZwGqf/26B2wxr4CzxM4rNxghjpCTOHlsMivIYk4BF4l/+9lBTCGg ksb1qiBrJQS62SU2r1rKBDFGQOLb5EMsEHfKSmw6wAwxRVLi4IobLBMYhRcwMqxiFE0tSC4o TkovMtQrTswtLs1L10vOz93ECAzm0/+e9e5gvH3A+hCjAAejEg/vCp64MCHWxLLiytxDjKZA GyYyS4km5wNjJq8k3tDYzMjC1MTU2Mjc0kxJnFdR6mewkEB6YklqdmpqQWpRfFFpTmrxIUYm Dk6pBsarWveeTDq8uJwv3NTEWzTJbWv4ydCH2/2iP/V5W7ysvy1heLNcy+3I0/wAr9CChkrF D/5Jr26Hfwt80RmW6j1xQ/8Lpa6p+/h27vgXdfjqvl3TFmvevjwpPS/iRqKowIWOs2wt7rt9 /dadejiLp535tkLri+OzlU3uHTMu/b99y+VXFq5bjWKUWIozEg21mIuKEwG7CvpKYQIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprDIsWRmVeSWpSXmKPExsVy+t9jQd1Dd+LCDJ4t1LboPXeSyeLK1/ds FpPuT2CxePN2DZPFjPP7mBxYPbZ/e8Dqcb/7OJPHlv677B59W1YxenzeJBfAGtXAaJORmpiS WqSQmpecn5KZl26r5B0c7xxvamZgqGtoaWGupJCXmJtqq+TiE6DrlpkDtF1JoSwxpxQoFJBY XKykb4dpQmiIm64FTGOErm9IEFyPkQEaSFjDmHHj92r2gmUcFVeXbGBpYHzO1sXIwSEhYCLx fk9QFyMnkCkmceHeeqAwF4eQwCxGiYsn7jFDOD8YJT42bmUBqWITUJWYuOI+G4gtIqAs8Xfi KkYQm1mgSGLJ/hPMILawgK3EzK+HwOIsQPWvX/ewgti8As4SO6/cYITYJidx8thkVpAjOAVc JP7tZwcxhYBKGterTmDkXcDIsIpRIrUguaA4KT3XMC+1XK84Mbe4NC9dLzk/dxMjOGaeSe1g PLjL/RCjAAejEg/vCp64MCHWxLLiytxDjBIczEoivF4yQCHelMTKqtSi/Pii0pzU4kOMpkBn TWSWEk3OB8ZzXkm8obGJmZGlkbmhhZGxuZI4b+2lyDAhgfTEktTs1NSC1CKYPiYOTqkGxmWH stpmROv6Buk2+3zgrzfvmHD+e0rv8t2F5ye8fL1VtvWsbKFDVtxnzcJKzkuZIbrzLrYYzIrd fUhjR4739tVVYvtqhcrVds8TNT+z6tCjeXtqjrBKp4YuvfV+15G5vUVdTixvtPUiDz+58GlD lFd5pbDmYaOXU/RXPhSVYGkOnnC/oys+TomlOCPRUIu5qDgRAGfXQYCvAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: javier@osg.samsung.com, linux-samsung-soc@vger.kernel.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes wrong return type when dt binding of bridge device failed. If a board has a bridge device then of_graph_get_remote_port_parent function shouldn't be NULL. So this patch will return a proper error type so that the deferred probe isn't triggered. Changelog v2: - return -EINVAL if getting a port node failed. Signed-off-by: Inki Dae Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index 0b53045..c77fb83 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -1436,8 +1436,10 @@ static int exynos_dp_probe(struct platform_device *pdev) of_node_put(bridge_node); if (!dp->ptn_bridge) return -EPROBE_DEFER; - } else - return -EPROBE_DEFER; + } else { + DRM_ERROR("no port node for bridge device.\n"); + return -EINVAL; + } } pm_runtime_enable(dev);