diff mbox

[11/12] MAINTAINERS: add Lucas Stach as maintainer for the etnaviv DRM driver

Message ID 1449237604-19064-12-git-send-email-l.stach@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lucas Stach Dec. 4, 2015, 2 p.m. UTC
Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 MAINTAINERS | 7 +++++++
 1 file changed, 7 insertions(+)

Comments

Russell King - ARM Linux Dec. 4, 2015, 5:07 p.m. UTC | #1
On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>

Although, I would like to be copied on patches, I don't think we
have a way to encode that information in MAINTAINERS.

> ---
>  MAINTAINERS | 7 +++++++
>  1 file changed, 7 insertions(+)
> 
> diff --git a/MAINTAINERS b/MAINTAINERS
> index e9caa4b28828..1c69563c61ed 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -3741,6 +3741,13 @@ S:	Maintained
>  F:	drivers/gpu/drm/sti
>  F:	Documentation/devicetree/bindings/display/st,stih4xx.txt
>  
> +DRM DRIVERS FOR VIVANTE GPU IP
> +M:	Lucas Stach <l.stach@pengutronix.de>
> +L:	dri-devel@lists.freedesktop.org
> +S:	Maintained
> +F:	drivers/gpu/drm/etnaviv
> +F:	Documentation/devicetree/bindings/display/etnaviv
> +
>  DSBR100 USB FM RADIO DRIVER
>  M:	Alexey Klimov <klimov.linux@gmail.com>
>  L:	linux-media@vger.kernel.org
> -- 
> 2.6.2
>
Ilia Mirkin Dec. 4, 2015, 5:08 p.m. UTC | #2
On Fri, Dec 4, 2015 at 12:07 PM, Russell King - ARM Linux
<linux@arm.linux.org.uk> wrote:
> On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>
> Although, I would like to be copied on patches, I don't think we
> have a way to encode that information in MAINTAINERS.

From the top of the MAINTAINERS file:

Descriptions of section entries:

        P: Person (obsolete)
        M: Mail patches to: FullName <address@domain>
        R: Designated reviewer: FullName <address@domain>
           These reviewers should be CCed on patches.

So I guess that'd mean you want to be a reviewer?

  -ilia
Russell King - ARM Linux Dec. 4, 2015, 5:13 p.m. UTC | #3
On Fri, Dec 04, 2015 at 12:08:47PM -0500, Ilia Mirkin wrote:
> On Fri, Dec 4, 2015 at 12:07 PM, Russell King - ARM Linux
> <linux@arm.linux.org.uk> wrote:
> > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
> >> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> >
> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> >
> > Although, I would like to be copied on patches, I don't think we
> > have a way to encode that information in MAINTAINERS.
> 
> >From the top of the MAINTAINERS file:
> 
> Descriptions of section entries:
> 
>         P: Person (obsolete)
>         M: Mail patches to: FullName <address@domain>
>         R: Designated reviewer: FullName <address@domain>
>            These reviewers should be CCed on patches.
> 
> So I guess that'd mean you want to be a reviewer?

Oh, that got agreed upon?  I thought there was pushback against that
idea.

You are correct.
Christian Gmeiner Dec. 4, 2015, 5:17 p.m. UTC | #4
2015-12-04 18:13 GMT+01:00 Russell King - ARM Linux <linux@arm.linux.org.uk>:
> On Fri, Dec 04, 2015 at 12:08:47PM -0500, Ilia Mirkin wrote:
>> On Fri, Dec 4, 2015 at 12:07 PM, Russell King - ARM Linux
>> <linux@arm.linux.org.uk> wrote:
>> > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
>> >> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
>> >
>> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
>> >
>> > Although, I would like to be copied on patches, I don't think we
>> > have a way to encode that information in MAINTAINERS.
>>
>> >From the top of the MAINTAINERS file:
>>
>> Descriptions of section entries:
>>
>>         P: Person (obsolete)
>>         M: Mail patches to: FullName <address@domain>
>>         R: Designated reviewer: FullName <address@domain>
>>            These reviewers should be CCed on patches.
>>
>> So I guess that'd mean you want to be a reviewer?
>
> Oh, that got agreed upon?  I thought there was pushback against that
> idea.
>
> You are correct.
>

Put me on the reviewer list too.

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner
Lucas Stach Dec. 4, 2015, 5:18 p.m. UTC | #5
Am Freitag, den 04.12.2015, 17:13 +0000 schrieb Russell King - ARM
Linux:
> On Fri, Dec 04, 2015 at 12:08:47PM -0500, Ilia Mirkin wrote:
> > On Fri, Dec 4, 2015 at 12:07 PM, Russell King - ARM Linux
> > <linux@arm.linux.org.uk> wrote:
> > > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
> > >> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > >
> > > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > >
> > > Although, I would like to be copied on patches, I don't think we
> > > have a way to encode that information in MAINTAINERS.
> > 
> > >From the top of the MAINTAINERS file:
> > 
> > Descriptions of section entries:
> > 
> >         P: Person (obsolete)
> >         M: Mail patches to: FullName <address@domain>
> >         R: Designated reviewer: FullName <address@domain>
> >            These reviewers should be CCed on patches.
> > 
> > So I guess that'd mean you want to be a reviewer?
> 
> Oh, that got agreed upon?  I thought there was pushback against that
> idea.
> 
There was pushback to change random people in MAINTAINERS from
maintainer to reviewer just because they don't manage a git tree on
their own. The reviewer tag itself was agreed upon.

If you want to be CC'ed on patches we should definitely add you as a
reviewer.
Marc Kleine-Budde Dec. 4, 2015, 5:26 p.m. UTC | #6
On 12/04/2015 06:07 PM, Russell King - ARM Linux wrote:
> On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
>> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> 
> Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> 
> Although, I would like to be copied on patches, I don't think we
> have a way to encode that information in MAINTAINERS.

I think you can just add another
"M: Russell King <linux@arm.linux.org.uk>" next to Lucas. We have this
for the CAN drivers and it seems to work.

> 
>> ---
>>  MAINTAINERS | 7 +++++++
>>  1 file changed, 7 insertions(+)
>>
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index e9caa4b28828..1c69563c61ed 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -3741,6 +3741,13 @@ S:	Maintained
>>  F:	drivers/gpu/drm/sti
>>  F:	Documentation/devicetree/bindings/display/st,stih4xx.txt
>>  
>> +DRM DRIVERS FOR VIVANTE GPU IP
>> +M:	Lucas Stach <l.stach@pengutronix.de>
>> +L:	dri-devel@lists.freedesktop.org
>> +S:	Maintained
>> +F:	drivers/gpu/drm/etnaviv
>> +F:	Documentation/devicetree/bindings/display/etnaviv
>> +
>>  DSBR100 USB FM RADIO DRIVER
>>  M:	Alexey Klimov <klimov.linux@gmail.com>
>>  L:	linux-media@vger.kernel.org
>> -- 
>> 2.6.2
>>
> 

Marc
Russell King - ARM Linux Dec. 4, 2015, 5:37 p.m. UTC | #7
On Fri, Dec 04, 2015 at 06:26:38PM +0100, Marc Kleine-Budde wrote:
> On 12/04/2015 06:07 PM, Russell King - ARM Linux wrote:
> > On Fri, Dec 04, 2015 at 03:00:03PM +0100, Lucas Stach wrote:
> >> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
> > 
> > Acked-by: Russell King <rmk+kernel@arm.linux.org.uk>
> > 
> > Although, I would like to be copied on patches, I don't think we
> > have a way to encode that information in MAINTAINERS.
> 
> I think you can just add another
> "M: Russell King <linux@arm.linux.org.uk>" next to Lucas. We have this
> for the CAN drivers and it seems to work.

What I'm after avoiding is ending up having to look after this - I've
already enough things on my plate, and I'm not good at context switching
between them.

However, given that I have the ability to test changes on both Dove and
iMX6, that's why I'd like to be Cc'd, so that I can (when I have the
available time) test on Dove, but I don't want to be in the situation
where I'm being required to give acks etc.
Christian Gmeiner Dec. 5, 2015, 3:17 p.m. UTC | #8
2015-12-04 15:00 GMT+01:00 Lucas Stach <l.stach@pengutronix.de>:
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Acked-by: Christian Gmeiner <christian.gmeiner@gmail.com>

greets
--
Christian Gmeiner, MSc

https://soundcloud.com/christian-gmeiner
diff mbox

Patch

diff --git a/MAINTAINERS b/MAINTAINERS
index e9caa4b28828..1c69563c61ed 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3741,6 +3741,13 @@  S:	Maintained
 F:	drivers/gpu/drm/sti
 F:	Documentation/devicetree/bindings/display/st,stih4xx.txt
 
+DRM DRIVERS FOR VIVANTE GPU IP
+M:	Lucas Stach <l.stach@pengutronix.de>
+L:	dri-devel@lists.freedesktop.org
+S:	Maintained
+F:	drivers/gpu/drm/etnaviv
+F:	Documentation/devicetree/bindings/display/etnaviv
+
 DSBR100 USB FM RADIO DRIVER
 M:	Alexey Klimov <klimov.linux@gmail.com>
 L:	linux-media@vger.kernel.org