From patchwork Mon Dec 7 12:52:36 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Inki Dae X-Patchwork-Id: 7783431 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 04B1B9F716 for ; Mon, 7 Dec 2015 12:52:49 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 23BC92049E for ; Mon, 7 Dec 2015 12:52:48 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 36DA32052C for ; Mon, 7 Dec 2015 12:52:47 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 570666E5E3; Mon, 7 Dec 2015 04:52:46 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mailout3.samsung.com (mailout3.samsung.com [203.254.224.33]) by gabe.freedesktop.org (Postfix) with ESMTPS id B1F2E6E5E0 for ; Mon, 7 Dec 2015 04:52:42 -0800 (PST) Received: from epcpsbgr3.samsung.com (u143.gpu120.samsung.co.kr [203.254.230.143]) by mailout3.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTP id <0NYZ01SNUNRSQ410@mailout3.samsung.com> for dri-devel@lists.freedesktop.org; Mon, 07 Dec 2015 21:52:40 +0900 (KST) Received: from epcpsbgm1new.samsung.com ( [172.20.52.114]) by epcpsbgr3.samsung.com (EPCPMTA) with SMTP id AF.4E.04964.81185665; Mon, 7 Dec 2015 21:52:40 +0900 (KST) X-AuditID: cbfee68f-f793a6d000001364-eb-566581183fef Received: from epmmp2 ( [203.254.227.17]) by epcpsbgm1new.samsung.com (EPCPMTA) with SMTP id F7.FC.13906.81185665; Mon, 7 Dec 2015 21:52:40 +0900 (KST) Received: from localhost.localdomain ([10.113.62.206]) by mmp2.samsung.com (Oracle Communications Messaging Server 7.0.5.31.0 64bit (built May 5 2014)) with ESMTPA id <0NYZ00JAQNRRRP40@mmp2.samsung.com>; Mon, 07 Dec 2015 21:52:40 +0900 (KST) From: Inki Dae To: dri-devel@lists.freedesktop.org Subject: [PATCH v2 2/4] drm/exynos: dp: fix wrong return type Date: Mon, 07 Dec 2015 21:52:36 +0900 Message-id: <1449492758-19989-3-git-send-email-inki.dae@samsung.com> X-Mailer: git-send-email 1.9.1 In-reply-to: <1449492758-19989-1-git-send-email-inki.dae@samsung.com> References: <1449492758-19989-1-git-send-email-inki.dae@samsung.com> X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42JZI2JSpCvRmBpmsPabsUXvuZNMFvOPnGO1 uPL1PZtF/5uFrBbnXq1ktJh0fwKLxZu3a5gsXr8wtOhdcJXNYsb5fUwWS69fZLKYMH0ti0Xr 3iPsDrwea+atYfS43NfL5LFy+Rc2j02rOtk8tn97wOpxv/s4k8eW/rvsHn1bVjF6fN4kF8AZ xWWTkpqTWZZapG+XwJWx61g3a8Eljoo7f1+zNDD2sXcxcnJICJhIHNi/hhHCFpO4cG89Wxcj F4eQwApGiWMX9rLCFF3oOMgIkZjFKPFm5xdWCOcHUNWRBcwgVWwCqhITV9xnA7FFBJQl/k5c BdbBLLCdSWJx42KwhLCArcTz9Z1gY1mAGlY1fGcBsXkFXCRmfvzIBLFOTuLksclgNZwCrhIt 5x+B9QoB1exo+QY2VELgJbvEx8XbWCAGCUh8m3wIyOYASshKbDrADDFHUuLgihssExiFFzAy rGIUTS1ILihOSi8y1itOzC0uzUvXS87P3cQIjKbT/57172C8e8D6EKMAB6MSD++EzJQwIdbE suLK3EOMpkAbJjJLiSbnA2M2ryTe0NjMyMLUxNTYyNzSTEmcd6HUz2AhgfTEktTs1NSC1KL4 otKc1OJDjEwcnFINjAav5gT7uTzcHiJoder3oo4vD2ctWDHn2b3ZjrW82zfva31pFMHwu1d+ Qzjru5c2Z83FnkrX+My7s/c+h6HGgxz3OXdm3sw2C3n2bUuetZ9sbbfcQoYrV9ZwSnocvaIr ukWr5s36V/dkShYc2xs8JUHr5MYln80lL22d2biec+PJTuZJ0/bXenxVYinOSDTUYi4qTgQA PrjPqqECAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrNIsWRmVeSWpSXmKPExsVy+t9jQV2JxtQwg49/dS16z51ksph/5Byr xZWv79ks+t8sZLU492olo8Wk+xNYLN68XcNk8fqFoUXvgqtsFjPO72OyWHr9IpPFhOlrWSxa 9x5hd+D1WDNvDaPH5b5eJo+Vy7+weWxa1cnmsf3bA1aP+93HmTy29N9l9+jbsorR4/MmuQDO qAZGm4zUxJTUIoXUvOT8lMy8dFsl7+B453hTMwNDXUNLC3MlhbzE3FRbJRefAF23zBygw5UU yhJzSoFCAYnFxUr6dpgmhIa46VrANEbo+oYEwfUYGaCBhDWMGbuOdbMWXOKouPP3NUsDYx97 FyMnh4SAicSFjoOMELaYxIV769m6GLk4hARmMUq82fmFFcL5wShx7MgCZpAqNgFViYkr7rOB 2CICyhJ/J65iBCliFtjOJLG4cTFYQljAVuL5+k5WEJsFqGFVw3cWEJtXwEVi5sePTBDr5CRO HpsMVsMp4CrRcv4RWK8QUM2Olm+MExh5FzAyrGKUSC1ILihOSs81zEst1ytOzC0uzUvXS87P 3cQIjthnUjsYD+5yP8QowMGoxMM7ITMlTIg1say4MvcQowQHs5IIr2xmapgQb0piZVVqUX58 UWlOavEhRlOgwyYyS4km5wOTSV5JvKGxiZmRpZG5oYWRsbmSOG/tpcgwIYH0xJLU7NTUgtQi mD4mDk6pBkZh/Z9R/74emui0y0KYNXjCp+OuXSmvnX3EV+V4+gT4X0s4v3O1Q9BRz3Xfn0d9 m7R9wfH/K47UH/g74/Rci8hp21nZkkvqjIqDpflEXwpc1uBKUIjqnPfufHawtNPsIjuR9Oes AhMeSqRunnJs03fRjVcerVW/HXVsiqTcl+AHU3ektm5fYSmlxFKckWioxVxUnAgAlHY9nO4C AAA= DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Cc: mark.rutland@arm.com, devicetree@vger.kernel.org, k.kozlowski@samsung.com, linux-samsung-soc@vger.kernel.org, pawel.moll@arm.com, ijc+devicetree@hellion.org.uk, javier@osg.samsung.com, robh+dt@kernel.org, galak@codeaurora.org, kgene.kim@samsung.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP This patch fixes wrong return type when dt binding of bridge device failed. If a board has a bridge device then of_graph_get_remote_port_parent function shouldn't be NULL. So this patch will return a proper error type so that the deferred probe isn't triggered. Changelog v2: - return -EINVAL if getting a port node failed. Signed-off-by: Inki Dae Reviewed-by: Javier Martinez Canillas --- drivers/gpu/drm/exynos/exynos_dp_core.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_dp_core.c b/drivers/gpu/drm/exynos/exynos_dp_core.c index 60260a0..aeee60a 100644 --- a/drivers/gpu/drm/exynos/exynos_dp_core.c +++ b/drivers/gpu/drm/exynos/exynos_dp_core.c @@ -1437,8 +1437,10 @@ static int exynos_dp_probe(struct platform_device *pdev) of_node_put(bridge_node); if (!dp->ptn_bridge) return -EPROBE_DEFER; - } else - return -EPROBE_DEFER; + } else { + DRM_ERROR("no port node for bridge device.\n"); + return -EINVAL; + } } out: