| Message ID | 1449564561-3896-5-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 8 December 2015 at 08:49, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > In my quest to remove all the drm_encoder_helper_funcs->save/restore > hooks I somehow missed that this driver has a dummy set too - I > thought all the i2c drivers only set up the slave_encoder save/restore > hooks, which I've left. Remove them. > There was an identical patch from Rodrigo a couple of days ago http://lists.freedesktop.org/archives/dri-devel/2015-December/096492.html -Emil
On Tue, Dec 08, 2015 at 09:30:48AM +0000, Emil Velikov wrote: > On 8 December 2015 at 08:49, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > In my quest to remove all the drm_encoder_helper_funcs->save/restore > > hooks I somehow missed that this driver has a dummy set too - I > > thought all the i2c drivers only set up the slave_encoder save/restore > > hooks, which I've left. Remove them. > > > There was an identical patch from Rodrigo a couple of days ago couple = less than 1 ;-) But thanks for pointing out, merged that patch instead. -Daniel > > http://lists.freedesktop.org/archives/dri-devel/2015-December/096492.html > > -Emil
On Tue, Dec 08, 2015 at 11:11:01AM +0100, Daniel Vetter wrote: > On Tue, Dec 08, 2015 at 09:30:48AM +0000, Emil Velikov wrote: > > On 8 December 2015 at 08:49, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: > > > In my quest to remove all the drm_encoder_helper_funcs->save/restore > > > hooks I somehow missed that this driver has a dummy set too - I > > > thought all the i2c drivers only set up the slave_encoder save/restore > > > hooks, which I've left. Remove them. > > > > > There was an identical patch from Rodrigo a couple of days ago > > couple = less than 1 ;-) But thanks for pointing out, merged that patch > instead. I'd be nice if Rodrigo's patch was copied to me. I've some patches outstanding (the atomic mode set) which I need to send to David, but this change should not conflict.
On Tue, Dec 8, 2015 at 2:15 AM, Russell King - ARM Linux <linux@arm.linux.org.uk> wrote: > On Tue, Dec 08, 2015 at 11:11:01AM +0100, Daniel Vetter wrote: >> On Tue, Dec 08, 2015 at 09:30:48AM +0000, Emil Velikov wrote: >> > On 8 December 2015 at 08:49, Daniel Vetter <daniel.vetter@ffwll.ch> wrote: >> > > In my quest to remove all the drm_encoder_helper_funcs->save/restore >> > > hooks I somehow missed that this driver has a dummy set too - I >> > > thought all the i2c drivers only set up the slave_encoder save/restore >> > > hooks, which I've left. Remove them. >> > > >> > There was an identical patch from Rodrigo a couple of days ago >> >> couple = less than 1 ;-) But thanks for pointing out, merged that patch >> instead. > > I'd be nice if Rodrigo's patch was copied to me. I've some patches > outstanding (the atomic mode set) which I need to send to David, but > this change should not conflict. I'm really sorry. I should've cc'ed both of you. > > -- > RMK's Patch system: http://www.arm.linux.org.uk/developer/patches/ > FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up > according to speedtest.net. > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > http://lists.freedesktop.org/mailman/listinfo/dri-devel
diff --git a/drivers/gpu/drm/i2c/tda998x_drv.c b/drivers/gpu/drm/i2c/tda998x_drv.c index 896b6aaf8c4d..79cb9208530e 100644 --- a/drivers/gpu/drm/i2c/tda998x_drv.c +++ b/drivers/gpu/drm/i2c/tda998x_drv.c @@ -855,18 +855,6 @@ static void tda998x_encoder_dpms(struct drm_encoder *encoder, int mode) priv->dpms = mode; } -static void -tda998x_encoder_save(struct drm_encoder *encoder) -{ - DBG(""); -} - -static void -tda998x_encoder_restore(struct drm_encoder *encoder) -{ - DBG(""); -} - static bool tda998x_encoder_mode_fixup(struct drm_encoder *encoder, const struct drm_display_mode *mode, @@ -1351,8 +1339,6 @@ static void tda998x_encoder_commit(struct drm_encoder *encoder) static const struct drm_encoder_helper_funcs tda998x_encoder_helper_funcs = { .dpms = tda998x_encoder_dpms, - .save = tda998x_encoder_save, - .restore = tda998x_encoder_restore, .mode_fixup = tda998x_encoder_mode_fixup, .prepare = tda998x_encoder_prepare, .commit = tda998x_encoder_commit,
In my quest to remove all the drm_encoder_helper_funcs->save/restore hooks I somehow missed that this driver has a dummy set too - I thought all the i2c drivers only set up the slave_encoder save/restore hooks, which I've left. Remove them. Reported-by: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Stephen Rothwell <sfr@canb.auug.org.au> Cc: Thierry Reding <thierry.reding@gmail.com> Cc: Russell King <rmk+kernel@arm.linux.org.uk> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/i2c/tda998x_drv.c | 14 -------------- 1 file changed, 14 deletions(-)