From patchwork Thu Dec 17 10:38:57 2015 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sudip Mukherjee X-Patchwork-Id: 7871781 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id E14B9BEEE5 for ; Thu, 17 Dec 2015 10:39:40 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1C9152025A for ; Thu, 17 Dec 2015 10:39:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id EC32A20218 for ; Thu, 17 Dec 2015 10:39:37 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0D2FD6E982; Thu, 17 Dec 2015 02:39:37 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-f54.google.com (mail-pa0-f54.google.com [209.85.220.54]) by gabe.freedesktop.org (Postfix) with ESMTPS id BD8CA6E982 for ; Thu, 17 Dec 2015 02:39:36 -0800 (PST) Received: by mail-pa0-f54.google.com with SMTP id jx14so11568445pad.2 for ; Thu, 17 Dec 2015 02:39:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id; bh=6CCTYp1I5K76M55yfZ2zFwR0JfOu1VWBKVasqN2Rnnw=; b=hEicJTGnit/GuYf5WO/u2q+psehSyKDicJid3dGIhT+5eOSymNZ8B6M31YKmsfuWcN AcJNcABUp3Mm8QoHUPkxBtAJ7R0rOYPwUsFptkcz7qyuRgZCMPmiMV/w4wERDhVUrs0Y lsrOFUyDu+dm8/sPsbQxJL4Bc79f+3qT98ti2QWwckfTKAz+sFSzRFzTp9FqPOJ79wD0 mvQwUhDYsG7fEpzp1nhAAajatAY7JYvbK59YiQ2Sj5Grk6W6IpAOhkx3cpnRwtv0Gsei JSbSyzZuJRBgaiuYCCxO2iZAIr8WM4eHF9dGYJ1HtgHjI2ljkCLrELyM4Ts2NwzovJab m2Ng== X-Received: by 10.66.236.162 with SMTP id uv2mr71042156pac.101.1450348776374; Thu, 17 Dec 2015 02:39:36 -0800 (PST) Received: from sudip-pc.vectortproxy.org ([49.206.205.82]) by smtp.gmail.com with ESMTPSA id w27sm10535183pfi.36.2015.12.17.02.39.23 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 17 Dec 2015 02:39:35 -0800 (PST) From: Sudip Mukherjee To: David Airlie Subject: [PATCH v2 1/2] drm/vc4: make function as void Date: Thu, 17 Dec 2015 16:08:57 +0530 Message-Id: <1450348738-1178-1-git-send-email-sudipm.mukherjee@gmail.com> X-Mailer: git-send-email 1.9.1 Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Sudip Mukherjee X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID, T_RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The return value of vc4_v3d_set_power() is never checked, we can make it void. Signed-off-by: Sudip Mukherjee --- drivers/gpu/drm/vc4/vc4_drv.h | 2 +- drivers/gpu/drm/vc4/vc4_v3d.c | 6 +++--- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_drv.h b/drivers/gpu/drm/vc4/vc4_drv.h index 080865e..47b9fc9 100644 --- a/drivers/gpu/drm/vc4/vc4_drv.h +++ b/drivers/gpu/drm/vc4/vc4_drv.h @@ -434,7 +434,7 @@ void vc4_plane_async_set_fb(struct drm_plane *plane, extern struct platform_driver vc4_v3d_driver; int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused); int vc4_v3d_debugfs_regs(struct seq_file *m, void *unused); -int vc4_v3d_set_power(struct vc4_dev *vc4, bool on); +void vc4_v3d_set_power(struct vc4_dev *vc4, bool on); /* vc4_validate.c */ int diff --git a/drivers/gpu/drm/vc4/vc4_v3d.c b/drivers/gpu/drm/vc4/vc4_v3d.c index 424d515..fc81412 100644 --- a/drivers/gpu/drm/vc4/vc4_v3d.c +++ b/drivers/gpu/drm/vc4/vc4_v3d.c @@ -150,13 +150,13 @@ int vc4_v3d_debugfs_ident(struct seq_file *m, void *unused) * This may be doable with just the clocks interface, though this * packet does some other register setup from the firmware, too. */ -int +void vc4_v3d_set_power(struct vc4_dev *vc4, bool on) { if (on) - return pm_generic_poweroff(&vc4->v3d->pdev->dev); + pm_generic_poweroff(&vc4->v3d->pdev->dev); else - return pm_generic_resume(&vc4->v3d->pdev->dev); + pm_generic_resume(&vc4->v3d->pdev->dev); } static void vc4_v3d_init_hw(struct drm_device *dev)