From patchwork Thu Jan 7 17:31:32 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Tim Gardner X-Patchwork-Id: 7981501 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 3E84EBEEE5 for ; Fri, 8 Jan 2016 00:51:41 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 5E91F2014A for ; Fri, 8 Jan 2016 00:51:40 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 0D2BE2015E for ; Fri, 8 Jan 2016 00:51:38 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 21887720C3; Thu, 7 Jan 2016 16:51:37 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-pa0-f43.google.com (mail-pa0-f43.google.com [209.85.220.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id BAF816E3B5 for ; Thu, 7 Jan 2016 09:31:50 -0800 (PST) Received: by mail-pa0-f43.google.com with SMTP id ho8so2794110pac.2 for ; Thu, 07 Jan 2016 09:31:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=canonical-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version:content-type :content-transfer-encoding; bh=whc41QwilNXJlfqOPWCAxxVdpYM7NC/TrG5HB1ioYFI=; b=sqZlqEaYe7e1bGoE2wm1MWTpG7GDO7fVb61mhpIgZ/EHoVSbl5xwujHNhCygCa8ETp WKMmvF7k+r5jp5ESk4SnfsKKKkSHiWckDdS/yrr0dNxQTd6gUWgySMMX1CIMIih52+TR 37nQb9Rd+ggLoRm220p4xkkIgXrWly8vZZ8h65MzMsKyeKyZo77BrfFjxX1K7iz3BN12 ECjvF/+XHdQqlXNr4oj7L686OW69bhktEBf9grJ4CTvTp4Kwd3WHwanw+m+mzL8xN+23 aGpV0yXoXH6+olw4IbH9ZKhTPz4bFDJEYuMJ8XBl5WoIRI/xZVtOF0UrP9qcnoTCIiaK ho7w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-type:content-transfer-encoding; bh=whc41QwilNXJlfqOPWCAxxVdpYM7NC/TrG5HB1ioYFI=; b=fgdHGBNpTMKElBfghRYyzsNM7S8G/AjmQkYdOHptHeDVTfcNOkTa1TvAmHxsaUtHy2 WpXdFmWRiW1whDKSEz++ex4rpjXZgIsO8Ls1Dp7q1Orb5H3ayWIvdgS1GHkjmp3cFFGp XdxlmrZTO2mZT9AL4MNoythtePLJtr8uXvMqU//bAhBlXPVZTo4ktCtKUq2A7GMKNl0i bydtTFpji22uyfKyxo/mlS8lVhjvGJo14d6l+g2ftLvk1MFit1UABEbrk//aYSukDy9I 9mIdEt+iW89EctKMCA/++eIwf8oy+g5ZTasNW8n2EAgLUi1xGS0J6PtYGspxcnupkTe3 aYIQ== X-Gm-Message-State: ALoCoQluABQ600CEPBcwt6BjUuMuKPyCM9y+1AatvZNpuoUlcNmk5DeRZfjVnJEn8qKPhPmJMAKOo2UeUrn8B8v6un0xzbsp3A== X-Received: by 10.66.235.162 with SMTP id un2mr1115778pac.17.1452187910350; Thu, 07 Jan 2016 09:31:50 -0800 (PST) Received: from localhost.localdomain (host-174-45-44-32.hln-mt.client.bresnan.net. [174.45.44.32]) by smtp.gmail.com with ESMTPSA id ux2sm159958414pac.46.2016.01.07.09.31.48 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 07 Jan 2016 09:31:49 -0800 (PST) From: tim.gardner@canonical.com To: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Subject: [PATCH v4.4-rc8] radeon: r100: Silence 'may be used uninitialized' warnings Date: Thu, 7 Jan 2016 10:31:32 -0700 Message-Id: <1452187892-8186-1-git-send-email-tim.gardner@canonical.com> X-Mailer: git-send-email 1.9.1 MIME-Version: 1.0 X-Mailman-Approved-At: Thu, 07 Jan 2016 16:51:35 -0800 Cc: Alex Deucher , Tim Gardner , =?UTF-8?q?Christian=20K=C3=B6nig?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Tim Gardner CC [M] drivers/gpu/drm/radeon/r100.o In file included from drivers/gpu/drm/radeon/radeon_mode.h:37:0, from drivers/gpu/drm/radeon/radeon.h:80, from drivers/gpu/drm/radeon/r100.c:33: drivers/gpu/drm/radeon/r100.c: In function 'r100_bandwidth_update': include/drm/drm_fixed.h:64:13: warning: 'crit_point_ff.full' may be used uninitialized in this function [-Wmaybe-uninitialized] u64 tmp = ((u64)A.full << 13); ^ drivers/gpu/drm/radeon/r100.c:3153:63: note: 'crit_point_ff.full' was declared here fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff, crit_point_ff; ^ drivers/gpu/drm/radeon/r100.c:3583:42: warning: 'disp_drain_rate.full' may be used uninitialized in this function [-Wmaybe-uninitialized] temp_ff.full = read_return_rate.full - disp_drain_rate.full; gcc version 5.3.1 20151219 (Ubuntu 5.3.1-4ubuntu1) Cc: Alex Deucher Cc: "Christian König" Cc: David Airlie Signed-off-by: Tim Gardner --- I think this warning is bogus, but I don't know how else to make gcc shut up. drivers/gpu/drm/radeon/r100.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/radeon/r100.c b/drivers/gpu/drm/radeon/r100.c index 9e7e2bf..5eae0a8 100644 --- a/drivers/gpu/drm/radeon/r100.c +++ b/drivers/gpu/drm/radeon/r100.c @@ -3150,7 +3150,8 @@ void r100_bandwidth_update(struct radeon_device *rdev) { fixed20_12 trcd_ff, trp_ff, tras_ff, trbs_ff, tcas_ff; fixed20_12 sclk_ff, mclk_ff, sclk_eff_ff, sclk_delay_ff; - fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff, crit_point_ff; + fixed20_12 peak_disp_bw, mem_bw, pix_clk, pix_clk2, temp_ff; + fixed20_12 crit_point_ff = {0}; uint32_t temp, data, mem_trcd, mem_trp, mem_tras; fixed20_12 memtcas_ff[8] = { dfixed_init(1), @@ -3204,7 +3205,7 @@ void r100_bandwidth_update(struct radeon_device *rdev) fixed20_12 min_mem_eff; fixed20_12 mc_latency_sclk, mc_latency_mclk, k1; fixed20_12 cur_latency_mclk, cur_latency_sclk; - fixed20_12 disp_latency, disp_latency_overhead, disp_drain_rate, + fixed20_12 disp_latency, disp_latency_overhead, disp_drain_rate = {0}, disp_drain_rate2, read_return_rate; fixed20_12 time_disp1_drop_priority; int c;