From patchwork Fri Jan 15 14:55:36 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 8042091 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id C747F9F859 for ; Fri, 15 Jan 2016 14:57:28 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 1166F20439 for ; Fri, 15 Jan 2016 14:57:28 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 1B2F620434 for ; Fri, 15 Jan 2016 14:57:27 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 547657A100; Fri, 15 Jan 2016 06:57:26 -0800 (PST) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yk0-f176.google.com (mail-yk0-f176.google.com [209.85.160.176]) by gabe.freedesktop.org (Postfix) with ESMTPS id BCAB07A0FF for ; Fri, 15 Jan 2016 06:57:24 -0800 (PST) Received: by mail-yk0-f176.google.com with SMTP id x67so546638134ykd.2 for ; Fri, 15 Jan 2016 06:57:24 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=OrB5f4ZZF4e1jK3XkmGU4OuFgIP5Oo5+srEHVJZUCco=; b=ARQWVSwC/hwCyAsxSpzf2Mh8iEvqFkAVEG2g9xhEk2bZ2B2rmP9JwqJKMzx7WsLEIJ UscKAfyfmE4WtU+J/qo/cr6vImv3k8m6yobEKc/gimIW28K7Ms9Wc5bBah8qbczIs8VL 7RSJ2tuMIxq8UHVphAXSmPZb9oq0e3dPk4hQ5sIuAUjyKCTljJnX4eLrwCxnw0tnRkKG +QEKUDjgADwXhpTXQqKrunsZzYhWIwvIpyn4Hm0QFLKO5ZlllB4YnyXgjbBKCJW6dNJt Bfg6BDxGDP4NN4PfYeqSrkjUULc1P+nWu1rkZQRV0fNhmcOlp6LLQufdvIO47EPMt9Oy ebQg== X-Gm-Message-State: ALoCoQlb6DfXtR7F8GuDitlujGH0k/uzq/T1X8/na4/JMQ4Ez2xqcD1ymWKp118TaZ7mIiGRk4UdbPRjAtuTS8s9KhkRpZs9gg== X-Received: by 10.129.154.82 with SMTP id r79mr8579801ywg.15.1452869844051; Fri, 15 Jan 2016 06:57:24 -0800 (PST) Received: from jade.localdomain ([2804:14c:487:41f:6257:18ff:feab:2e8f]) by smtp.gmail.com with ESMTPSA id o123sm8267717ywd.2.2016.01.15.06.57.20 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 15 Jan 2016 06:57:23 -0800 (PST) From: Gustavo Padovan To: Greg Kroah-Hartman Subject: [RFC 26/29] dma-buf/fence: remove pointless fence_timeline_signal at destroy phase Date: Fri, 15 Jan 2016 12:55:36 -0200 Message-Id: <1452869739-3304-27-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1452869739-3304-1-git-send-email-gustavo@padovan.org> References: <1452869739-3304-1-git-send-email-gustavo@padovan.org> Cc: devel@driverdev.osuosl.org, daniels@collabora.com, Daniel Vetter , Riley Andrews , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, =?UTF-8?q?Arve=20Hj=C3=B8nnev=C3=A5g?= , Maarten Lankhorst , Gustavo Padovan , John Harrison X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan All changes to timeline value come through the user via fence_timeline_signal() calls. When fence_timeline_destroy() is called no changes on timeline->value happens hence call fence_timeline_signal() with no increment is pointless. Signed-off-by: Gustavo Padovan --- drivers/dma-buf/fence.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/dma-buf/fence.c b/drivers/dma-buf/fence.c index 7a5fc9b..26f5f0f 100644 --- a/drivers/dma-buf/fence.c +++ b/drivers/dma-buf/fence.c @@ -136,7 +136,7 @@ EXPORT_SYMBOL(fence_timeline_put); * fence_timeline_destroy - destroy a fence_timeline * @timeline [in] the fence_timeline to destroy * - * This function destroys a timeline. It signals any active fence first. + * This function destroys a timeline. */ void fence_timeline_destroy(struct fence_timeline *timeline) { @@ -147,10 +147,6 @@ void fence_timeline_destroy(struct fence_timeline *timeline) */ smp_wmb(); - /* - * signal any children that their parent is going away. - */ - fence_timeline_signal(timeline, 0); fence_timeline_put(timeline); } EXPORT_SYMBOL(fence_timeline_destroy);