diff mbox

drm: Remove duplicate `const` qualifier

Message ID 1455031085-29612-1-git-send-email-eric.engestrom@imgtec.com (mailing list archive)
State New, archived
Headers show

Commit Message

Eric Engestrom Feb. 9, 2016, 3:18 p.m. UTC
Commit 1eb8345 added a bunch of legitimate `const`, but added two on that line.

Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
---
 drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Ville Syrjälä Feb. 9, 2016, 3:24 p.m. UTC | #1
On Tue, Feb 09, 2016 at 03:18:05PM +0000, Eric Engestrom wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on that line.

Already fixed
70c0616d5a84 ("drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc")

> 
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
>  };
>  
>  static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> -	const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> +	const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
>  	unsigned int num_planes)
>  {
>  	struct drm_fb_cma *fb_cma;
> -- 
> 2.7.1
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
Jani Nikula Feb. 9, 2016, 3:28 p.m. UTC | #2
On Tue, 09 Feb 2016, Eric Engestrom <eric.engestrom@imgtec.com> wrote:
> Commit 1eb8345 added a bunch of legitimate `const`, but added two on
> that line.

Too late, fixed in

commit 70c0616d5a8458ae9148d74309cede07ba2f5164
Author: Colin Ian King <colin.king@canonical.com>
Date:   Wed Jan 20 10:59:34 2016 +0000

    drm/fb_cma_helper: remove duplicate const from drm_fb_cma_alloc

BR,
Jani.


>
> Signed-off-by: Eric Engestrom <eric.engestrom@imgtec.com>
> ---
>  drivers/gpu/drm/drm_fb_cma_helper.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
> index c895b6f..c4309df 100644
> --- a/drivers/gpu/drm/drm_fb_cma_helper.c
> +++ b/drivers/gpu/drm/drm_fb_cma_helper.c
> @@ -74,7 +74,7 @@ static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
>  };
>  
>  static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
> -	const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
> +	const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
>  	unsigned int num_planes)
>  {
>  	struct drm_fb_cma *fb_cma;
diff mbox

Patch

diff --git a/drivers/gpu/drm/drm_fb_cma_helper.c b/drivers/gpu/drm/drm_fb_cma_helper.c
index c895b6f..c4309df 100644
--- a/drivers/gpu/drm/drm_fb_cma_helper.c
+++ b/drivers/gpu/drm/drm_fb_cma_helper.c
@@ -74,7 +74,7 @@  static struct drm_framebuffer_funcs drm_fb_cma_funcs = {
 };
 
 static struct drm_fb_cma *drm_fb_cma_alloc(struct drm_device *dev,
-	const const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
+	const struct drm_mode_fb_cmd2 *mode_cmd, struct drm_gem_cma_object **obj,
 	unsigned int num_planes)
 {
 	struct drm_fb_cma *fb_cma;