From patchwork Mon Mar 21 19:23:07 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gustavo Padovan X-Patchwork-Id: 8636051 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 0C35DC0553 for ; Mon, 21 Mar 2016 20:55:12 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 3B7AA202F8 for ; Mon, 21 Mar 2016 20:55:11 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 6E19320173 for ; Mon, 21 Mar 2016 20:55:10 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 96EAA6E710; Mon, 21 Mar 2016 20:51:36 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-yw0-f195.google.com (mail-yw0-f195.google.com [209.85.161.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id BDE286E060 for ; Mon, 21 Mar 2016 19:23:17 +0000 (UTC) Received: by mail-yw0-f195.google.com with SMTP id f6so19054806ywa.1 for ; Mon, 21 Mar 2016 12:23:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=jpYROaqUfHConKYtDGm89Bnn8ajNlzdxwALgnXW+sII=; b=bF8LhYPkXlusQmKl11YaNFjdFLVIOqNsClNvke5XEjsltLCtr0zWYRjXoKo9IK7+Ql Cm7zgmZrIcx3YTRpD7xtg8mJ8Gr2L+Y70Qi6dwNIXUYmKxnIZDHpVypM+HeXifYYWFiw D20PGYdCt53nNW7VlodMigRA0V6GAWSdZm24IHttpoBxb0zh2Goo7qzKqK7ZlCzBFVMQ /Pug/ToPwgsU9ZIH124ab5GQ6je5/535uk0N1n2uFOvxolfKV74AIiRKET63YL5vqL9j sCDmfhqDl9+s5CWJQ2XTroiiYDUPV5nISHmqzyryX6gWk9Dxnzq/BIAne28V/VNGq6uI ejbA== X-Gm-Message-State: AD7BkJKNDgA9UVDhWAk3ckVMl9RQ8iEFLIGM1w9E3QPnMfpKED+d+Ed/JPo5RIcf0qj0bg== X-Received: by 10.13.238.130 with SMTP id x124mr14421277ywe.166.1458588195725; Mon, 21 Mar 2016 12:23:15 -0700 (PDT) Received: from jade.localdomain ([177.194.47.65]) by smtp.gmail.com with ESMTPSA id t12sm18268078ywf.9.2016.03.21.12.23.13 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Mar 2016 12:23:15 -0700 (PDT) From: Gustavo Padovan To: Gerd Hoffmann Subject: [PATCH 2/2] drm/virtio: send vblank event on plane atomic update Date: Mon, 21 Mar 2016 16:23:07 -0300 Message-Id: <1458588187-26002-2-git-send-email-gustavo@padovan.org> X-Mailer: git-send-email 2.5.0 In-Reply-To: <1458588187-26002-1-git-send-email-gustavo@padovan.org> References: <1458588187-26002-1-git-send-email-gustavo@padovan.org> Cc: Gustavo Padovan , open list , "open list:VIRTIO GPU DRIVER" , "open list:VIRTIO GPU DRIVER" X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-4.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP From: Gustavo Padovan virtio_gpu was failing to send vblank events when using the atomic IOCTL with the DRM_MODE_PAGE_FLIP_EVENT flag set. This patch fixes each and enables atomic pageflips updates. Signed-off-by: Gustavo Padovan --- drivers/gpu/drm/virtio/virtgpu_plane.c | 9 ++++++++- 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/virtio/virtgpu_plane.c b/drivers/gpu/drm/virtio/virtgpu_plane.c index 70b44a2..20260ad 100644 --- a/drivers/gpu/drm/virtio/virtgpu_plane.c +++ b/drivers/gpu/drm/virtio/virtgpu_plane.c @@ -63,9 +63,11 @@ static void virtio_gpu_plane_atomic_update(struct drm_plane *plane, { struct drm_device *dev = plane->dev; struct virtio_gpu_device *vgdev = dev->dev_private; - struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(plane->crtc); + struct drm_crtc *crtc = plane->crtc; + struct virtio_gpu_output *output = drm_crtc_to_virtio_gpu_output(crtc); struct virtio_gpu_framebuffer *vgfb; struct virtio_gpu_object *bo; + unsigned long flags; uint32_t handle; if (plane->state->fb) { @@ -96,6 +98,11 @@ static void virtio_gpu_plane_atomic_update(struct drm_plane *plane, plane->state->crtc_y, plane->state->crtc_w, plane->state->crtc_h); + + spin_lock_irqsave(&crtc->dev->event_lock, flags); + if (crtc->state->event) + drm_crtc_send_vblank_event(crtc, crtc->state->event); + spin_unlock_irqrestore(&crtc->dev->event_lock, flags); }