From patchwork Wed Mar 30 09:40:47 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 8694391 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 1A6E49F44D for ; Wed, 30 Mar 2016 09:41:35 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 9CE3C20361 for ; Wed, 30 Mar 2016 09:41:29 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id C9F2B20364 for ; Wed, 30 Mar 2016 09:41:28 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id C6E956E732; Wed, 30 Mar 2016 09:41:09 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x22d.google.com (mail-wm0-x22d.google.com [IPv6:2a00:1450:400c:c09::22d]) by gabe.freedesktop.org (Postfix) with ESMTPS id E74DC6E741 for ; Wed, 30 Mar 2016 09:41:03 +0000 (UTC) Received: by mail-wm0-x22d.google.com with SMTP id 191so81977733wmq.0 for ; Wed, 30 Mar 2016 02:41:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=42QjrhCsklpgZyMOpodHuYU61Px++TivO8E7AgQP4Bw=; b=RqDzamIdwta9TKcdQ4RVs4y0GwFOa/GxlyLzbYg86hpJvXTPkSdNJRh9IAiBTe74Gh uuupG4avr5D0/4/Ozq2s+Jn5zI+4mIGCLIW8fJRWeu6Oa+JWxcFqrkkiqtwAecKTzRY8 emGZCkpW3pp/xmm1hIXm4tfy8vxac/cY4RzMs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=42QjrhCsklpgZyMOpodHuYU61Px++TivO8E7AgQP4Bw=; b=M73tHWMCAQInixdIp7eypDApD7tc95ySokOHdCLMBExVWsJA2wKV1UXAMmTxFOprBp yeOCgxSO9DVlJ7/iw0xDfQucHFQ2ByWZVBaXHwTzqrkBIyVr5o+2J7uB2KdXSmmq5upL R2kbgUfL00AXjIDOkQdWdfZJ0kmvAN8DwSVvVI2bke4eKTbTIrXv12Lhx56YgFo7qNUR Pr6dyAX+h/U3vRLZjqs/IQKXAGXugj4cj+SZ8P71G4uc2YdrxbpCJPEgxdd4wjSsVf7X Hb68ZjLFeA4wimlgCgI0ep71ZATjNEA91L5OmOzrqDeuCC+1aURDRsQIlTlGqZdHJWKX 90iQ== X-Gm-Message-State: AD7BkJId2yZQSHNYZ0WeMYffkXl09HZVMAKKWfhCAHGvfnr0Q7N71hq2Sgu6mRqFGFSdlQ== X-Received: by 10.28.177.132 with SMTP id a126mr20948567wmf.86.1459330861449; Wed, 30 Mar 2016 02:41:01 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id v2sm3476437wmd.24.2016.03.30.02.41.00 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Mar 2016 02:41:00 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 08/13] drm/exynos: drop struct_mutex from exynos_drm_gem_get_ioctl Date: Wed, 30 Mar 2016 11:40:47 +0200 Message-Id: <1459330852-27668-9-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> References: <1459330852-27668-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP The only things this protects is reading ->flags and ->size, both of which are invariant over the lifetime of an exynos gem bo. So no locking needed at all (besides that, nothing protects the writers anyway). Aside: exynos_gem_obj->size is redundant with exynos_gem_obj->base.size and probably should be removed. v2: Use _unlocked unreference (Daniel Stone). Cc: Daniel Stone Cc: Inki Dae Signed-off-by: Daniel Vetter --- drivers/gpu/drm/exynos/exynos_drm_gem.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/drivers/gpu/drm/exynos/exynos_drm_gem.c b/drivers/gpu/drm/exynos/exynos_drm_gem.c index 60b9975bb0b1..6fb98f4c3544 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_gem.c +++ b/drivers/gpu/drm/exynos/exynos_drm_gem.c @@ -362,12 +362,9 @@ int exynos_drm_gem_get_ioctl(struct drm_device *dev, void *data, struct drm_exynos_gem_info *args = data; struct drm_gem_object *obj; - mutex_lock(&dev->struct_mutex); - obj = drm_gem_object_lookup(dev, file_priv, args->handle); if (!obj) { DRM_ERROR("failed to lookup gem object.\n"); - mutex_unlock(&dev->struct_mutex); return -EINVAL; } @@ -376,8 +373,7 @@ int exynos_drm_gem_get_ioctl(struct drm_device *dev, void *data, args->flags = exynos_gem->flags; args->size = exynos_gem->size; - drm_gem_object_unreference(obj); - mutex_unlock(&dev->struct_mutex); + drm_gem_object_unreference_unlocked(obj); return 0; }