From patchwork Wed Mar 30 09:45:13 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 8694581 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 0E1AF9F44D for ; Wed, 30 Mar 2016 09:46:13 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4153F20148 for ; Wed, 30 Mar 2016 09:46:12 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 5807E20376 for ; Wed, 30 Mar 2016 09:46:11 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 1708E6E757; Wed, 30 Mar 2016 09:45:54 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x235.google.com (mail-wm0-x235.google.com [IPv6:2a00:1450:400c:c09::235]) by gabe.freedesktop.org (Postfix) with ESMTPS id E20506E748 for ; Wed, 30 Mar 2016 09:45:25 +0000 (UTC) Received: by mail-wm0-x235.google.com with SMTP id p65so63167877wmp.0 for ; Wed, 30 Mar 2016 02:45:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=3620EVum1bmotVLg4pKnWTN5hT2hlAXxxpOTYBG8DO4=; b=larC/dOro/OjBQ/OJjqgkKKjRwUA9viZfHfWkwGriOpKKaLrfP0ylRILRl15rgM4iq 43MVlzPHxLncdMgHKzVqud/mB2nguK8qNfhcyp0Z0rQxzVS5GyqJWOGBoBTPxGL3J0oi nkwUU/ekombINra33HHb8/2bwOcE825fSFOJ8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=3620EVum1bmotVLg4pKnWTN5hT2hlAXxxpOTYBG8DO4=; b=fAqPuMbibIGZi+0x7s24pbgv3QQQu6YejQTAoLQ37PiUYqJC8hMtIykSfjDd1AnSPO 2/31ZjmxUjwvr6usSYlON5QQAJSTswPu+Py5U1TorqDoL0gF718vRjq6stk8bydVxjm8 7OwdjsTlhhJH6a/3OrNSULUbTREDyb5kOZWSxGQ3+EDOanncvI+shQQDlK3is+6E9WMW NN5EGVlwymgenXcfrmLlk3J7Rhpa6dDGKZPZTGF5Q8k9t9zCXSFTMgjyGYFxOub8IJ8T C8Tm7QLuccJMLdg4SDkWNBHgDM8n0p4KS567lKjSvmT6YKYWQT8axD3bbGdhSNgrGV1D wi4A== X-Gm-Message-State: AD7BkJJXJTTVHlPHi9pCdgMYM6G5x1BAYgxniVqixTBtAdRU8UhZu2ocxYgVgVrnJyGKSg== X-Received: by 10.194.185.237 with SMTP id ff13mr8972671wjc.129.1459331123860; Wed, 30 Mar 2016 02:45:23 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id m130sm1905493wmf.10.2016.03.30.02.45.22 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 30 Mar 2016 02:45:23 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 03/10] drm/sysfs: Annote lockless show functions with READ_ONCE Date: Wed, 30 Mar 2016 11:45:13 +0200 Message-Id: <1459331120-27864-4-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.8.0.rc3 In-Reply-To: <1459331120-27864-1-git-send-email-daniel.vetter@ffwll.ch> References: <1459331120-27864-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Intel Graphics Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP For documentation and paranoia. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_sysfs.c | 11 ++++++++--- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_sysfs.c b/drivers/gpu/drm/drm_sysfs.c index d503f8e8c2d1..43875cb35691 100644 --- a/drivers/gpu/drm/drm_sysfs.c +++ b/drivers/gpu/drm/drm_sysfs.c @@ -208,9 +208,12 @@ static ssize_t status_show(struct device *device, char *buf) { struct drm_connector *connector = to_drm_connector(device); + enum drm_connector_status status; + + status = READ_ONCE(connector->status); return snprintf(buf, PAGE_SIZE, "%s\n", - drm_get_connector_status_name(connector->status)); + drm_get_connector_status_name(status)); } static ssize_t dpms_show(struct device *device, @@ -231,9 +234,11 @@ static ssize_t enabled_show(struct device *device, char *buf) { struct drm_connector *connector = to_drm_connector(device); + bool enabled; + + enabled = READ_ONCE(connector->encoder); - return snprintf(buf, PAGE_SIZE, "%s\n", connector->encoder ? "enabled" : - "disabled"); + return snprintf(buf, PAGE_SIZE, enabled ? "enabled\n" : "disabled\n"); } static ssize_t edid_show(struct file *filp, struct kobject *kobj,