| Message ID | 1459346623-30752-1-git-send-email-jani.nikula@intel.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On 03/30/2016 04:03 PM, Jani Nikula wrote: > From: Deepak M <m.deepak@intel.com> > > Adding new DCS commands which are specified in the > DCS 1.3 spec related to CABC. > > v2: Sorted the Macro`s by value (Andrzej) > > v3 by Jani: sort all of enum, refer to MIPI DCS 1.3 > > Cc: Andrzej Hajda <a.hajda@samsung.com> > Cc: Thierry Reding <thierry.reding@gmail.com> > Cc: David Airlie <airlied@linux.ie> > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > Cc: Daniel Vetter <daniel.vetter@intel.com> > Cc: <dri-devel@lists.freedesktop.org> > Suggested-by: Jani Nikula <jani.nikula@intel.com> > Signed-off-by: Deepak M <m.deepak@intel.com> > Signed-off-by: Jani Nikula <jani.nikula@intel.com> DCS 1.3 introduces also: get_error_count_on_DSI 05h get_image_checksum_ct 15h get_image_checksum_rgb 14h read_PPS_continue a9h read_PPS_start A2h It would be good to add them, but as the patch says it adds only CABC related commands so no big deal. Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Regards Andrzej > --- > include/video/mipi_display.h | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h > index ddcc8ca7316b..19aa65a35546 100644 > --- a/include/video/mipi_display.h > +++ b/include/video/mipi_display.h > @@ -115,6 +115,14 @@ enum { > MIPI_DCS_READ_MEMORY_CONTINUE = 0x3E, > MIPI_DCS_SET_TEAR_SCANLINE = 0x44, > MIPI_DCS_GET_SCANLINE = 0x45, > + MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51, /* MIPI DCS 1.3 */ > + MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52, /* MIPI DCS 1.3 */ > + MIPI_DCS_WRITE_CONTROL_DISPLAY = 0x53, /* MIPI DCS 1.3 */ > + MIPI_DCS_GET_CONTROL_DISPLAY = 0x54, /* MIPI DCS 1.3 */ > + MIPI_DCS_WRITE_POWER_SAVE = 0x55, /* MIPI DCS 1.3 */ > + MIPI_DCS_GET_POWER_SAVE = 0x56, /* MIPI DCS 1.3 */ > + MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E, /* MIPI DCS 1.3 */ > + MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F, /* MIPI DCS 1.3 */ > MIPI_DCS_READ_DDB_START = 0xA1, > MIPI_DCS_READ_DDB_CONTINUE = 0xA8, > };
On Thu, Mar 31, 2016 at 07:54:18AM +0200, Andrzej Hajda wrote: > On 03/30/2016 04:03 PM, Jani Nikula wrote: > > From: Deepak M <m.deepak@intel.com> > > > > Adding new DCS commands which are specified in the > > DCS 1.3 spec related to CABC. > > > > v2: Sorted the Macro`s by value (Andrzej) > > > > v3 by Jani: sort all of enum, refer to MIPI DCS 1.3 > > > > Cc: Andrzej Hajda <a.hajda@samsung.com> > > Cc: Thierry Reding <thierry.reding@gmail.com> > > Cc: David Airlie <airlied@linux.ie> > > Cc: Ville Syrjälä <ville.syrjala@linux.intel.com> > > Cc: Daniel Vetter <daniel.vetter@intel.com> > > Cc: <dri-devel@lists.freedesktop.org> > > Suggested-by: Jani Nikula <jani.nikula@intel.com> > > Signed-off-by: Deepak M <m.deepak@intel.com> > > Signed-off-by: Jani Nikula <jani.nikula@intel.com> > > DCS 1.3 introduces also: > get_error_count_on_DSI 05h > get_image_checksum_ct 15h > get_image_checksum_rgb 14h > read_PPS_continue a9h > read_PPS_start A2h > > It would be good to add them, but as the patch > says it adds only CABC related commands so no big deal. > > Reviewed-by: Andrzej Hajda <a.hajda@samsung.com> Applied to drm-misc, thanks. -Daniel > > Regards > Andrzej > > > --- > > include/video/mipi_display.h | 8 ++++++++ > > 1 file changed, 8 insertions(+) > > > > diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h > > index ddcc8ca7316b..19aa65a35546 100644 > > --- a/include/video/mipi_display.h > > +++ b/include/video/mipi_display.h > > @@ -115,6 +115,14 @@ enum { > > MIPI_DCS_READ_MEMORY_CONTINUE = 0x3E, > > MIPI_DCS_SET_TEAR_SCANLINE = 0x44, > > MIPI_DCS_GET_SCANLINE = 0x45, > > + MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51, /* MIPI DCS 1.3 */ > > + MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52, /* MIPI DCS 1.3 */ > > + MIPI_DCS_WRITE_CONTROL_DISPLAY = 0x53, /* MIPI DCS 1.3 */ > > + MIPI_DCS_GET_CONTROL_DISPLAY = 0x54, /* MIPI DCS 1.3 */ > > + MIPI_DCS_WRITE_POWER_SAVE = 0x55, /* MIPI DCS 1.3 */ > > + MIPI_DCS_GET_POWER_SAVE = 0x56, /* MIPI DCS 1.3 */ > > + MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E, /* MIPI DCS 1.3 */ > > + MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F, /* MIPI DCS 1.3 */ > > MIPI_DCS_READ_DDB_START = 0xA1, > > MIPI_DCS_READ_DDB_CONTINUE = 0xA8, > > }; > > _______________________________________________ > Intel-gfx mailing list > Intel-gfx@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/intel-gfx
diff --git a/include/video/mipi_display.h b/include/video/mipi_display.h index ddcc8ca7316b..19aa65a35546 100644 --- a/include/video/mipi_display.h +++ b/include/video/mipi_display.h @@ -115,6 +115,14 @@ enum { MIPI_DCS_READ_MEMORY_CONTINUE = 0x3E, MIPI_DCS_SET_TEAR_SCANLINE = 0x44, MIPI_DCS_GET_SCANLINE = 0x45, + MIPI_DCS_SET_DISPLAY_BRIGHTNESS = 0x51, /* MIPI DCS 1.3 */ + MIPI_DCS_GET_DISPLAY_BRIGHTNESS = 0x52, /* MIPI DCS 1.3 */ + MIPI_DCS_WRITE_CONTROL_DISPLAY = 0x53, /* MIPI DCS 1.3 */ + MIPI_DCS_GET_CONTROL_DISPLAY = 0x54, /* MIPI DCS 1.3 */ + MIPI_DCS_WRITE_POWER_SAVE = 0x55, /* MIPI DCS 1.3 */ + MIPI_DCS_GET_POWER_SAVE = 0x56, /* MIPI DCS 1.3 */ + MIPI_DCS_SET_CABC_MIN_BRIGHTNESS = 0x5E, /* MIPI DCS 1.3 */ + MIPI_DCS_GET_CABC_MIN_BRIGHTNESS = 0x5F, /* MIPI DCS 1.3 */ MIPI_DCS_READ_DDB_START = 0xA1, MIPI_DCS_READ_DDB_CONTINUE = 0xA8, };