From patchwork Thu Apr 14 20:10:27 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: =?utf-8?q?Moritz_K=C3=BChner?= X-Patchwork-Id: 8843891 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork1.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork1.web.kernel.org (Postfix) with ESMTP id 16E959F54F for ; Fri, 15 Apr 2016 00:23:38 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 4158E20373 for ; Fri, 15 Apr 2016 00:23:37 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 58FE62034A for ; Fri, 15 Apr 2016 00:23:36 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 769AD6EB50; Fri, 15 Apr 2016 00:23:33 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 939816EB06 for ; Thu, 14 Apr 2016 20:11:04 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id a140so788371wma.2 for ; Thu, 14 Apr 2016 13:11:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=vFOczZBcK4nVG2enZT4RdrKuoour+0qAK700RwMaM0Y=; b=VawspXnTUpHXfbCtcqMXC9MxXFumXxR43sg0cfqwgkRO7kjaFzXZtpB4jc2nZCAYib k40Z6ttsZAXKJOmTWvUcr3DbJAiKaM54rfHTY56e3zTpmOOCDfu42VYQv0m53VIpg1yC 5rlG3Il4yG26el4rmvIqYZjZEMJo0HVsBjxGSw7SIS2h3p1F+uSUpQ/DMXBON/sAVaDg 6itW2qGYu2FYxEOZ7K31LDOyh0plhb4cccp3AvZlxAzgYnejuDm+ddzBLBTR5V/tnabm e4gug+jDETq7Rn6OUqW3lDRJeXwN4fQtYw3bnf0Qv4L1Tup0ENYNKu7lmGFcVBVkTTze HwsA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=vFOczZBcK4nVG2enZT4RdrKuoour+0qAK700RwMaM0Y=; b=BZC00ztUuLwtkVtvvPt2nkFL7xv34t7zVDHu/9dZ9/5xV/C70AKV1smtkgxfINily/ FySvC9jUGpoSP2Z6ltLlM5zcFA6DTGtDem0AzJQZS0pRzeiZPal0rgQuv4SWWMIFrma2 a3zKLCDM54yq2glMqBtOKi9sfi6RXmi0LVboHBogGeMuiIKJGCr5wUs4LUAkyl00HQ4g XzdJcqcj0lvwaTtkCzif0rCu+YadaJeKUJn4+grlnZKSFMAKc/ebBbck+V4SKGxiPYQh 8m/7PSFZ4ceTIBibcfAH+l93Zvj+wvmpFNwLnqP5B3/92FG7dHd1Bu9XuSpGC6R05xUG o6Hg== X-Gm-Message-State: AOPr4FVxwlbC3gT3lYtn3NEsQ4VCoKvAweBMDV3Kx5x1/gD8H24W+ke9lWW0sUXdzpU5yw== X-Received: by 10.194.105.42 with SMTP id gj10mr18155068wjb.49.1460664663236; Thu, 14 Apr 2016 13:11:03 -0700 (PDT) Received: from max-Pc.local (HSI-KBW-091-089-090-118.hsi2.kabelbw.de. [91.89.90.118]) by smtp.gmail.com with ESMTPSA id k139sm8134653wmg.24.2016.04.14.13.11.02 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 14 Apr 2016 13:11:02 -0700 (PDT) From: =?UTF-8?q?Moritz=20K=C3=BChner?= To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/2] drm/amd/powerplay/hwmgr: prevent VDDC from exceeding 2V Date: Thu, 14 Apr 2016 22:10:27 +0200 Message-Id: <1460664628-14623-2-git-send-email-kuehner.moritz@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1460664628-14623-1-git-send-email-kuehner.moritz@gmail.com> References: <1460664628-14623-1-git-send-email-kuehner.moritz@gmail.com> X-Mailman-Approved-At: Fri, 15 Apr 2016 00:23:33 +0000 Cc: alexander.deucher@amd.com, =?UTF-8?q?Moritz=20K=C3=BChner?= X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the tonga gpu is controlled by SVID2 tonga_get_evv_voltage will only print an error if the voltage exceeds 2V although a comment clearly states that it needs be less than 2V. --- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c index 0d5d837..50afb02 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c @@ -455,8 +455,7 @@ int tonga_get_evv_voltage(struct pp_hwmgr *hwmgr) "Error retrieving EVV voltage value!", continue); /* need to make sure vddc is less than 2v or else, it could burn the ASIC. */ - if (vddc > 2000) - printk(KERN_ERR "[ powerplay ] Invalid VDDC value! \n"); + PP_ASSERT_WITH_CODE(vddc < 2000, "Invalid VDDC value!", return -1); /* the voltage should not be zero nor equal to leakage ID */ if (vddc != 0 && vddc != virtual_voltage_id) {