diff mbox

[15/15] drm/radeon/dp_mst: use connector ref counting

Message ID 1460697046-23781-16-git-send-email-airlied@gmail.com (mailing list archive)
State New, archived
Headers show

Commit Message

Dave Airlie April 15, 2016, 5:10 a.m. UTC 
From: Dave Airlie <airlied@redhat.com>

Use connector reference counting in radeon mst code.

Signed-off-by: Dave Airlie <airlied@redhat.com>
---
 drivers/gpu/drm/radeon/radeon_dp_mst.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

Comments

Daniel Vetter April 22, 2016, 9:04 a.m. UTC | #1 
On Fri, Apr 15, 2016 at 03:10:46PM +1000, Dave Airlie wrote:
> From: Dave Airlie <airlied@redhat.com>
> 
> Use connector reference counting in radeon mst code.
> 
> Signed-off-by: Dave Airlie <airlied@redhat.com>
> ---
>  drivers/gpu/drm/radeon/radeon_dp_mst.c | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> index 43cffb5..4f1792a 100644
> --- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
> +++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
> @@ -242,6 +242,7 @@ radeon_dp_mst_connector_destroy(struct drm_connector *connector)
>  
>  	drm_encoder_cleanup(&radeon_encoder->base);
>  	kfree(radeon_encoder);
> +
>  	drm_connector_cleanup(connector);
>  	kfree(radeon_connector);
>  }
> @@ -313,11 +314,9 @@ static void radeon_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
>  	drm_modeset_lock_all(dev);
>  	/* dpms off */
>  	radeon_fb_remove_connector(rdev, connector);

Why not drop the force-off here, like for i915?
-Daniel

> -
> -	drm_connector_cleanup(connector);
>  	drm_modeset_unlock_all(dev);
>  
> -	kfree(connector);
> +	drm_connector_unreference(connector);
>  	DRM_DEBUG_KMS("\n");
>  }
>  
> -- 
> 2.5.5
> 
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
diff mbox

Patch

diff --git a/drivers/gpu/drm/radeon/radeon_dp_mst.c b/drivers/gpu/drm/radeon/radeon_dp_mst.c
index 43cffb5..4f1792a 100644
--- a/drivers/gpu/drm/radeon/radeon_dp_mst.c
+++ b/drivers/gpu/drm/radeon/radeon_dp_mst.c
@@ -242,6 +242,7 @@  radeon_dp_mst_connector_destroy(struct drm_connector *connector)
 
 	drm_encoder_cleanup(&radeon_encoder->base);
 	kfree(radeon_encoder);
+
 	drm_connector_cleanup(connector);
 	kfree(radeon_connector);
 }
@@ -313,11 +314,9 @@  static void radeon_dp_destroy_mst_connector(struct drm_dp_mst_topology_mgr *mgr,
 	drm_modeset_lock_all(dev);
 	/* dpms off */
 	radeon_fb_remove_connector(rdev, connector);
-
-	drm_connector_cleanup(connector);
 	drm_modeset_unlock_all(dev);
 
-	kfree(connector);
+	drm_connector_unreference(connector);
 	DRM_DEBUG_KMS("\n");
 }