From patchwork Sun Apr 17 14:15:23 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: =?utf-8?q?Moritz_K=C3=BChner?= X-Patchwork-Id: 8864121 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 8F5D8BF29F for ; Mon, 18 Apr 2016 00:55:57 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id B3B22201E4 for ; Mon, 18 Apr 2016 00:55:56 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id DC132201CD for ; Mon, 18 Apr 2016 00:55:55 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 54F2A6E01F; Mon, 18 Apr 2016 00:55:50 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x242.google.com (mail-wm0-x242.google.com [IPv6:2a00:1450:400c:c09::242]) by gabe.freedesktop.org (Postfix) with ESMTPS id 442FC6E334 for ; Sun, 17 Apr 2016 14:15:37 +0000 (UTC) Received: by mail-wm0-x242.google.com with SMTP id l6so17857357wml.3 for ; Sun, 17 Apr 2016 07:15:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=PUrJNEf2BOU7reZgcCy3Bmp/z6Jj4h4tsXziKicktMs=; b=ikTLerIDffRCSc+YcimoMx2pWNjxm5/Jxk58JAJtmjMwVYjRGp3mGqNt/dQIaisRFy cMbV1WVPyf7V8twEj3fmMr2JwXrG6Wi8eplK4IqJMy4Xe33LQaqkg3/KM0LzsTLzI7/p FTKSb9tHOm+7+pMCx4X5c+KgR8aJ5oKRTiRcJkUxT0pldvG6UQp/ik407BZA06jMUJ5p yO4qkqzdn/lOiUIAd4o5dRvbHYhE2r90objbMP8dHsYdG+CGS6Ht8YdBxl+15imSnuzE uSxuGzCBaRKbEXKgzq5uJwNSyaYn9TULeO1+nsBxEowtPaxDTZTxJJvPTi/oG7Ws+vXd x5YA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=PUrJNEf2BOU7reZgcCy3Bmp/z6Jj4h4tsXziKicktMs=; b=Aj27w5Of/zCEgMfUQKGPBdy2ZpvFMyV9DlsAVsuoy4Q0enqnzcQgg+Yzqmvfihlwz+ EYw7P0EQ6Mm8RqLfmePx1UbU3YpztHJOW4z8dr33SUMI8jfICq5FW2+s/Wg+0Kwwfp2l 0hbIAxtUNywtpto1l35kcoIL3a0M6Hzz5P/yUphTpSiiKaefS4MMODrlF2l+Xhk99dLd uGTPASEa22bkQt/Mny+TizpJ64gJdYNHEG3rfZyT88CCyWQwzFePewRQFFLYAbruZxi8 Ll82u7244AYpVyJ3Ew61ZsAZfT7P+LgKskqoPooZbCLsbjBm//lqPKe1O/5xEXmu0Jul nM+g== X-Gm-Message-State: AOPr4FVwNm1BJCWotr+UnFibV/oqTzBo9cCYgezt9r1NyCv9Z7PISYqdUMNqZUEMhy1u8A== X-Received: by 10.28.17.211 with SMTP id 202mr5038777wmr.11.1460902535724; Sun, 17 Apr 2016 07:15:35 -0700 (PDT) Received: from max-Pc.local (HSI-KBW-091-089-090-118.hsi2.kabelbw.de. [91.89.90.118]) by smtp.gmail.com with ESMTPSA id o1sm52641732wjm.11.2016.04.17.07.15.34 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Sun, 17 Apr 2016 07:15:34 -0700 (PDT) From: =?UTF-8?q?Moritz=20K=C3=BChner?= To: dri-devel@lists.freedesktop.org Subject: [PATCH 1/2 v2] drm/amd/powerplay/hwmgr: prevent VDDC from exceeding 2V Date: Sun, 17 Apr 2016 16:15:23 +0200 Message-Id: <1460902524-12866-2-git-send-email-kuehner.moritz@gmail.com> X-Mailer: git-send-email 2.7.4 In-Reply-To: <1460902524-12866-1-git-send-email-kuehner.moritz@gmail.com> References: <1460902524-12866-1-git-send-email-kuehner.moritz@gmail.com> MIME-Version: 1.0 X-Mailman-Approved-At: Mon, 18 Apr 2016 00:55:49 +0000 Cc: alexander.deucher@amd.com, =?UTF-8?q?Moritz=20K=C3=BChner?= , christian.koenig@amd.com X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, T_DKIM_INVALID, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP If the tonga gpu is controlled by SVID2 tonga_get_evv_voltage will only print an error if the voltage exceeds 2V although a comment clearly states that it needs be less than 2V. v2: added signed of by Signed-off-by: Moritz Kühner --- drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c index 0d5d837..50afb02 100644 --- a/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/tonga_hwmgr.c @@ -455,8 +455,7 @@ int tonga_get_evv_voltage(struct pp_hwmgr *hwmgr) "Error retrieving EVV voltage value!", continue); /* need to make sure vddc is less than 2v or else, it could burn the ASIC. */ - if (vddc > 2000) - printk(KERN_ERR "[ powerplay ] Invalid VDDC value! \n"); + PP_ASSERT_WITH_CODE(vddc < 2000, "Invalid VDDC value!", return -1); /* the voltage should not be zero nor equal to leakage ID */ if (vddc != 0 && vddc != virtual_voltage_id) {