From patchwork Tue Apr 19 17:40:38 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ezequiel Garcia X-Patchwork-Id: 8882371 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id CA797BF29F for ; Tue, 19 Apr 2016 17:41:05 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 008C6202E9 for ; Tue, 19 Apr 2016 17:41:05 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 2D47E202D1 for ; Tue, 19 Apr 2016 17:41:04 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 0643A6E801; Tue, 19 Apr 2016 17:41:03 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qg0-x232.google.com (mail-qg0-x232.google.com [IPv6:2607:f8b0:400d:c04::232]) by gabe.freedesktop.org (Postfix) with ESMTPS id A47C16E800 for ; Tue, 19 Apr 2016 17:40:58 +0000 (UTC) Received: by mail-qg0-x232.google.com with SMTP id c6so13469417qga.1 for ; Tue, 19 Apr 2016 10:40:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=vanguardiasur-com-ar.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=apRkZa9VHEKtMvnogIJ2JRWM8KiR08ZVpuCxVREdUUc=; b=CYkvMV5ktj1kVnbZmaufzUok6GVbD0nFUCvTjC8zewmpyf25W9RME1Wmul5RbiTBs7 athkikLIBezXfg30WYMK5/aZ/7ponxbDgv+hE6UG1P+ZA8TaNQXYVEEHr0yfqB+n0Aui bK2WRHvG/o6J84j13po924nB36swD6Px/P9oMpBpbd4f2D1SruUO6n+9HOltQLE+pDwx n7/r191XjIT7mt9THInpkyFFLaKZbKINssE0fEgLy5c6QGEhwZrdJG+L42cwAicbTrYm JA6cQ+f8KyuUEAhScqYbz6KLB13EtYdy704sgwPKdRjhQF3PPHMOyK4qbjy8oHm//Sdf SeeA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=apRkZa9VHEKtMvnogIJ2JRWM8KiR08ZVpuCxVREdUUc=; b=aEuTSb0hQIEPiLm6SOWFGPc5A+zguksyOPmaHeI7n2HjHyxj5QmTWEs4Y54ypUOybQ RpHLZQ/X+48YPhVPsiDOPC1IXsb6VOsyMpZsULveOGqIAKZtRAi8nGqS/pGvHgfj9CSA qNP8P4NPB3JWcPqZEx0lxtYf5b/MuHWGeMDZZQrDVu9XcdyeMRH6/dXL93nz7UeRSJTa C86d8+esm/6IAfPR8rX54b3xMi6dWC8U11LVNjCOf7JkHtKay2updaheevRE/ZaEMcGo RR5x/cK5M2HVFVOKhWQ7W/ZSMIL+7Mw4ZrdMfOdrEHS1laa/NjpCJGtK6piIZb9Uzic1 SeHQ== X-Gm-Message-State: AOPr4FVbghA9fmi1X+u9euhDjVMalZg+2LG8ZXWSltk3XYJQMrAHGG9Z/kIzeJZtfeO57g== X-Received: by 10.140.164.71 with SMTP id k68mr5495489qhk.97.1461087657468; Tue, 19 Apr 2016 10:40:57 -0700 (PDT) Received: from localhost.localdomain ([190.2.108.156]) by smtp.gmail.com with ESMTPSA id o24sm14389035qko.32.2016.04.19.10.40.55 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Tue, 19 Apr 2016 10:40:56 -0700 (PDT) From: Ezequiel Garcia To: dri-devel@lists.freedesktop.org Subject: [PATCH] drm: Make drm.debug parameter description more helpful Date: Tue, 19 Apr 2016 14:40:38 -0300 Message-Id: <1461087638-16959-2-git-send-email-ezequiel@vanguardiasur.com.ar> X-Mailer: git-send-email 2.7.0 In-Reply-To: <1461087638-16959-1-git-send-email-ezequiel@vanguardiasur.com.ar> References: <1461087638-16959-1-git-send-email-ezequiel@vanguardiasur.com.ar> Cc: Ezequiel Garcia X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Let's be user-friendly and print an actually helpful parameter description. Signed-off-by: Ezequiel Garcia --- drivers/gpu/drm/drm_drv.c | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/drm/drm_drv.c index 167c8d3d4a31..49b658069b51 100644 --- a/drivers/gpu/drm/drm_drv.c +++ b/drivers/gpu/drm/drm_drv.c @@ -37,15 +37,24 @@ #include "drm_legacy.h" #include "drm_internal.h" -unsigned int drm_debug = 0; /* bitmask of DRM_UT_x */ +/* + * drm_debug: Enable debug output. + * Bitmask of DRM_UT_x. See include/drm/drmP.h for details. + */ +unsigned int drm_debug = 0; EXPORT_SYMBOL(drm_debug); MODULE_AUTHOR(CORE_AUTHOR); MODULE_DESCRIPTION(CORE_DESC); MODULE_LICENSE("GPL and additional rights"); -MODULE_PARM_DESC(debug, "Enable debug output"); +MODULE_PARM_DESC(debug, "Enables debug output, where each bit enables a debug category.\n" +"Bit 0 (0x1) will enable CORE messages (drm core code)\n" +"Bit 1 (0x2) will enable DRIVER messages (drm controller code)\n" +"Bit 2 (0x4) will enable KMS messages (modesetting code)\n" +"Bit 3 (0x8) will enable PRMIE messages (prime code)\n"); module_param_named(debug, drm_debug, int, 0600); + static DEFINE_SPINLOCK(drm_minor_lock); static struct idr drm_minors_idr;