From patchwork Fri Apr 22 20:04:15 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 8915461 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 2A653BF29F for ; Fri, 22 Apr 2016 20:04:32 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 40C9420221 for ; Fri, 22 Apr 2016 20:04:31 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 60A8120138 for ; Fri, 22 Apr 2016 20:04:30 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id D434B6EECC; Fri, 22 Apr 2016 20:04:28 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x231.google.com (mail-wm0-x231.google.com [IPv6:2a00:1450:400c:c09::231]) by gabe.freedesktop.org (Postfix) with ESMTPS id 538EC6E35B for ; Fri, 22 Apr 2016 20:04:27 +0000 (UTC) Received: by mail-wm0-x231.google.com with SMTP id u206so42342672wme.1 for ; Fri, 22 Apr 2016 13:04:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id; bh=qwN7TWSOWZDUEdDyaqR81OGWN/a6OMfhK9M2zgDX61U=; b=CAZHwdV6lx3Uem5F/ySV3AKs/jN6AbOHa2xc+pbr75uIRYq6U7RJPR2s1BpXVwdUWH gUqkwzgkIT6tmC4fKEvk/gKFFBuofaBitGjAQYIF5wcuRw3ZxaXwf6cPcwK5kXHdSR6V RSaYmjPaCNaK+Gx/a+jf8IPFJqqzp0KsFsby0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=qwN7TWSOWZDUEdDyaqR81OGWN/a6OMfhK9M2zgDX61U=; b=FIfpgFiNzlshllpg6WTk5lgcC1qyBj9KLa/5NqmQCQJXfzX0rQq7TfaCu6Y8T2hZUH PViDI7sucKUrbZHwIwVZHYm704klO68nUa2YPEdeFzOBXdaVqJldmX3iFbpcYygTe8kh ns8rBTKQ8CFVEx+4JZ5dtZgfjpXAotdqwB8yL0B6iAJculIrI4R7NWkds6bnlogAKyKT IiOOdCoxZy7kgPne0VsjbkwD2IHAYreqVNVZxgJW2ng4G5sP2kBCTw7YfeBsU0H9V4v6 piiY5ydK04DktwUvwyiJk9CHo0UUlGZR2y7lw9VGDbWe3gkAhKs954Hxqj4IvAEvi2Pa f8Gg== X-Gm-Message-State: AOPr4FX4badd+Dn+YvOQHcHpateECHvga1SbIE+u33PKhAUDc1cSEdGGIj0wkHJpYv34pA== X-Received: by 10.194.69.106 with SMTP id d10mr22338418wju.165.1461355465685; Fri, 22 Apr 2016 13:04:25 -0700 (PDT) Received: from wespe.ffwll.local ([2a02:168:56b5:0:6631:50ff:fe8d:fd2e]) by smtp.gmail.com with ESMTPSA id m140sm3052320wma.24.2016.04.22.13.04.24 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 22 Apr 2016 13:04:24 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH i-g-t 1/2] tests/kms_addfb_basic: Add invalid tests to set fb props Date: Fri, 22 Apr 2016 22:04:15 +0200 Message-Id: <1461355456-21005-1-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.5.0 Cc: Daniel Vetter X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,RP_MATCHES_RCVD,T_DKIM_INVALID,UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP There's no properties on fb modeset objects, bug bugs in the kernel when trying to use those ioctls in such an invalid way. Cc: Dave Airlie Signed-off-by: Daniel Vetter --- tests/kms_addfb_basic.c | 66 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 66 insertions(+) diff --git a/tests/kms_addfb_basic.c b/tests/kms_addfb_basic.c index 64047303dea7..de77b3cd907d 100644 --- a/tests/kms_addfb_basic.c +++ b/tests/kms_addfb_basic.c @@ -477,6 +477,70 @@ static void addfb25_ytile(int fd) } } +static void prop_tests(int fd) +{ + struct drm_mode_fb_cmd2 f = {}; + struct drm_mode_obj_get_properties get_props = {}; + struct drm_mode_obj_set_property set_prop = {}; + uint64_t prop, prop_val; + + f.width = 1024; + f.height = 1024; + f.pixel_format = DRM_FORMAT_XRGB8888; + f.pitches[0] = 1024*4; + + igt_fixture { + gem_bo = igt_create_bo_with_dimensions(fd, 1024, 1024, + DRM_FORMAT_XRGB8888, 0, 0, NULL, NULL, NULL); + igt_assert(gem_bo); + + f.handles[0] = gem_bo; + + igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_ADDFB2, &f) == 0); + } + + get_props.props_ptr = (uintptr_t) ∝ + get_props.prop_values_ptr = (uintptr_t) &prop_val; + get_props.count_props = 1; + get_props.obj_id = f.fb_id; + + igt_subtest("invalid-get-prop-any") { + get_props.obj_type = 0; /* DRM_MODE_OBJECT_ANY */ + + igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_OBJ_GETPROPERTIES, + &get_props) == -1 && errno == EINVAL); + } + + igt_subtest("invalid-get-prop") { + get_props.obj_type = DRM_MODE_OBJECT_FB; + + igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_OBJ_GETPROPERTIES, + &get_props) == -1 && errno == EINVAL); + } + + set_prop.value = 0; + set_prop.prop_id = 1; + set_prop.obj_id = f.fb_id; + + igt_subtest("invalid-set-prop-any") { + set_prop.obj_type = 0; /* DRM_MODE_OBJECT_ANY */ + + igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_OBJ_SETPROPERTY, + &set_prop) == -1 && errno == EINVAL); + } + + igt_subtest("invalid-set-prop") { + set_prop.obj_type = DRM_MODE_OBJECT_FB; + + igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_OBJ_SETPROPERTY, + &set_prop) == -1 && errno == EINVAL); + } + + igt_fixture + igt_assert(drmIoctl(fd, DRM_IOCTL_MODE_RMFB, &f.fb_id) == 0); + +} + int fd; igt_main @@ -496,6 +560,8 @@ igt_main tiling_tests(fd); + prop_tests(fd); + igt_fixture close(fd); }