diff mbox

[19/35] drm/imx: Use lockless gem BO free callback

Message ID 1461691808-12414-20-git-send-email-daniel.vetter@ffwll.ch (mailing list archive)
State New, archived
Headers show

Commit Message

Daniel Vetter April 26, 2016, 5:29 p.m. UTC
No dev->struct_mutex anywhere to be seen.

Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Philipp Zabel <p.zabel@pengutronix.de>
Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
---
 drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Philipp Zabel April 27, 2016, 10:29 a.m. UTC | #1
Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter:
> No dev->struct_mutex anywhere to be seen.
> 
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Philipp Zabel <p.zabel@pengutronix.de>
> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> ---
>  drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> index e26dcdec2aba..2453fb1c68a7 100644
> --- a/drivers/gpu/drm/imx/imx-drm-core.c
> +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> @@ -411,7 +411,7 @@ static struct drm_driver imx_drm_driver = {
>  	.unload			= imx_drm_driver_unload,
>  	.lastclose		= imx_drm_driver_lastclose,
>  	.set_busid		= drm_platform_set_busid,
> -	.gem_free_object	= drm_gem_cma_free_object,
> +	.gem_free_object_unlocked = drm_gem_cma_free_object,
>  	.gem_vm_ops		= &drm_gem_cma_vm_ops,
>  	.dumb_create		= drm_gem_cma_dumb_create,
>  	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,

Applied to imx-drm/fixes, thank you.

regards
Philipp
Daniel Vetter April 27, 2016, 11:21 a.m. UTC | #2
On Wed, Apr 27, 2016 at 12:29:34PM +0200, Philipp Zabel wrote:
> Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter:
> > No dev->struct_mutex anywhere to be seen.
> > 
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > ---
> >  drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > index e26dcdec2aba..2453fb1c68a7 100644
> > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > @@ -411,7 +411,7 @@ static struct drm_driver imx_drm_driver = {
> >  	.unload			= imx_drm_driver_unload,
> >  	.lastclose		= imx_drm_driver_lastclose,
> >  	.set_busid		= drm_platform_set_busid,
> > -	.gem_free_object	= drm_gem_cma_free_object,
> > +	.gem_free_object_unlocked = drm_gem_cma_free_object,
> >  	.gem_vm_ops		= &drm_gem_cma_vm_ops,
> >  	.dumb_create		= drm_gem_cma_dumb_create,
> >  	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,
> 
> Applied to imx-drm/fixes, thank you.

And that compiles for you? Might want to drop the patch again before
someone notices ;-)
-Daniel
Philipp Zabel April 27, 2016, 12:01 p.m. UTC | #3
Am Mittwoch, den 27.04.2016, 13:21 +0200 schrieb Daniel Vetter:
> On Wed, Apr 27, 2016 at 12:29:34PM +0200, Philipp Zabel wrote:
> > Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter:
> > > No dev->struct_mutex anywhere to be seen.
> > > 
> > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > ---
> > >  drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
> > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > 
> > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > > index e26dcdec2aba..2453fb1c68a7 100644
> > > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > > @@ -411,7 +411,7 @@ static struct drm_driver imx_drm_driver = {
> > >  	.unload			= imx_drm_driver_unload,
> > >  	.lastclose		= imx_drm_driver_lastclose,
> > >  	.set_busid		= drm_platform_set_busid,
> > > -	.gem_free_object	= drm_gem_cma_free_object,
> > > +	.gem_free_object_unlocked = drm_gem_cma_free_object,
> > >  	.gem_vm_ops		= &drm_gem_cma_vm_ops,
> > >  	.dumb_create		= drm_gem_cma_dumb_create,
> > >  	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,
> > 
> > Applied to imx-drm/fixes, thank you.
> 
> And that compiles for you? Might want to drop the patch again before
> someone notices ;-)

Nope, dropped. Nobody will have to.
Daniel Vetter May 4, 2016, 10:28 a.m. UTC | #4
On Wed, Apr 27, 2016 at 02:01:35PM +0200, Philipp Zabel wrote:
> Am Mittwoch, den 27.04.2016, 13:21 +0200 schrieb Daniel Vetter:
> > On Wed, Apr 27, 2016 at 12:29:34PM +0200, Philipp Zabel wrote:
> > > Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter:
> > > > No dev->struct_mutex anywhere to be seen.
> > > > 
> > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > ---
> > > >  drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
> > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > 
> > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > > > index e26dcdec2aba..2453fb1c68a7 100644
> > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > > > @@ -411,7 +411,7 @@ static struct drm_driver imx_drm_driver = {
> > > >  	.unload			= imx_drm_driver_unload,
> > > >  	.lastclose		= imx_drm_driver_lastclose,
> > > >  	.set_busid		= drm_platform_set_busid,
> > > > -	.gem_free_object	= drm_gem_cma_free_object,
> > > > +	.gem_free_object_unlocked = drm_gem_cma_free_object,
> > > >  	.gem_vm_ops		= &drm_gem_cma_vm_ops,
> > > >  	.dumb_create		= drm_gem_cma_dumb_create,
> > > >  	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,
> > > 
> > > Applied to imx-drm/fixes, thank you.
> > 
> > And that compiles for you? Might want to drop the patch again before
> > someone notices ;-)
> 
> Nope, dropped. Nobody will have to.

I presume you having tried to apply it is as good as an ack, so added to
drm-misc.
-Daniel
Philipp Zabel May 4, 2016, 10:53 a.m. UTC | #5
Am Mittwoch, den 04.05.2016, 12:28 +0200 schrieb Daniel Vetter:
> On Wed, Apr 27, 2016 at 02:01:35PM +0200, Philipp Zabel wrote:
> > Am Mittwoch, den 27.04.2016, 13:21 +0200 schrieb Daniel Vetter:
> > > On Wed, Apr 27, 2016 at 12:29:34PM +0200, Philipp Zabel wrote:
> > > > Am Dienstag, den 26.04.2016, 19:29 +0200 schrieb Daniel Vetter:
> > > > > No dev->struct_mutex anywhere to be seen.
> > > > > 
> > > > > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > > > > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > > > > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com>
> > > > > ---
> > > > >  drivers/gpu/drm/imx/imx-drm-core.c | 2 +-
> > > > >  1 file changed, 1 insertion(+), 1 deletion(-)
> > > > > 
> > > > > diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
> > > > > index e26dcdec2aba..2453fb1c68a7 100644
> > > > > --- a/drivers/gpu/drm/imx/imx-drm-core.c
> > > > > +++ b/drivers/gpu/drm/imx/imx-drm-core.c
> > > > > @@ -411,7 +411,7 @@ static struct drm_driver imx_drm_driver = {
> > > > >  	.unload			= imx_drm_driver_unload,
> > > > >  	.lastclose		= imx_drm_driver_lastclose,
> > > > >  	.set_busid		= drm_platform_set_busid,
> > > > > -	.gem_free_object	= drm_gem_cma_free_object,
> > > > > +	.gem_free_object_unlocked = drm_gem_cma_free_object,
> > > > >  	.gem_vm_ops		= &drm_gem_cma_vm_ops,
> > > > >  	.dumb_create		= drm_gem_cma_dumb_create,
> > > > >  	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,
> > > > 
> > > > Applied to imx-drm/fixes, thank you.
> > > 
> > > And that compiles for you? Might want to drop the patch again before
> > > someone notices ;-)
> > 
> > Nope, dropped. Nobody will have to.
> 
> I presume you having tried to apply it is as good as an ack, so added to
> drm-misc.

Yes, thank you.

regards
Philipp
diff mbox

Patch

diff --git a/drivers/gpu/drm/imx/imx-drm-core.c b/drivers/gpu/drm/imx/imx-drm-core.c
index e26dcdec2aba..2453fb1c68a7 100644
--- a/drivers/gpu/drm/imx/imx-drm-core.c
+++ b/drivers/gpu/drm/imx/imx-drm-core.c
@@ -411,7 +411,7 @@  static struct drm_driver imx_drm_driver = {
 	.unload			= imx_drm_driver_unload,
 	.lastclose		= imx_drm_driver_lastclose,
 	.set_busid		= drm_platform_set_busid,
-	.gem_free_object	= drm_gem_cma_free_object,
+	.gem_free_object_unlocked = drm_gem_cma_free_object,
 	.gem_vm_ops		= &drm_gem_cma_vm_ops,
 	.dumb_create		= drm_gem_cma_dumb_create,
 	.dumb_map_offset	= drm_gem_cma_dumb_map_offset,