From patchwork Wed Apr 27 10:29:05 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Philipp Zabel X-Patchwork-Id: 8954741 Return-Path: X-Original-To: patchwork-dri-devel@patchwork.kernel.org Delivered-To: patchwork-parsemail@patchwork2.web.kernel.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.136]) by patchwork2.web.kernel.org (Postfix) with ESMTP id 545FCBF29F for ; Wed, 27 Apr 2016 10:29:22 +0000 (UTC) Received: from mail.kernel.org (localhost [127.0.0.1]) by mail.kernel.org (Postfix) with ESMTP id 62F022022D for ; Wed, 27 Apr 2016 10:29:21 +0000 (UTC) Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.kernel.org (Postfix) with ESMTP id 8F4DD20155 for ; Wed, 27 Apr 2016 10:29:20 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id A93F16E209; Wed, 27 Apr 2016 10:29:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by gabe.freedesktop.org (Postfix) with ESMTPS id 19C7E6E209 for ; Wed, 27 Apr 2016 10:29:12 +0000 (UTC) Received: from paszta.hi.pengutronix.de ([2001:67c:670:100:96de:80ff:fec2:9969] helo=paszta) by metis.ext.pengutronix.de with esmtp (Exim 4.80) (envelope-from ) id 1avMiS-0005DU-Lu; Wed, 27 Apr 2016 12:29:08 +0200 Message-ID: <1461752945.4044.25.camel@pengutronix.de> Subject: Re: [PATCH v14 2/8] drm/mediatek: Add DRM Driver for Mediatek SoC MT8173. From: Philipp Zabel To: Daniel Vetter Date: Wed, 27 Apr 2016 12:29:05 +0200 In-Reply-To: <20160426084800.GZ2510@phenom.ffwll.local> References: <1460387376-11799-1-git-send-email-p.zabel@pengutronix.de> <1460387376-11799-3-git-send-email-p.zabel@pengutronix.de> <1461657922.3599.27.camel@pengutronix.de> <20160426084800.GZ2510@phenom.ffwll.local> X-Mailer: Evolution 3.12.9-1+b1 Mime-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org Cc: Mark Rutland , Emil Velikov , Michael Turquette , Jie Qiu , Cawa Cheng , Mao Huang , Yingjoe Chen , devicetree@vger.kernel.org, Jitao Shi , Pawel Moll , Ian Campbell , YT Shen , Rob Herring , linux-mediatek@lists.infradead.org, dri-devel@lists.freedesktop.org, Matthias Brugger , Paul Bolle , Stephen Boyd , Tomasz Figa , kernel@pengutronix.de, Kumar Gala X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Spam-Status: No, score=-5.2 required=5.0 tests=BAYES_00, RCVD_IN_DNSWL_MED, RP_MATCHES_RCVD, UNPARSEABLE_RELAY autolearn=unavailable version=3.3.1 X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on mail.kernel.org X-Virus-Scanned: ClamAV using ClamSMTP Hi Daniel, Am Dienstag, den 26.04.2016, 10:48 +0200 schrieb Daniel Vetter: [...] > > +static int mtk_drm_unload(struct drm_device *drm) > > +{ > > + mtk_drm_kms_deinit(drm); > > + drm->dev_private = NULL; > > + > > + return 0; > > +} > > Like load, the unload hook is deprecated. And in drm-next we now have some > nice helpers to make not using an unload hook easier. Please refactor per > existing examples and get rid of your unload hook. Thanks, does this change look about right: --------8<-------- .open = drm_open, @@ -246,7 +238,6 @@ static const struct file_operations mtk_drm_fops = { static struct drm_driver mtk_drm_driver = { .driver_features = DRIVER_MODESET | DRIVER_GEM | DRIVER_PRIME | DRIVER_ATOMIC, - .unload = mtk_drm_unload, .get_vblank_counter = drm_vblank_count, .enable_vblank = mtk_drm_crtc_enable_vblank, @@ -455,8 +446,14 @@ err_node: static int mtk_drm_remove(struct platform_device *pdev) { struct mtk_drm_private *private = platform_get_drvdata(pdev); + struct drm_device *drm = private->drm; int i; + drm_connector_unregister_all(drm); + drm_dev_unregister(drm); + mtk_drm_kms_deinit(drm); + drm_dev_unref(drm); + component_master_del(&pdev->dev, &mtk_drm_ops); pm_runtime_disable(&pdev->dev); of_node_put(private->mutex_node); -------->8-------- > > +static const struct vm_operations_struct mtk_drm_gem_vm_ops = { > > + .open = drm_gem_vm_open, > > + .close = drm_gem_vm_close, > > +}; > > Drive-by review I just spotted: Please use drm_gem_cma_vm_ops instead of > rolling your own. Good catch, will remove. regards Philipp --- a/drivers/gpu/drm/mediatek/mtk_drm_drv.c +++ b/drivers/gpu/drm/mediatek/mtk_drm_drv.c @@ -222,14 +222,6 @@ static void mtk_drm_kms_deinit(struct drm_device *drm) drm_mode_config_cleanup(drm); } -static int mtk_drm_unload(struct drm_device *drm) -{ - mtk_drm_kms_deinit(drm); - drm->dev_private = NULL; - - return 0; -} - static const struct file_operations mtk_drm_fops = { .owner = THIS_MODULE,