| Message ID | 1461757122-23128-2-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
Hi Daniel, 2016? 04? 27? 20:38? Daniel Vetter ?(?) ? ?: > It's an optional hook. Might be needed for frontbuffer rendering on > manual upload displays, but a simple TODO doesn't explain at all what > needs to be done or why. We have a plan for partial update support but not now yet. Picked it up. Thanks, Inki Dae > > Cc: Inki Dae <inki.dae@samsung.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > drivers/gpu/drm/exynos/exynos_drm_fb.c | 11 ----------- > 1 file changed, 11 deletions(-) > > diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c > index 81cc5537cf25..f851a40ac6cb 100644 > --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c > +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c > @@ -97,20 +97,9 @@ static int exynos_drm_fb_create_handle(struct drm_framebuffer *fb, > &exynos_fb->exynos_gem[0]->base, handle); > } > > -static int exynos_drm_fb_dirty(struct drm_framebuffer *fb, > - struct drm_file *file_priv, unsigned flags, > - unsigned color, struct drm_clip_rect *clips, > - unsigned num_clips) > -{ > - /* TODO */ > - > - return 0; > -} > - > static const struct drm_framebuffer_funcs exynos_drm_fb_funcs = { > .destroy = exynos_drm_fb_destroy, > .create_handle = exynos_drm_fb_create_handle, > - .dirty = exynos_drm_fb_dirty, > }; > > struct drm_framebuffer * >
diff --git a/drivers/gpu/drm/exynos/exynos_drm_fb.c b/drivers/gpu/drm/exynos/exynos_drm_fb.c index 81cc5537cf25..f851a40ac6cb 100644 --- a/drivers/gpu/drm/exynos/exynos_drm_fb.c +++ b/drivers/gpu/drm/exynos/exynos_drm_fb.c @@ -97,20 +97,9 @@ static int exynos_drm_fb_create_handle(struct drm_framebuffer *fb, &exynos_fb->exynos_gem[0]->base, handle); } -static int exynos_drm_fb_dirty(struct drm_framebuffer *fb, - struct drm_file *file_priv, unsigned flags, - unsigned color, struct drm_clip_rect *clips, - unsigned num_clips) -{ - /* TODO */ - - return 0; -} - static const struct drm_framebuffer_funcs exynos_drm_fb_funcs = { .destroy = exynos_drm_fb_destroy, .create_handle = exynos_drm_fb_create_handle, - .dirty = exynos_drm_fb_dirty, }; struct drm_framebuffer *
It's an optional hook. Might be needed for frontbuffer rendering on manual upload displays, but a simple TODO doesn't explain at all what needs to be done or why. Cc: Inki Dae <inki.dae@samsung.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- drivers/gpu/drm/exynos/exynos_drm_fb.c | 11 ----------- 1 file changed, 11 deletions(-)