From patchwork Sun May 29 18:35:02 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 9139869 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 1A8AD60759 for ; Sun, 29 May 2016 18:36:09 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 1002F27CF9 for ; Sun, 29 May 2016 18:36:09 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 04ED9281F9; Sun, 29 May 2016 18:36:09 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C41E627CF9 for ; Sun, 29 May 2016 18:36:08 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 7772E6E5A4; Sun, 29 May 2016 18:35:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id DDCCE6E598 for ; Sun, 29 May 2016 18:35:35 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id e3so16012392wme.2 for ; Sun, 29 May 2016 11:35:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=GCrPn3QJNXDNPxWPIxci2/koVapw+wGw7cqUCU5L2cA=; b=W+sWULQkBMlzpRIbW0OeoAx/tCriVmvQbl622b3V4+zTuu7Fj0qlvKAPUxyg9o4d1A wzkjjGMWp4MLXtjZBs5cLAhb1NWCfgbjFDqMRXLmz1zDjh83ULSTx8bNytV0nVgUHDlJ hTDScK3i4BG9qbKr3idBRX8WRkg/USziiIRjo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=GCrPn3QJNXDNPxWPIxci2/koVapw+wGw7cqUCU5L2cA=; b=hCVRfyIZaTTYaFpcoI2erC2hPk0ZRA9WBvmSYqV6kQrwmbZNx6upsAk1O4MJuY+CTZ gLqkTRKCG0XTn/8GPL6g3ZUNoLohXA2HGDvAtHKrYXFq0sYHL39ebTD1F7szpVpaOzNr 3OU+VNuTYQQY5cIz0yrBpUZc2JkgSVd8gD9yNutlttDoU8GVpWIoItDIycznKmYwVSz7 qa2rRj2juy8cTJMmdVQnc0JB/PocAEFfPITibaqvO4mguUsz9Kt8iHYI1PtuL+XKUcE2 meH7aQauSayroDPeTB4iJ6m0uhp9EN3yjPjs4W0UFv+NnGmJ+4yO6owSOHNKj4l3Bkam 3z+w== X-Gm-Message-State: ALyK8tIjEIc2YWqCDMO9XHdHYpc6jn5h4oh1XIoAsDn8g4DtN/+9qPslcBpcUIEuN3iDkQ== X-Received: by 10.194.18.34 with SMTP id t2mr22984345wjd.180.1464546933843; Sun, 29 May 2016 11:35:33 -0700 (PDT) Received: from phenom.ffwll.local ([2a02:168:56b5:0:ac27:b86c:7764:9429]) by smtp.gmail.com with ESMTPSA id h2sm7761550wjv.15.2016.05.29.11.35.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sun, 29 May 2016 11:35:33 -0700 (PDT) From: Daniel Vetter To: DRI Development Subject: [PATCH 05/26] drm/vc4: Use for_each_plane_in_state Date: Sun, 29 May 2016 20:35:02 +0200 Message-Id: <1464546923-13439-6-git-send-email-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1464546923-13439-1-git-send-email-daniel.vetter@ffwll.ch> References: <1464546923-13439-1-git-send-email-daniel.vetter@ffwll.ch> Cc: Daniel Vetter , Daniel Vetter , Intel Graphics Development X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP We want to hide drm_atomic_stat internals a bit better. Cc: Eric Anholt Signed-off-by: Daniel Vetter --- drivers/gpu/drm/vc4/vc4_kms.c | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/vc4/vc4_kms.c b/drivers/gpu/drm/vc4/vc4_kms.c index cb37751bc99f..39c0b2048bfd 100644 --- a/drivers/gpu/drm/vc4/vc4_kms.c +++ b/drivers/gpu/drm/vc4/vc4_kms.c @@ -111,6 +111,8 @@ static int vc4_atomic_commit(struct drm_device *dev, int i; uint64_t wait_seqno = 0; struct vc4_commit *c; + struct drm_plane *plane; + struct drm_plane_state *new_state; c = commit_init(state); if (!c) @@ -130,13 +132,7 @@ static int vc4_atomic_commit(struct drm_device *dev, return ret; } - for (i = 0; i < dev->mode_config.num_total_plane; i++) { - struct drm_plane *plane = state->planes[i]; - struct drm_plane_state *new_state = state->plane_states[i]; - - if (!plane) - continue; - + for_each_plane_in_state(state, plane, new_state, i) { if ((plane->state->fb != new_state->fb) && new_state->fb) { struct drm_gem_cma_object *cma_bo = drm_fb_cma_get_gem_obj(new_state->fb, 0);