From patchwork Thu Jun 2 13:33:34 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Deucher X-Patchwork-Id: 9149971 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B1EBD60751 for ; Thu, 2 Jun 2016 13:33:57 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id A47B2254F7 for ; Thu, 2 Jun 2016 13:33:57 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 9998728047; Thu, 2 Jun 2016 13:33:57 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00, DKIM_ADSP_CUSTOM_MED, DKIM_SIGNED, FREEMAIL_FROM, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 442D9254F7 for ; Thu, 2 Jun 2016 13:33:57 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id B02E56EB7B; Thu, 2 Jun 2016 13:33:55 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-qg0-x241.google.com (mail-qg0-x241.google.com [IPv6:2607:f8b0:400d:c04::241]) by gabe.freedesktop.org (Postfix) with ESMTPS id 34B226EB89 for ; Thu, 2 Jun 2016 13:33:45 +0000 (UTC) Received: by mail-qg0-x241.google.com with SMTP id p34so8757855qgp.0 for ; Thu, 02 Jun 2016 06:33:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=PMALUiJLBrTAIDZpc6rDa7F9hB8aEHaH6Cry/Ro7Skw=; b=o60XzZD8BXqetpUrk2Aq0hLYXt2f6WSTejla6cqbMKaz/yKhYu5WEw5x09Gk3zap9J VBVRjqc3+1DOjNU4DsOaS++9myaRBu2fIrE7zM7jhZ061EdT1DSLiApmTRk/iTyI5uZX xj96KUUfPMEWIEA5y+B1n/3GTykGUvlrJLaOYYOh0xbCx43ZpEg95+4vfPZ0oKLjPrYU uqyEZs5NtlkKwnjm8Y5Vffb223l/tMKTAjDcGMueWQ7acOLMW34bIP/xSNM01QueGtAs 9JXUbrYMz0KiTtvCJzoN3PblJBa6cdbxujQ3Dz0cFSc9sztuXR7iB4KHveW2wvqkWMdK GzZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=PMALUiJLBrTAIDZpc6rDa7F9hB8aEHaH6Cry/Ro7Skw=; b=IP045aRmrg50QvBHyVZ8TzeYKfPgrFzITUobyF1j7xwnMMWePS2gETY2DHbBA7DhkS AFQTdvgnLBUQ1NSSpp2xmtRVQBm4kEJ/eHTCvm2jTqe6zMgnVbzCXeQOdla215Kjh1Q3 H5K84yNi9eQa8Wn/GOu9MJp8aqHwcp4p/UIr7l6zCCDQ27FpaUjGJ0O1H7mpT2x0kp+r /xBQK6dycQMT3wvJuSAjYhC6vA1k90G9kxQYCgo4Q7aTbI9Xret3wtSaByOzQTiRkz4u Dg/n/g2ncWxygHb1sB4f6MGed8/AtoiVwHE0DfSs9JuPW4N5ePPDzNIKVGrExLft9zHU EVRQ== X-Gm-Message-State: ALyK8tI5Btua57F5+Xg3hnVPXWXqCWhyLmhIlznk01oEwOpOqyAm2S1j7DHeiVYZgBU1Ug== X-Received: by 10.140.20.162 with SMTP id 31mr30360219qgj.106.1464874424000; Thu, 02 Jun 2016 06:33:44 -0700 (PDT) Received: from cm.localdomain (static-74-96-105-49.washdc.fios.verizon.net. [74.96.105.49]) by smtp.gmail.com with ESMTPSA id u131sm7962690qka.44.2016.06.02.06.33.43 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 02 Jun 2016 06:33:43 -0700 (PDT) From: Alex Deucher X-Google-Original-From: Alex Deucher To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/6] drm/amdgpu: drop explicit pci D3/D0 setting for ATPX power control Date: Thu, 2 Jun 2016 09:33:34 -0400 Message-Id: <1464874417-27272-3-git-send-email-alexander.deucher@amd.com> X-Mailer: git-send-email 2.5.5 In-Reply-To: <1464874417-27272-1-git-send-email-alexander.deucher@amd.com> References: <1464874417-27272-1-git-send-email-alexander.deucher@amd.com> Cc: Alex Deucher X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP The ATPX power control method does this for you. Signed-off-by: Alex Deucher --- drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c index 6c38901..e2bf4ef 100644 --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_drv.c @@ -419,9 +419,7 @@ static int amdgpu_pmops_runtime_suspend(struct device *dev) pci_ignore_hotplug(pdev); if (amdgpu_is_atpx_hybrid()) pci_set_power_state(pdev, PCI_D3cold); - else if (amdgpu_has_atpx_dgpu_power_cntl()) - pci_set_power_state(pdev, PCI_D3cold); - else + else if (!amdgpu_has_atpx_dgpu_power_cntl()) pci_set_power_state(pdev, PCI_D3hot); drm_dev->switch_power_state = DRM_SWITCH_POWER_DYNAMIC_OFF; @@ -439,7 +437,9 @@ static int amdgpu_pmops_runtime_resume(struct device *dev) drm_dev->switch_power_state = DRM_SWITCH_POWER_CHANGING; - pci_set_power_state(pdev, PCI_D0); + if (amdgpu_is_atpx_hybrid() || + !amdgpu_has_atpx_dgpu_power_cntl()) + pci_set_power_state(pdev, PCI_D0); pci_restore_state(pdev); ret = pci_enable_device(pdev); if (ret)