From patchwork Mon Jun 6 14:47:46 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tomeu Vizoso X-Patchwork-Id: 9158483 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id 4540160759 for ; Mon, 6 Jun 2016 14:48:19 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 36E28252D5 for ; Mon, 6 Jun 2016 14:48:19 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 2BC6026E5D; Mon, 6 Jun 2016 14:48:19 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED,T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 09427252D5 for ; Mon, 6 Jun 2016 14:48:17 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 413846E5B6; Mon, 6 Jun 2016 14:48:14 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x243.google.com (mail-wm0-x243.google.com [IPv6:2a00:1450:400c:c09::243]) by gabe.freedesktop.org (Postfix) with ESMTPS id A667A6E5B6 for ; Mon, 6 Jun 2016 14:48:12 +0000 (UTC) Received: by mail-wm0-x243.google.com with SMTP id c74so8869198wme.0 for ; Mon, 06 Jun 2016 07:48:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id; bh=fEeU/Qbmwpn7pTyPFIVuOUHw4Gy/NvSw4OIdpA8p92c=; b=Vyzxm/mJ+JQ4opkO/0JOIfoD8EaQEEdFE/tF1kXrjHxbx1Hk9sSm1n/2WfKShxKlXg ZNi+sAoPt0QY7rCSTks0bDL+NcLEhOFq2uyCnsU+2W3AcOFYathtzgq2BsZlAeZzgixf mIHRBQOFz6+4LAJsJM7xSRbKGMpKGoOoJdTFap4G91NXte+XEyttmggw8fXg50GS3fbB 9Q2j8+uq5QwCS+G48UDn0x/s7eCR7uZhzBI5QZjGKY+CJnQYFdwIhHDKGicM5KS09z2C V+hniPTBhb3FhMpnS4qyyAdfHD3t3QSzbYinLx89XM174FERC4GNgfBpnQmTDNdupThk BWhQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id; bh=fEeU/Qbmwpn7pTyPFIVuOUHw4Gy/NvSw4OIdpA8p92c=; b=Uzi4iel45J1PIlE7HN1USsNOMnS6FMdEoagzjmEDZ/dcSpTP8LCMvzelGcYAeXhwYj rMAzrQbqBvoEVWex20auzcorevB0MKuwxExc9kZo+9Hly0Ts2XxDwRxZSUL8l8G2pXrn ceTSUqun9F7eIGKkGi9L4fGwVWGS+LYv+BJrBT8FTqoMdK5Cu2wJbiV4PHkwmHjFHQp3 XtxQKOfKgXQLAtDvI8eFHQhDTzQ5jTaCiPQXaE9/xpqfzeGv5qfGkSzJdum4IPFfY78K PSXQ9nxGIeoOstvdw4c/Q69NwCFVHK2bNf6ndBNn3EflyxdU8VZYv1qRD+ogIHsIt+Xz 5JKg== X-Gm-Message-State: ALyK8tJJcOJbbPQySc6F14Pf9Wy4zaFw9U0ZXNbltswzMRw47t78b3AZotjGCMmkwsv2Wg== X-Received: by 10.194.87.72 with SMTP id v8mr18281371wjz.68.1465224490981; Mon, 06 Jun 2016 07:48:10 -0700 (PDT) Received: from cizrna.lan ([109.72.12.27]) by smtp.gmail.com with ESMTPSA id xz3sm20630835wjb.35.2016.06.06.07.48.09 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 06 Jun 2016 07:48:09 -0700 (PDT) From: Tomeu Vizoso To: linux-kernel@vger.kernel.org Subject: [PATCH] drm: bridge: analogix/dp: Don't disable interrupts Date: Mon, 6 Jun 2016 16:47:46 +0200 Message-Id: <1465224466-6295-1-git-send-email-tomeu.vizoso@collabora.com> X-Mailer: git-send-email 2.5.5 Cc: Tomeu Vizoso , Douglas Anderson , dri-devel@lists.freedesktop.org, Javier Martinez Canillas , Caesar Wang X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Regardless of the status of the bridge, we want to receive HPD events. Only disable it when suspending. Signed-off-by: Tomeu Vizoso Cc: Caesar Wang Cc: Douglas Anderson Cc: Heiko Stuebner Cc: Javier Martinez Canillas Cc: Yakir Yang --- drivers/gpu/drm/bridge/analogix/analogix_dp_core.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c index 7699597070a1..f66a53a5c36e 100644 --- a/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c +++ b/drivers/gpu/drm/bridge/analogix/analogix_dp_core.c @@ -1049,7 +1049,6 @@ static void analogix_dp_bridge_enable(struct drm_bridge *bridge) phy_power_on(dp->phy); analogix_dp_init_dp(dp); - enable_irq(dp->irq); analogix_dp_commit(dp); dp->dpms_mode = DRM_MODE_DPMS_ON; @@ -1069,7 +1068,6 @@ static void analogix_dp_bridge_disable(struct drm_bridge *bridge) } } - disable_irq(dp->irq); phy_power_off(dp->phy); if (dp->plat_data->power_off) @@ -1349,7 +1347,6 @@ int analogix_dp_bind(struct device *dev, struct drm_device *drm_dev, dev_err(&pdev->dev, "failed to request irq\n"); goto err_disable_pm_runtime; } - disable_irq(dp->irq); dp->drm_dev = drm_dev; dp->encoder = dp->plat_data->encoder; @@ -1391,6 +1388,8 @@ int analogix_dp_suspend(struct device *dev) { struct analogix_dp_device *dp = dev_get_drvdata(dev); + disable_irq(dp->irq); + clk_disable_unprepare(dp->clock); if (dp->plat_data->panel) { @@ -1420,6 +1419,8 @@ int analogix_dp_resume(struct device *dev) } } + enable_irq(dp->irq); + return 0; } EXPORT_SYMBOL_GPL(analogix_dp_resume);