| Message ID | 1465255994-317-3-git-send-email-laurent.pinchart@ideasonboard.com (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Tue, Jun 07, 2016 at 02:33:12AM +0300, Laurent Pinchart wrote: > The drm_format_plane_width() and drm_format_plane_height() helper > functions are not used, remove them. I have a user lined up, assuming I could get the dang thing reviewed. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > --- > drivers/gpu/drm/drm_crtc.c | 42 ------------------------------------------ > include/drm/drm_crtc.h | 2 -- > 2 files changed, 44 deletions(-) > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > index 74b0c6dd80cd..b405d4379e47 100644 > --- a/drivers/gpu/drm/drm_crtc.c > +++ b/drivers/gpu/drm/drm_crtc.c > @@ -5843,48 +5843,6 @@ int drm_format_vert_chroma_subsampling(uint32_t format) > EXPORT_SYMBOL(drm_format_vert_chroma_subsampling); > > /** > - * drm_format_plane_width - width of the plane given the first plane > - * @width: width of the first plane > - * @format: pixel format > - * @plane: plane index > - * > - * Returns: > - * The width of @plane, given that the width of the first plane is @width. > - */ > -int drm_format_plane_width(int width, uint32_t format, int plane) > -{ > - if (plane >= drm_format_num_planes(format)) > - return 0; > - > - if (plane == 0) > - return width; > - > - return width / drm_format_horz_chroma_subsampling(format); > -} > -EXPORT_SYMBOL(drm_format_plane_width); > - > -/** > - * drm_format_plane_height - height of the plane given the first plane > - * @height: height of the first plane > - * @format: pixel format > - * @plane: plane index > - * > - * Returns: > - * The height of @plane, given that the height of the first plane is @height. > - */ > -int drm_format_plane_height(int height, uint32_t format, int plane) > -{ > - if (plane >= drm_format_num_planes(format)) > - return 0; > - > - if (plane == 0) > - return height; > - > - return height / drm_format_vert_chroma_subsampling(format); > -} > -EXPORT_SYMBOL(drm_format_plane_height); > - > -/** > * drm_rotation_simplify() - Try to simplify the rotation > * @rotation: Rotation to be simplified > * @supported_rotations: Supported rotations > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > index 4199794cc317..a45f57f32dca 100644 > --- a/include/drm/drm_crtc.h > +++ b/include/drm/drm_crtc.h > @@ -2567,8 +2567,6 @@ extern int drm_format_num_planes(uint32_t format); > extern int drm_format_plane_cpp(uint32_t format, int plane); > extern int drm_format_horz_chroma_subsampling(uint32_t format); > extern int drm_format_vert_chroma_subsampling(uint32_t format); > -extern int drm_format_plane_width(int width, uint32_t format, int plane); > -extern int drm_format_plane_height(int height, uint32_t format, int plane); > extern const char *drm_get_format_name(uint32_t format); > extern struct drm_property *drm_mode_create_rotation_property(struct drm_device *dev, > unsigned int supported_rotations); > -- > Regards, > > Laurent Pinchart > > _______________________________________________ > dri-devel mailing list > dri-devel@lists.freedesktop.org > https://lists.freedesktop.org/mailman/listinfo/dri-devel
Hi Ville, On Tuesday 07 Jun 2016 16:19:01 Ville Syrjälä wrote: > On Tue, Jun 07, 2016 at 02:33:12AM +0300, Laurent Pinchart wrote: > > The drm_format_plane_width() and drm_format_plane_height() helper > > functions are not used, remove them. > > I have a user lined up, assuming I could get the dang thing reviewed. OK, I'll keep the functions and convert them to use drm_format_info(). If your user needs to call more than one format helper then I'd suggest using drm_format_info() directly and perform the width/height computation yourself, it will be more efficient. > > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> > > --- > > > > drivers/gpu/drm/drm_crtc.c | 42 ---------------------------------------- > > include/drm/drm_crtc.h | 2 -- > > 2 files changed, 44 deletions(-) > > > > diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c > > index 74b0c6dd80cd..b405d4379e47 100644 > > --- a/drivers/gpu/drm/drm_crtc.c > > +++ b/drivers/gpu/drm/drm_crtc.c > > @@ -5843,48 +5843,6 @@ int drm_format_vert_chroma_subsampling(uint32_t > > format)> > > EXPORT_SYMBOL(drm_format_vert_chroma_subsampling); > > > > /** > > > > - * drm_format_plane_width - width of the plane given the first plane > > - * @width: width of the first plane > > - * @format: pixel format > > - * @plane: plane index > > - * > > - * Returns: > > - * The width of @plane, given that the width of the first plane is > > @width. > > - */ > > -int drm_format_plane_width(int width, uint32_t format, int plane) > > -{ > > - if (plane >= drm_format_num_planes(format)) > > - return 0; > > - > > - if (plane == 0) > > - return width; > > - > > - return width / drm_format_horz_chroma_subsampling(format); > > -} > > -EXPORT_SYMBOL(drm_format_plane_width); > > - > > -/** > > - * drm_format_plane_height - height of the plane given the first plane > > - * @height: height of the first plane > > - * @format: pixel format > > - * @plane: plane index > > - * > > - * Returns: > > - * The height of @plane, given that the height of the first plane is > > @height. - */ > > -int drm_format_plane_height(int height, uint32_t format, int plane) > > -{ > > - if (plane >= drm_format_num_planes(format)) > > - return 0; > > - > > - if (plane == 0) > > - return height; > > - > > - return height / drm_format_vert_chroma_subsampling(format); > > -} > > -EXPORT_SYMBOL(drm_format_plane_height); > > - > > -/** > > > > * drm_rotation_simplify() - Try to simplify the rotation > > * @rotation: Rotation to be simplified > > * @supported_rotations: Supported rotations > > > > diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h > > index 4199794cc317..a45f57f32dca 100644 > > --- a/include/drm/drm_crtc.h > > +++ b/include/drm/drm_crtc.h > > @@ -2567,8 +2567,6 @@ extern int drm_format_num_planes(uint32_t format); > > > > extern int drm_format_plane_cpp(uint32_t format, int plane); > > extern int drm_format_horz_chroma_subsampling(uint32_t format); > > extern int drm_format_vert_chroma_subsampling(uint32_t format); > > > > -extern int drm_format_plane_width(int width, uint32_t format, int plane); > > -extern int drm_format_plane_height(int height, uint32_t format, int > > plane);> > > extern const char *drm_get_format_name(uint32_t format); > > extern struct drm_property *drm_mode_create_rotation_property(struct > > drm_device *dev,> > > unsigned int supported_rotations);
diff --git a/drivers/gpu/drm/drm_crtc.c b/drivers/gpu/drm/drm_crtc.c index 74b0c6dd80cd..b405d4379e47 100644 --- a/drivers/gpu/drm/drm_crtc.c +++ b/drivers/gpu/drm/drm_crtc.c @@ -5843,48 +5843,6 @@ int drm_format_vert_chroma_subsampling(uint32_t format) EXPORT_SYMBOL(drm_format_vert_chroma_subsampling); /** - * drm_format_plane_width - width of the plane given the first plane - * @width: width of the first plane - * @format: pixel format - * @plane: plane index - * - * Returns: - * The width of @plane, given that the width of the first plane is @width. - */ -int drm_format_plane_width(int width, uint32_t format, int plane) -{ - if (plane >= drm_format_num_planes(format)) - return 0; - - if (plane == 0) - return width; - - return width / drm_format_horz_chroma_subsampling(format); -} -EXPORT_SYMBOL(drm_format_plane_width); - -/** - * drm_format_plane_height - height of the plane given the first plane - * @height: height of the first plane - * @format: pixel format - * @plane: plane index - * - * Returns: - * The height of @plane, given that the height of the first plane is @height. - */ -int drm_format_plane_height(int height, uint32_t format, int plane) -{ - if (plane >= drm_format_num_planes(format)) - return 0; - - if (plane == 0) - return height; - - return height / drm_format_vert_chroma_subsampling(format); -} -EXPORT_SYMBOL(drm_format_plane_height); - -/** * drm_rotation_simplify() - Try to simplify the rotation * @rotation: Rotation to be simplified * @supported_rotations: Supported rotations diff --git a/include/drm/drm_crtc.h b/include/drm/drm_crtc.h index 4199794cc317..a45f57f32dca 100644 --- a/include/drm/drm_crtc.h +++ b/include/drm/drm_crtc.h @@ -2567,8 +2567,6 @@ extern int drm_format_num_planes(uint32_t format); extern int drm_format_plane_cpp(uint32_t format, int plane); extern int drm_format_horz_chroma_subsampling(uint32_t format); extern int drm_format_vert_chroma_subsampling(uint32_t format); -extern int drm_format_plane_width(int width, uint32_t format, int plane); -extern int drm_format_plane_height(int height, uint32_t format, int plane); extern const char *drm_get_format_name(uint32_t format); extern struct drm_property *drm_mode_create_rotation_property(struct drm_device *dev, unsigned int supported_rotations);
The drm_format_plane_width() and drm_format_plane_height() helper functions are not used, remove them. Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com> --- drivers/gpu/drm/drm_crtc.c | 42 ------------------------------------------ include/drm/drm_crtc.h | 2 -- 2 files changed, 44 deletions(-)