| Message ID | 1465388359-8070-7-git-send-email-daniel.vetter@ffwll.ch (mailing list archive) |
|---|---|
| State | New, archived |
| Headers | show |
On Wed, Jun 08, 2016 at 02:18:59PM +0200, Daniel Vetter wrote: > Just a bit of drive-by ocd. > > v2: Improve per Liviu's feedback. > > Cc: Liviu Dudau <Liviu.Dudau@arm.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> Acked-by: Liviu Dudau <Liviu.Dudau@arm.com> > --- > include/drm/drm_atomic.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index d12cfb9c6062..a16861c882aa 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -198,6 +198,16 @@ int __must_check drm_atomic_nonblocking_commit(struct drm_atomic_state *state); > (plane_state) = (__state)->planes[__i].state, 1); \ > (__i)++) \ > for_each_if (plane_state) > + > +/** > + * drm_atomic_crtc_needs_modeset - compute combined modeset need > + * @state: &drm_crtc_state for the CRTC > + * > + * To give drivers flexibility struct &drm_crtc_state has 3 booleans to track > + * whether the state CRTC changed enough to need a full modeset cycle: > + * connectors_changed, mode_changed and active_change. This helper simply > + * combines these three to compute the overall need for a modeset for @state. > + */ > static inline bool > drm_atomic_crtc_needs_modeset(struct drm_crtc_state *state) > { > -- > 2.8.1 >
Op 08-06-16 om 14:18 schreef Daniel Vetter: > Just a bit of drive-by ocd. > > v2: Improve per Liviu's feedback. > > Cc: Liviu Dudau <Liviu.Dudau@arm.com> > Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> > --- > include/drm/drm_atomic.h | 10 ++++++++++ > 1 file changed, 10 insertions(+) > > diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h > index d12cfb9c6062..a16861c882aa 100644 > --- a/include/drm/drm_atomic.h > +++ b/include/drm/drm_atomic.h > @@ -198,6 +198,16 @@ int __must_check drm_atomic_nonblocking_commit(struct drm_atomic_state *state); > (plane_state) = (__state)->planes[__i].state, 1); \ > (__i)++) \ > for_each_if (plane_state) > + > +/** > + * drm_atomic_crtc_needs_modeset - compute combined modeset need > + * @state: &drm_crtc_state for the CRTC > + * > + * To give drivers flexibility struct &drm_crtc_state has 3 booleans to track > + * whether the state CRTC changed enough to need a full modeset cycle: > + * connectors_changed, mode_changed and active_change. This helper simply > + * combines these three to compute the overall need for a modeset for @state. > + */ > static inline bool > drm_atomic_crtc_needs_modeset(struct drm_crtc_state *state) > { Reviewed-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
diff --git a/include/drm/drm_atomic.h b/include/drm/drm_atomic.h index d12cfb9c6062..a16861c882aa 100644 --- a/include/drm/drm_atomic.h +++ b/include/drm/drm_atomic.h @@ -198,6 +198,16 @@ int __must_check drm_atomic_nonblocking_commit(struct drm_atomic_state *state); (plane_state) = (__state)->planes[__i].state, 1); \ (__i)++) \ for_each_if (plane_state) + +/** + * drm_atomic_crtc_needs_modeset - compute combined modeset need + * @state: &drm_crtc_state for the CRTC + * + * To give drivers flexibility struct &drm_crtc_state has 3 booleans to track + * whether the state CRTC changed enough to need a full modeset cycle: + * connectors_changed, mode_changed and active_change. This helper simply + * combines these three to compute the overall need for a modeset for @state. + */ static inline bool drm_atomic_crtc_needs_modeset(struct drm_crtc_state *state) {
Just a bit of drive-by ocd. v2: Improve per Liviu's feedback. Cc: Liviu Dudau <Liviu.Dudau@arm.com> Signed-off-by: Daniel Vetter <daniel.vetter@intel.com> --- include/drm/drm_atomic.h | 10 ++++++++++ 1 file changed, 10 insertions(+)