From patchwork Wed Jun 15 12:17:52 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9178353 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id D43076021C for ; Wed, 15 Jun 2016 12:19:01 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C5A7F27BFC for ; Wed, 15 Jun 2016 12:19:01 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id BAA6027CEA; Wed, 15 Jun 2016 12:19:01 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 7AEFC27BFC for ; Wed, 15 Jun 2016 12:19:01 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 5E6AB6E91B; Wed, 15 Jun 2016 12:18:52 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 0A2146E916; Wed, 15 Jun 2016 12:18:49 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id m124so5512914wme.3; Wed, 15 Jun 2016 05:18:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=2WJdv47D+OMF/yyo1BQpChfgkcitT3Qi/uu506eMA8Y=; b=Xl5A5BrdEkP+e2e9Md8FGSkwzjumhscm7rpOkTVrsX5arVi8eS0XpKR65w8MWvISS/ 1PLikuObVWOlOVkRgImzpJt5+GBr8Nc4BA89OZcZthDqtZnIMki08q8L0JfcCuE2qq0a /pSYp4sTAAcpz0MwaYbLZO3Y3o5fBSd9c5UDpszbg3LZ8Ja3dWqbj/jdPqls+a9ZQ9vD eMb6DQ2hMrdXZX5B/0GgMSEXKS/qeV0VdUM+AqO3IKum6o3Y51smpQKZkWSg8gOIjw8Z uo0yQSjPokZd43BIEa5Vl4LG4arKAmH1xPfw8/jY97jwWQ4DuSyNTPf+tShXvB92xtZD J6gA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=2WJdv47D+OMF/yyo1BQpChfgkcitT3Qi/uu506eMA8Y=; b=gTG45SjmJptU+1gooGIsNNGWp/1DSNCnKE7PnSFwwMkQrCjSDT/cg7edEWqkZBR1BN lvBd5LFKCG7ocib1DIWIP+KYxsH2PwVap3tGyO7l7kmU6lIqSj/eU4rlykUFTHZvW17E vmEbfnYOVefmuAbohJwdcNGHVfFMJ84FO4Drl0SG5/kie0XXuYxIW9uYhKIUK0mRJ2G3 cTOStXff6j7DV+afPsq7tAWCsT/8CsKOU16k1opvijQP086YmVb4IsE0LGvRiNaqix8l bCS+kiaq2Ee16bGL/4fZQfsXwvrhNX8shZmj9MvotlT6fGSarPBopKJEeOkJ3FKoqVU8 i9qQ== X-Gm-Message-State: ALyK8tKX+FKOCFTiJXIcE7I5B0IpwPRlJXei2spN9nkvKIj39WU8YeoXR1awLSuhhgN0PQ== X-Received: by 10.194.158.138 with SMTP id wu10mr10552025wjb.84.1465993127295; Wed, 15 Jun 2016 05:18:47 -0700 (PDT) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id jf3sm7450242wjb.41.2016.06.15.05.18.46 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Jun 2016 05:18:46 -0700 (PDT) From: Chris Wilson To: intel-gfx@lists.freedesktop.org Subject: [PATCH 07/44] drm/atmel-hlcdc: Remove redundant calls to drm_connector_register_all() Date: Wed, 15 Jun 2016 13:17:52 +0100 Message-Id: <1465993109-19523-8-git-send-email-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1465993109-19523-1-git-send-email-chris@chris-wilson.co.uk> References: <1465993109-19523-1-git-send-email-chris@chris-wilson.co.uk> Cc: Daniel Vetter , dri-devel@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Up to now, the recommendation was for drivers to call drm_dev_register() followed by drm_connector_register_all(). Now that drm_connector_register() is safe against multiple invocations, we can move drm_connector_register_all() to drm_dev_register() and not suffer from any backwards compatibility issues with drivers not following the more rigorous init ordering. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Boris Brezillon Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 9ecf16c7911d..99c4af697c8a 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -815,15 +815,8 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) if (ret) goto err_unload; - ret = drm_connector_register_all(ddev); - if (ret) - goto err_unregister; - return 0; -err_unregister: - drm_dev_unregister(ddev); - err_unload: atmel_hlcdc_dc_unload(ddev);