From patchwork Thu Jun 16 14:41:34 2016
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: 8bit
X-Patchwork-Submitter: Philipp Zabel
X-Patchwork-Id: 9181163
Return-Path:
Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org
[172.30.200.125])
by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id
D238360760 for ;
Thu, 16 Jun 2016 14:41:41 +0000 (UTC)
Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1])
by mail.wl.linuxfoundation.org (Postfix) with ESMTP id C235426538
for ;
Thu, 16 Jun 2016 14:41:41 +0000 (UTC)
Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486)
id B463828362; Thu, 16 Jun 2016 14:41:41 +0000 (UTC)
X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on
pdx-wl-mail.web.codeaurora.org
X-Spam-Level:
X-Spam-Status: No, score=-4.2 required=2.0 tests=BAYES_00, RCVD_IN_DNSWL_MED
autolearn=ham version=3.3.1
Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177])
by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 38AC526538
for ;
Thu, 16 Jun 2016 14:41:41 +0000 (UTC)
Received: from gabe.freedesktop.org (localhost [127.0.0.1])
by gabe.freedesktop.org (Postfix) with ESMTP id DA34B6EA75;
Thu, 16 Jun 2016 14:41:39 +0000 (UTC)
X-Original-To: dri-devel@lists.freedesktop.org
Delivered-To: dri-devel@lists.freedesktop.org
Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de
[IPv6:2001:67c:670:201:290:27ff:fe1d:cc33])
by gabe.freedesktop.org (Postfix) with ESMTPS id 01D006EA79
for ;
Thu, 16 Jun 2016 14:41:38 +0000 (UTC)
Received: from paszta.hi.pengutronix.de
([2001:67c:670:100:96de:80ff:fec2:9969] helo=paszta)
by metis.ext.pengutronix.de with esmtp (Exim 4.80)
(envelope-from )
id 1bDYUB-0006YW-Dw; Thu, 16 Jun 2016 16:41:35 +0200
Message-ID: <1466088094.3343.36.camel@pengutronix.de>
Subject: Re: [GIT PULL] drm/mediatek: MT8173 HDMI support
From: Philipp Zabel
To: Dave Airlie
Date: Thu, 16 Jun 2016 16:41:34 +0200
In-Reply-To:
References: <1465811080.3553.8.camel@pengutronix.de>
X-Mailer: Evolution 3.12.9-1+b1
Mime-Version: 1.0
X-SA-Exim-Connect-IP: 2001:67c:670:100:96de:80ff:fec2:9969
X-SA-Exim-Mail-From: p.zabel@pengutronix.de
X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de);
SAEximRunCond expanded to false
X-PTX-Original-Recipient: dri-devel@lists.freedesktop.org
Cc: linux-mediatek@lists.infradead.org,
dri-devel ,
Sascha Hauer
X-BeenThere: dri-devel@lists.freedesktop.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: Direct Rendering Infrastructure - Development
List-Unsubscribe: ,
List-Archive:
List-Post:
List-Help:
List-Subscribe: ,
Errors-To: dri-devel-bounces@lists.freedesktop.org
Sender: "dri-devel"
X-Virus-Scanned: ClamAV using ClamSMTP
Am Donnerstag, den 16.06.2016, 06:19 +1000 schrieb Dave Airlie:
> On 13 June 2016 at 19:44, Philipp Zabel wrote:
> > Hi Dave,
> >
> > please consider merging this tag, which contains the v16 MT8173 HDMI
> > patches I sent on 2016-05-26, rebased onto v4.7-rc2. There have been no
> > further comments.
>
> arm32 build
> DTC drivers/gpu/drm/tilcdc/tilcdc_slave_compat.dtb
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:
> In function ‘mtk_hdmi_ddc_probe’:
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:322:111:
> warning: format ‘%llx’ expects argument of type ‘long long unsigned
> int’, but argument 4 has type ‘resource_size_t {aka unsigned int}’
> [-Wformat=]
> /home/airlied/devel/kernel/drm-next/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c:322:111:
> warning: format ‘%llx’ expects argument of type ‘long long unsigned
> int’, but argument 5 has type ‘resource_size_t {aka unsigned int}’
> [-Wformat=]
>
> Please fix that and resend.
> Dave.
I'll fix it up as follows and resend:
----------8<----------
---------->8----------
regards
Philipp
diff --git a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
index c24bbc4..33c9e1b 100644
--- a/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
+++ b/drivers/gpu/drm/mediatek/mtk_hdmi_ddc.c
@@ -319,8 +319,8 @@ static int mtk_hdmi_ddc_probe(struct platform_device *pdev)
dev_dbg(dev, "ddc->adap: %p\n", &ddc->adap);
dev_dbg(dev, "ddc->clk: %p\n", ddc->clk);
- dev_dbg(dev, "physical adr: 0x%llx, end: 0x%llx\n", mem->start,
- mem->end);
+ dev_dbg(dev, "physical adr: %pa, end: %pa\n", &mem->start,
+ &mem->end);
return 0;