From patchwork Fri Jun 17 08:25:19 2016 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Wilson X-Patchwork-Id: 9183021 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id B004460776 for ; Fri, 17 Jun 2016 08:25:58 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9E9682838A for ; Fri, 17 Jun 2016 08:25:58 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 93B5D283A2; Fri, 17 Jun 2016 08:25:58 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.1 required=2.0 tests=BAYES_00,DKIM_SIGNED, RCVD_IN_DNSWL_MED, T_DKIM_INVALID autolearn=unavailable version=3.3.1 Received: from gabe.freedesktop.org (gabe.freedesktop.org [131.252.210.177]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 45DD72838A for ; Fri, 17 Jun 2016 08:25:58 +0000 (UTC) Received: from gabe.freedesktop.org (localhost [127.0.0.1]) by gabe.freedesktop.org (Postfix) with ESMTP id 2C9636EB60; Fri, 17 Jun 2016 08:25:40 +0000 (UTC) X-Original-To: dri-devel@lists.freedesktop.org Delivered-To: dri-devel@lists.freedesktop.org Received: from mail-wm0-x244.google.com (mail-wm0-x244.google.com [IPv6:2a00:1450:400c:c09::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 531BB6EB58; Fri, 17 Jun 2016 08:25:36 +0000 (UTC) Received: by mail-wm0-x244.google.com with SMTP id r201so2653880wme.0; Fri, 17 Jun 2016 01:25:36 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:from:to:cc:subject:date:message-id:in-reply-to:references; bh=2WJdv47D+OMF/yyo1BQpChfgkcitT3Qi/uu506eMA8Y=; b=mFULx3Sr/yd91o2f0ieBdW3MYD1YVw7BOTk6vBWqvZUi2/OBN84eC9qjaLlLaVl0/w UUAGGbR0p3jr/mWyIFRrjw4TRuxPJ9JVV8LjfYurQuyEorS8wzbqoFmHozrw4GkXjbUK ZUuszvcQMMb5kE8GN1mxEMz5Qm4iQuESpACyaU644G8G0WtI4uwyi4C/HdQiNZGS6xII MlyX+UwTAt7vxvYtJ0fh0yGPjYu916CJkDcGGPeeoZAsc6G8O8KTdDt52oDaNTiOlrl8 ljlhG6TRHltT+iKl2/SzgKgS0MGndbPOPn3tm43Csux63qrnmfCKARARhp0IvNxacQRE cWvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:sender:from:to:cc:subject:date:message-id :in-reply-to:references; bh=2WJdv47D+OMF/yyo1BQpChfgkcitT3Qi/uu506eMA8Y=; b=CTZ2M71Czd8g5O9HQnFWdHLzXNelsuttFBHdDhk78iEF6kmKOLeK6l6a35YrwDkPdu Fs5hrgf6g4RAhybkAjgSUryDOYDbMyFGO8TyVKROHg27tXuoripmS5h9zFupgxieGjR1 jNeATkVmFqroZiaxKtR7LzjXpg4D3OkmRAy/kjskL8TX2cZYfXhsRDjnmDXVAw/oTf0P PiGZG7nq0N9bndTVQkSVtuFaXzhMwP2dsWGu9y3snizNNkqqOPoBM1lVsZCxpyCId81J /UrMpVqIGEukWY0ELMOJrKQ4AWS26oIgID3Xu9OKk0w1gFl5USaI/PcveJEwpDUIdEQB VEMQ== X-Gm-Message-State: ALyK8tIUWCAIShNw+UWr6NekfpEmQsFZo8ymctc/qXsPOSB377W+bT3Od3lCNVdlDvw5Vg== X-Received: by 10.28.136.21 with SMTP id k21mr1081003wmd.24.1466151934440; Fri, 17 Jun 2016 01:25:34 -0700 (PDT) Received: from haswell.alporthouse.com ([78.156.65.138]) by smtp.gmail.com with ESMTPSA id ag3sm6917055wjc.39.2016.06.17.01.25.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 17 Jun 2016 01:25:33 -0700 (PDT) From: Chris Wilson To: dri-devel@lists.freedesktop.org Subject: [PATCH 3/7] drm/atmel-hlcdc: Remove redundant calls to drm_connector_register_all() Date: Fri, 17 Jun 2016 09:25:19 +0100 Message-Id: <1466151923-1572-4-git-send-email-chris@chris-wilson.co.uk> X-Mailer: git-send-email 2.8.1 In-Reply-To: <1466151923-1572-1-git-send-email-chris@chris-wilson.co.uk> References: <1466151923-1572-1-git-send-email-chris@chris-wilson.co.uk> Cc: Daniel Vetter , intel-gfx@lists.freedesktop.org X-BeenThere: dri-devel@lists.freedesktop.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: Direct Rendering Infrastructure - Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" X-Virus-Scanned: ClamAV using ClamSMTP Up to now, the recommendation was for drivers to call drm_dev_register() followed by drm_connector_register_all(). Now that drm_connector_register() is safe against multiple invocations, we can move drm_connector_register_all() to drm_dev_register() and not suffer from any backwards compatibility issues with drivers not following the more rigorous init ordering. Signed-off-by: Chris Wilson Cc: Daniel Vetter Cc: Boris Brezillon Cc: David Airlie Cc: dri-devel@lists.freedesktop.org --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 7 ------- 1 file changed, 7 deletions(-) diff --git a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c index 9ecf16c7911d..99c4af697c8a 100644 --- a/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c +++ b/drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c @@ -815,15 +815,8 @@ static int atmel_hlcdc_dc_drm_probe(struct platform_device *pdev) if (ret) goto err_unload; - ret = drm_connector_register_all(ddev); - if (ret) - goto err_unregister; - return 0; -err_unregister: - drm_dev_unregister(ddev); - err_unload: atmel_hlcdc_dc_unload(ddev);