diff mbox

[2/2] drm/etnaviv: remove generic GPU init failure reporting

Message ID 1466160154-16886-2-git-send-email-l.stach@pengutronix.de (mailing list archive)
State New, archived
Headers show

Commit Message

Lucas Stach June 17, 2016, 10:42 a.m. UTC
The GPU init path now reports any errors which might occur more accurately
than what is possible with the generic "something failed" message.

Remove the generic reporting, so we don't log an error into dmesg anymore
if any of the GPU cores are ignored.

Signed-off-by: Lucas Stach <l.stach@pengutronix.de>
---
 drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

Comments

Christian Gmeiner June 20, 2016, 10:48 a.m. UTC | #1
2016-06-17 12:42 GMT+02:00 Lucas Stach <l.stach@pengutronix.de>:
> The GPU init path now reports any errors which might occur more accurately
> than what is possible with the generic "something failed" message.
>
> Remove the generic reporting, so we don't log an error into dmesg anymore
> if any of the GPU cores are ignored.
>
> Signed-off-by: Lucas Stach <l.stach@pengutronix.de>

Reviewed-by: Christian Gmeiner <christian.gmeiner@gmail.com>

> ---
>  drivers/gpu/drm/etnaviv/etnaviv_drv.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> index 3d4f56df8359..7c5a4b408961 100644
> --- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> +++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
> @@ -91,10 +91,8 @@ static void load_gpu(struct drm_device *dev)
>                         int ret;
>
>                         ret = etnaviv_gpu_init(g);
> -                       if (ret) {
> -                               dev_err(g->dev, "hw init failed: %d\n", ret);
> +                       if (ret)
>                                 priv->gpu[i] = NULL;
> -                       }
>                 }
>         }
>  }
> --
> 2.8.1
>
diff mbox

Patch

diff --git a/drivers/gpu/drm/etnaviv/etnaviv_drv.c b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
index 3d4f56df8359..7c5a4b408961 100644
--- a/drivers/gpu/drm/etnaviv/etnaviv_drv.c
+++ b/drivers/gpu/drm/etnaviv/etnaviv_drv.c
@@ -91,10 +91,8 @@  static void load_gpu(struct drm_device *dev)
 			int ret;
 
 			ret = etnaviv_gpu_init(g);
-			if (ret) {
-				dev_err(g->dev, "hw init failed: %d\n", ret);
+			if (ret)
 				priv->gpu[i] = NULL;
-			}
 		}
 	}
 }